TPE-Layout/2017-03-21

Weekly Status

Astley Chen

• bug 1342880 - Label runnables in layout/inspector/
  • land
• bug 1347047 - Remove AccessibleCaret expiration feature in single caret mode
  • land

Good Read:

• Power measurement on Intel platform
• Firefox 52 setTomeout Change

Boris Chiou

stylo animations

• bug 1347053 - stylo: division by zero in set_transition_delay when share profile from gecko profiler
  • land
• bug 1332633 - stylo: Implement ComputeDistance for AnimationValues
  • wip
• bug 1343153 - stylo: use servo css-parser for ParseEasing
  • r+

APZ

• bug 1348322 - Fix the initial values of gVelocityCurveFunction.
  • file | land

Reviews

• bug 1340958 - stylo: Gecko_GetAnimationRule mutates the effect set during the parallel traversal

Cameron McCormack

Stylo

• bug 1345695 - stylo: Assert that we have computed style in Servo_ResolveStyle when lazy computation is forbidden
  • debug
• bug 1301258 - mask off generated change hints for an element when only some have been subsumed by change hints on ancestors
  • r+
• bug 1346623 - anonymous content created with nsIDocument::InsertAnonymousContent can change from non-native to native AC
  • r+ | land
• bug 1348493 - stylo: call ClearServoDataFromSubtree on cloned canvas custom content
  • r+ | land
• bug 1347838 - Assertion failure: !IsResolved() (already resolved), at /home/worker/workspace/build/src/layout/style/nsStyleStruct.cpp:2005
• bug 1348746 - stylo: don't eagerly style new children from bindings if the pres shell hasn't been initialized yet
  • r+ | land

Stylo reviews

• bug 1345698 - stylo: Implement access to CSSNamespaceRule
• bug 1339674 - stylo: update glue to set transform-box as a StyleGeometryBox.
• bug 1340958 - stylo: Gecko_GetAnimationRule mutates the effect set during the parallel traversal
• bug 1347411 - stylo: Fix dynamic style recomputation for various simple enough anon boxes
• bug 1347381 - stylo: Restyle is not triggered properly when changing condition text of media rule
• bug 1340696 - stylo: need to support system colors
• bug 1341086 - stylo: need to support the :-moz-system-metric pseudo-class
• bug 1347273 - stylo: Media query parsing is bogus.
• bug 1347399 - stylo: Assertion failure: NS_IsMainThread(), at nsCSSValue.cpp:2823
• bug 1296516 - Cleanup a bit of code in layout/base
• servo/servo#15959 - Don't serialize url() twice
• servo/servo#15956 - Fix -moz-user-select: tri-state
• servo/servo#15941 - style: Fix media query parsing when invalid queries are present.
• servo/servo#15890 - selectors: Check the bloom filter at most once per complex selector.

Quantum DOM reviews

• bug 1342880 - Label runnables in layout/inspector/
• bug 1338446 - label runnables in layout/style/
• bug 1347820 - Label ScrollSelectionIntoViewEvent for nsSelection
• bug 1348236 - Label nsAutoScrollTimer for nsSelection

Other reviews

• bug 1340044 - Change the type of nsStyleDisplay::mTransformBox from uint_8 to StyleGeometryBox.
• bug 1318542 - [webvtt] support ::cue pseudoelement from document.
• bug 1348442 - Asynchronously load and cache content CSS

Jeremy Chen

Text layout

• bug 1343516 - Clean up the mess of PropertyProvider and its implementations
  • r+ | land

Quantum DOM

• bug 1347820 - Label ScrollSelectionIntoViewEvent for nsSelection
  • file | land
• bug 1348236 - Label nsAutoScrollTimer for nsSelection
  • file | land

Stylo

• bug 1348615 - stylo: implement/parse -{moz,webkit}-text-size-adjust and its gecko glue
  • file | land
• bug 1347819 - Change nsFont::languageOverride to store uint32_t directly
  • r-

Other

• #90 - git bz apply doesn't get the right authorship from mozreview
  • PR merged
  • moz-git-tools #64 - bump moz-git-tool to the latest version
• bug 1348899 - Update devtools' property db for CSS3 multicol column-span
  • file | land

Tingyu Lin

AccessibleCaret

• bug 1273045 - AccessibleCaret does not scroll together with the overflow:scroll div
  • land
• bug 1347047 - Remove AccessibleCaret expiration feature in single caret mode
  • review

Quantum DOM

• bug 1338446 - label runnables in layout/style/
  • land

stylo

• bug 1322570 - stylo: assert against calling GetParent for stylo-backed style contexts
  • r?

Tommy Kuo

Quantum DOM

• bug 1342867 - Label the runnable of ScrollOnFocusEvent in nsTextControlFrame.cpp
  • r?dholbert
• bug 1342863 - Label runnables in layout/base/
  • r?dholbert
• bug 1342874 - Label runnables in layout/xul/
  • r?dholbert
• bug 1348738 - Labeling timer callback using nsRepeatService
  • file | blocked by bug 1205480

XPCOM

• bug 1348221 - Implement NewNamedTimerCallback to create named timer callback
  • file | land
• bug 1348900 - Deprecate NewTimerCallback
  • file | blocked by bug 1342863

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics