Confirmed users
3,376
edits
Auto-tools/Projects/Stockwell/disable-recommended: Difference between revisions
Auto-tools/Projects/Stockwell/disable-recommended (view source)
Revision as of 16:26, 9 February 2018
, 9 February 2018→Making a patch: - making a patch.
m (→Determining which platforms are affected: - example of all) |
(→Making a patch: - making a patch.) |
||
| Line 150: | Line 150: | ||
hg qrefresh # update your patch with local file changes | hg qrefresh # update your patch with local file changes | ||
hg qrefresh -e # edit the commit message associated with your patch | hg qrefresh -e # edit the commit message associated with your patch | ||
I typically follow this workflow: | |||
hg qnew bug1234567.patch | |||
<edit> <manifest>.ini | |||
hg qrefresh | |||
hg qdiff # self review | |||
hg qrefresh -e | |||
<inside editor add comment |Bug 1234567 - disable <test> for frequent failures. r=gbrown| and save> | |||
cp .hg/patches/bug1234567.patch ~/ | |||
hg qpop | |||
NOTE: the self review is a great time to make sure: | |||
* there are not extra spaces on a blank line or at the end of a line, if there are they will be highlighted in red | |||
* you are only editing one line in a file, not multiple lines on accident | |||
* a chance to review your syntax and any comments | |||
NOTE: the comment for the commit needs to follow the general pattern above. | |||
=== Requesting review === | === Requesting review === | ||