Confirmed users
3,376
edits
Auto-tools/Projects/Stockwell/disable-recommended: Difference between revisions
Auto-tools/Projects/Stockwell/disable-recommended (view source)
Revision as of 17:07, 22 February 2019
, 22 February 2019→Requesting review: - webrender
(→Requesting review: - webrender) |
|||
| Line 189: | Line 189: | ||
== Requesting review == | == Requesting review == | ||
In bugzilla, in the bug with [stockwell disable-recommended], use "Attach File" to attach your patch. Browse to find the patch in <your repo directory>/.hg/patches. Make sure you select "patch" for the Content Type. Then request review, "r?", and select a reviewer. In most cases, ask :gbrown or :jmaher for review. | In bugzilla, in the bug with [stockwell disable-recommended], use "Attach File" to attach your patch. Browse to find the patch in <your repo directory>/.hg/patches. Make sure you select "patch" for the Content Type. Then request review, "r?", and select a reviewer. In most cases, ask :gbrown or :jmaher for review. | ||
'''One exception is if you are disabling a test that is webrender only, please make sure to ask :kats for review.''' | |||
In the above section it was suggested to copy your patch to ~/ via | In the above section it was suggested to copy your patch to ~/ via | ||