canmove, Confirmed users
637
edits
Line 54: | Line 54: | ||
== Review comments == | == Review comments == | ||
* nanoJIT needs a separate security review | |||
* GC has been largely disconnected from tracing: if GC happens while we're recording we keep recording (so nothing is interrupted when it's not expecting it) but we throw away the trace. | |||
* main attack would be getting us to generate dangerous code. | |||
* could generated code access DOM objects that interpreted code would not be allowed? | |||
* multi-threaded doesn't work with shared globals -- native/interpreted or two native threads using the same variables would have their own copies. We currently disallow this. | |||
* Need Jason's patch to land, can create corner cases where we mishandle builtins |