Confirmed users
571
edits
Sheriffing/How To/Landing patches: Difference between revisions
added instructions for manually landing a patch from he command line
m (Archaeopteryx moved page Sheriffing/How To/Landing checkin-needed patches to Sheriffing/How To/Landing patches: checkin-needed not handled by sheriffs anymore, switch focus how to manually land a patch if necessary) |
(added instructions for manually landing a patch from he command line) |
||
| Line 1: | Line 1: | ||
{{Sheriffing How To|Landing check-needed patches}} | {{Sheriffing How To|Landing check-needed patches}} | ||
= Manually landing a patch = | |||
A patch can be landed manually if | |||
* the repository in which it shall land is not supported by Lando or | |||
* the repository is closed for landing patches with Lando and the patch needs to land now. | |||
Apply the patch from Phabricator: | |||
<code>moz-phab patch D<number> --apply-to . --skip-dependencies</code> | |||
<code>--skip-dependencies</code> ensures only the selected patch gets applied. This prevents accidentally applying more patches in the patch stack (the ones between the revision used as base for development and the one mentioned in the command). If a patch stack shall land, drop this argument but still check only the intended patches get applied. | |||
The commit message has to be updated to add the granted reviews: | |||
<code>hg commit --amend</code> | |||
In case the commit messages of a patch stack shall be edited: | |||
<code>hg histedit</code> | |||
Select <code>m</code> for <code>mess</code> and save to get prompted for the commit message for each commit. | |||
= Phabricator queries for revisions requiring check-in = | = Phabricator queries for revisions requiring check-in = | ||
People only get the permission to land changes after repeated contributions. Until they can land them, the reviewers are expected to land their changes. Sheriffs should not land such patches. The documentation for the workflow below is kept for potential future use. | |||
* There is a saved Phabricator differential query that may be used to find revisions requiring check-in. | * There is a saved Phabricator differential query that may be used to find revisions requiring check-in. | ||
** Visit https://phabricator.services.mozilla.com/differential/ and click the '''#Check-in Needed''' link in the left menu’s list of queries. | ** Visit https://phabricator.services.mozilla.com/differential/ and click the '''#Check-in Needed''' link in the left menu’s list of queries. | ||