Tree Rules: Difference between revisions
Jump to navigation
Jump to search
| Line 14: | Line 14: | ||
== [http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox3.1 mozilla-1.9.1] - 1.9.1 Branch (Firefox 3.5.x, Gecko 1.9.1 work) == | == [http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox3.1 mozilla-1.9.1] - 1.9.1 Branch (Firefox 3.5.x, Gecko 1.9.1 work) == | ||
'''When open: <font color="orange">RESTRICTED</font>''' | '''When open: <font color="orange">RESTRICTED</font>''' to approved checkins only | ||
=== Rules === | === Rules === | ||
* patches must have been checked in and "baked" on mozilla-central, | * patches must have been checked in and "baked" on mozilla-central, | ||
* patches must | * patches must have '''approval1.9.1.x+''' (for whatever value of x is relevant). | ||
* | * Set the "status1.9.1" flag to the relevant "fixed .x" value when the patch has been checked into the branch | ||
Patches nominated for approval1.9.1 should: | Patches nominated for approval1.9.1.x+ should: | ||
* have tests, or a strong statement of what can be done in the absence of tests | * have tests, or a strong statement of what can be done in the absence of tests | ||
* have landed on trunk and baked for a few days (at least) | * have landed on trunk and baked for a few days (at least) | ||
Revision as of 12:37, 16 July 2009
mozilla-central - Trunk (Firefox 3.6, Gecko 1.9.2 work)
When open: OPEN to all checkins.
Rules
- Do not check in until you have appropriate review, including super-review and approval if needed.
- Do not check in when any box is orange or red, unless the failure has been starred with a bug number or a fix. (You should be pretty sure the next cycle will be green and all recent intermittent failures are understood.)
- You should be available for the next hour or two in case something goes wrong with your checkin. (This is roughly the time it takes to get unit test results from all platforms.)
- Automated unit tests must pass and not leak.
- Automated speed tests must not regress (performance regression policy).
Please see #developers or today's Sheriff if you have questions.
mozilla-1.9.1 - 1.9.1 Branch (Firefox 3.5.x, Gecko 1.9.1 work)
When open: RESTRICTED to approved checkins only
Rules
- patches must have been checked in and "baked" on mozilla-central,
- patches must have approval1.9.1.x+ (for whatever value of x is relevant).
- Set the "status1.9.1" flag to the relevant "fixed .x" value when the patch has been checked into the branch
Patches nominated for approval1.9.1.x+ should:
- have tests, or a strong statement of what can be done in the absence of tests
- have landed on trunk and baked for a few days (at least)
- have an assessment of performance impact
- have an assessment of risk
Please see #developers or today's Sheriff if you have questions.
Firefox3.0 - Branch (Firefox 3.0.x only)
When open: RESTRICTED to branch-approved checkins only
Rules
- patches must have approval1.9.0.x+ (for whatever version of x we are currently approving), or not affect the Firefox build (tests, NPOTB changes)
- add the fixed1.9.0.x keyword to the bug when it has been checked into the branch
Patches nominated for approval-1.9.0.x should:
- have tests, or a strong statement of what can be done in the absence of tests
- have landed on trunk and baked for a few days (at least)
- have an assessment of performance impact
- have an assessment of risk
This tree is not sheriff'd. Please be sure to monitor for any bustage or performance regressions on the tree and take the appropriate back out actions.
Patch Approval & Release Driving
The branch approval queue is being monitored by branch drivers, all of whom are usually available on IRC.