Jetpack/Contribution: Difference between revisions
< Jetpack
Jump to navigation
Jump to search
| Line 6: | Line 6: | ||
* In order to land, patches must have review from a core Jetpack developer | * In order to land, patches must have review from a core Jetpack developer | ||
* Patches should have additional API review when needed | * Patches should have additional API review when needed | ||
* Patches should have additional review from a Mozilla platform domain-expert when needed | * Patches should have additional review from a Mozilla platform domain-expert when needed | ||
If you have questions, ask in [irc://irc.mozilla.org/#jetpack #jetpack on IRC] or on the [http://groups.google.com/group/mozilla-labs-jetpack Jetpack mailing list]. | |||
= How to Make Code Contributions = | = How to Make Code Contributions = | ||
Revision as of 20:56, 14 April 2010
Overview
- Changes should follow the design guidelines for Jetpack
- Changes must follow the code style guide for Jetpack
- All changes must be accompanied by tests
- In order to land, patches must have review from a core Jetpack developer
- Patches should have additional API review when needed
- Patches should have additional review from a Mozilla platform domain-expert when needed
If you have questions, ask in #jetpack on IRC or on the Jetpack mailing list.
How to Make Code Contributions
If you have code that you'd like to contribute the Jetpack project, follow these steps:
- Look for your issue in the bugs already filed
- If no bug exists, file one here
- Make your changes, per the Overview
- Write a test (intro, API)
- Attach your code changes and tests in a combined patch to the bug
- Ask for code review by setting the "review" flag on your attachment to "?" and entering the email of one of the following:
- For changes to the Jetpack core, ask Atul
- For Mozilla platform usage, ask Drew, Myk or Dietrich (and they can find the domain expert)
- For API and developer ergonomics review, ask Myk