Revision as of 21:04, 14 April 2010

Overview

Changes should follow the design guidelines for Jetpack
Changes must follow the code style guide for Jetpack
All changes must be accompanied by tests
In order to land, patches must have review from a core Jetpack developer
Patches should have additional API review when needed
Patches should have additional review from a Mozilla platform domain-expert when needed

If you have questions, ask in #jetpack on IRC or on the Jetpack mailing list.

If you have code that you'd like to contribute the Jetpack project, follow these steps:

Look for your issue in the bugs already filed
If no bug exists, file one here
Make your changes, per the Overview
Write a test (intro, API)
Attach your code changes and tests in a combined patch to the bug
Ask for code review by setting one or more "review" flags on your attachment to "?" and entering the email of the appropriate developer (noted in Reviewers below)

All changes must be reviewed by Atul, until the platform settles
On top of Atul's review:
- For review of Mozilla platform usage and best practices, ask review from Drew, Myk or Dietrich (and they can find the domain expert)
- For API and developer ergonomics review, ask Myk

@@ Line 19: / Line 19: @@
 # Write a test ([https://jetpack.mozillalabs.com/sdk/latest/docs/#guide/packaging intro], [https://jetpack.mozillalabs.com/sdk/latest/docs/#module/jetpack-core/unit-test API])
 # Attach your code changes and tests in a combined patch to the bug
-# Ask for code review by setting the "review" flag on your attachment to "?" and entering the email of the appropriate developer
+# Ask for code review by setting one or more "review" flags on your attachment to "?" and entering the email of the appropriate developer (noted in [[Labs/Jetpack/Contribution#Reviewers|Reviewers]] below)
 = Reviewers =