Confirmed users
161
edits
m (→TODO: add links to google groups) |
(move jquery from 'other issues' to TODO) |
||
Line 153: | Line 153: | ||
* Scripts in the original JEP run in the context of the page, while in this JEP they run in the jetpack context. Although it's an important feature, I think it can be implemented separately, since it requires substantially more effort and additional coordination for e10s. | * Scripts in the original JEP run in the context of the page, while in this JEP they run in the jetpack context. Although it's an important feature, I think it can be implemented separately, since it requires substantially more effort and additional coordination for e10s. | ||
* <code>add/remove/empty</code> methods on the page mod object were not included, since there's no clear use case for them, especially if the changes are not applied instantly, as in this proposal. | * <code>add/remove/empty</code> methods on the page mod object were not included, since there's no clear use case for them, especially if the changes are not applied instantly, as in this proposal. | ||
=== TODO === | === TODO === | ||
Line 171: | Line 167: | ||
*#** [http://groups.google.com/group/mozilla-labs-jetpack/msg/e23a845e70561473 Nickolay]: disagreed - XPCNW are very visible, "I'm keeping wrappedWindow for now, pending the decision to just pass an unwrapped value to the callback." | *#** [http://groups.google.com/group/mozilla-labs-jetpack/msg/e23a845e70561473 Nickolay]: disagreed - XPCNW are very visible, "I'm keeping wrappedWindow for now, pending the decision to just pass an unwrapped value to the callback." | ||
*#* [docs] encourage addon developers to clean up after their page mods via the unload module. (The clean up actions should also run when the script mod is removed). | *#* [docs] encourage addon developers to clean up after their page mods via the unload module. (The clean up actions should also run when the script mod is removed). | ||
*#* [docs] Should provide an example of using jQuery in a script mod. | |||
* Post-0.5: | * Post-0.5: | ||
*# Possible API enhancements: | *# Possible API enhancements: |