Calendar Talk:Deprecated:Build System: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
(lilmatt to sipaq:)
No edit summary
Line 21: Line 21:
             components
             components
             content
             content
            locale
             themes
             themes
         locales
         locales
             en-US
             en-US
                 chrome
                 chrome
                    calendar
                    lightning  <-- was /m/cal/lightning/locale
         providers
         providers
         resources      <-- to be deprecated, content gets merged into base
         resources      <-- to be deprecated, content gets merged into base
Line 48: Line 49:


Those files should go into cal/locales/en-US/chrome/lightning or cal/locales/en-US/lightning/chrome
Those files should go into cal/locales/en-US/chrome/lightning or cal/locales/en-US/lightning/chrome
== lilmatt to KaiRo ==
Agreed on the lightning locale change. Diagram has been updated accordingly.
I chose "components" to match Ff and Tb. I'm open to something more descriptive, or leaving the idl/cpp stuff where it is now (/m/cal/base/src, public) and not including a "components" directory.


== lilmatt to sipaq: ==
== lilmatt to sipaq: ==


Actually, that does make more sense, and the locale under lightning was more because that's where it currently lives versus where it should go.  
Actually, that does make more sense, and the locale under lightning was more because that's where it currently lives versus where it should go.  
 
I've updated the diagram to reflect that.
I'll update the diagram to reflect that.

Revision as of 23:48, 1 April 2006

Here's my suggestion for changing our layout. Thoughts?

mozilla
   calendar
       app             <-- was /m/cal/sunbird/app
       base
           branding    <-- tri-licensed "Calendar" branding
           build
           content     <-- dir merged with /m/cal/sunbird/base/content
           public
           src
       components      <-- stuff from /m/cal/base/build, content, public, src
       config          <-- was /m/cal/sunbird/config
       import-export
       installer
           linux
           windows
       libical
       lightning
           components
           content
           themes
       locales
           en-US
               chrome
                   calendar
                   lightning   <-- was /m/cal/lightning/locale
       providers
       resources       <-- to be deprecated, content gets merged into base
           locale      <-- subdirs move to mozilla/l10n/AB_CD/calendar
           skin        <-- merge shared items into m/cal/themes
       test
       themes          <-- merge /m/cal/base/themes and /m/cal/sunbird/themes
           pinstripe
           winstripe
       xpi
           icons       <-- was /m/cal/os2, /m/cal/linux, /m/cal/windows
           skin        <-- xpi-only items from /m/cal/resources/skin

Comments

  • All localizable stuff should go into locales/ (structure of that one looks correct to me here), I think it might be a good idea to include lightning's resources there as well.
  • components/ is a bad directory name, you should organize things by function, not by how it's built - see this talk with bsmedberg about suite/ organistation about some good stuff about how an application's directory in the mozilla.org repository should be organized. It's probably a good idea to also ask bsmedberg for his opinion on your proposal (though he'll surely tell the same about components/ as in the linked discussion).

--KaiRo 14:54, 1 April 2006 (PST)

sipaq's comments

I don't like the cal/lightning/locale stuff.

Those files should go into cal/locales/en-US/chrome/lightning or cal/locales/en-US/lightning/chrome

lilmatt to KaiRo

Agreed on the lightning locale change. Diagram has been updated accordingly. I chose "components" to match Ff and Tb. I'm open to something more descriptive, or leaving the idl/cpp stuff where it is now (/m/cal/base/src, public) and not including a "components" directory.

lilmatt to sipaq:

Actually, that does make more sense, and the locale under lightning was more because that's where it currently lives versus where it should go. I've updated the diagram to reflect that.