244
edits
Update:Archive/1.0/Developers: Difference between revisions
m
→/core/dbconfig.php
(Added bug link) |
|||
| Line 310: | Line 310: | ||
====/core/dbconfig.php==== | ====/core/dbconfig.php==== | ||
* [48] $db (a boolean) is assigned to the returned value of mysql_select_db, but never used anywhere | * [48] $db (a boolean) is assigned to the returned value of mysql_select_db, but never used anywhere | ||
* This file is pointless. DB information should just be defined in config.php. | * This file is pointless. DB information should just be defined in config.php. (alanjstr says: the problem would be the includes at the bottom of core/config.php. VersionCheck doesn't need all of that) | ||
* This file should not create the connection. Connections should only be created when they will be used. As it stands, this forces every page on UMO to create a DB connection whether or not it will be used for anything. | * This file should not create the connection. Connections should only be created when they will be used. As it stands, this forces every page on UMO to create a DB connection whether or not it will be used for anything. | ||
* Someone could use a script, point at this file and create however many unused DB connections they wanted by simply opening it. | * Someone could use a script, point at this file and create however many unused DB connections they wanted by simply opening it. | ||