canmove, Confirmed users
1,567
edits
Toolkit/Code Review: Difference between revisions
→Who should review my patch?
No edit summary |
|||
| Line 3: | Line 3: | ||
== Who should review my patch? == | == Who should review my patch? == | ||
For patches (or parts of patches) that affect code in the Toolkit directories any of the [[Modules/Toolkit|Toolkit reviewers]] can be asked to review your patch. Many of the reviewers have particular areas of expertise so it is often preferable to choose a reviewer based on the sub-module the patch changes. | For patches (or parts of patches) that affect code in the Toolkit directories any of the [[Modules/Toolkit|Toolkit reviewers]] can be asked to review your patch. Many of the reviewers have particular areas of expertise so it is often preferable to choose a reviewer based on the [[Toolkit/Submodules|sub-module]] the patch changes. | ||
* Patches that make behavioral or API changes to Toolkit should either be reviewed by the sub-module owner or at least get feedback from them in addition to review by a Toolkit reviewer. | * Patches that make behavioral or API changes to Toolkit should either be reviewed by the sub-module owner or at least get feedback from them in addition to review by a Toolkit reviewer. | ||