|
|
| Line 11: |
Line 11: |
| |- | | |- |
| | Awesomebar Search Provider Reset | | | Awesomebar Search Provider Reset |
| | In Development | | | {{StatusHealthy|status=Landed}} |
| | Firefox 20 | | | Firefox 23 |
| | Gavin Sharp | | | Gavin Sharp |
| | Manuela Muntean | | | Manuela Muntean |
| | In Progress | | | {{StatusHealthy|status=Signed Off}} |
| |} | | |} |
|
| |
|
| == Summary == | | == Summary == |
|
| |
|
| Users falling victim to "search hijacking" (keyword.URL being taken over by an unwanted search engine) is a common problem.
| | * keyword.URL and originalDefaultEngine preferences have been removed |
| | | * When setting an engine in the Search bar, it is also set as the search engine for the URL bar, about:home (after reload) and in the contextual menu option |
| There are two cases we can detect:
| |
| *pref is changed, and the hostname is different (e.g. switched from the default of Google to SuperAwesomeWebDealsSearch.com)
| |
| *pref is changed, and only parameters are different (e.g. user customized to a specific type of Google search, or referral codes where added)
| |
| | |
| In either case, we could prompt the user and offer to reset the keyword.URL value to the default after they trigger a search from the location bar.
| |
| | |
| *[https://bug718088.bugzilla.mozilla.org/attachment.cgi?id=600146 Screenshot of notification]
| |
|
| |
|
| == Reference == | | == Reference == |
|
| |
|
| *{{Bug|718088}} - offer to re-set keyword.URL if it has a non-default value - '''RESOLVED FIXED''' | | *{{Bug|738818}} - consolidate Firefox search preferences - '''VERIFIED FIXED''' |
|
| |
|
| == Use Cases to Test == | | == Use Cases to Test == |
|
| |
|
| Test that the notification which prompts the user is displayed when
| |
| *manually changing keyword.URL pref from "about:config", and then actually performing a keyword search
| |
| *installing an add-on that automatically changes the keyword.URL pref, and then actually performing a keyword search
| |
|
| |
| == Test Cases ==
| |
|
| |
|
| * Test cases and test results can be seen in the [http://bit.ly/1404VTE Google Spreadsheet] | | * |
| * They are also present in MozTrap, in the Awesomebar Search Provider Reset test suite. | | * |
|
| |
|
| ==Bugs ==
| |
|
| |
| *{{Bug|732671}} - Prevent third party apps to change default search engine - '''RESOLVED DUPLICATE'''
| |
| *{{Bug|784189}} - Offer to re-set keyword.URL if it has a non-default value until a better solution can be found - '''RESOLVED DUPLICATE'''
| |
| *{{Bug|736878}} - keyword.URL reset prompt doesn't properly re-set prefs if default engine is modified - '''RESOLVED FIXED'''
| |
| *{{Bug|744957}} - Enhancements to help mitigate search hijacking - '''RESOLVED INCOMPLETE'''
| |
| *{{Bug|838864}} - keyword.URL reset interferes poorly with some partner add-ons - '''ASSIGNED'''
| |
| *{{Bug|839410}} - Notification appearing after setting keyword.URL to "http://www.google.com" or "http://www.search.google.com" - '''NEW'''
| |
| *{{Bug|839416}} - keyword.URL reset notification doesn't appear after setting keyword.URL to an invalid URL - '''NEW'''
| |
| *{{Bug|839629}} - Fix partner add-ons so that search pref changes comply with add-on guidelines - '''NEW'''
| |
|
| |
|
| == Sign off == | | == Sign off == |
|
| |
|
| ;Criteria | | ;Criteria |
| *All the test cases were executed. | | *All the use cases were executed. |
| *All the blocker, critical, major bugs have been fixed. | | *All the blocker, critical, major bugs have been fixed. |
|
| |
|
| ;Firefox 19 beta 5 - 2013-02-07 | | ;Firefox 23 Aurora (pre-beta sign off) - 06/21/2013 |
| *{{Bug|839410}} - Notification appearing after setting keyword.URL to "http://www.google.com" or "http://www.search.google.com"
| | |
| *{{Bug|839416}} - Notification doesn't appear after setting keyword.URL to something without "http://" or with an invalid URL
| | * On the next OSs: |
| *Regarding the following add-ons installation: | | ** Windows 7 64bit |
| **a) Ask.com
| | ** Windows 8 32bit |
| **b) Snap.do
| | ** Ubuntu 12.10 32bit |
| **c) Babylon
| | ** Mac OSX 10.8.3 |
| **d) ScumBag 2000
| |
| **e) Claro Search
| |
| **f) MyStart Incredibar
| |
| *The results, grouped by OSs, are next:
| |
| **Windows 7 64-bit: | |
| ***a) couldn't install
| |
| ***b) changes the pref; the notification appears and works as expected
| |
| ***c) doesn't change the pref
| |
| ***d) couldn't find it
| |
| ***e) couldn't find it
| |
| ***f) Incredibar EN 10.14.40.128 installed; doesn't change the pref after installation
| |
| **Windows 8 32-bit: | |
| ***a) couldn't install
| |
| ***b) changes the pref; the notification appears and works as expected
| |
| ***c) doesn't change the pref
| |
| ***d) couldn't find it
| |
| ***e) couldn't find it
| |
| ***f) Incredibar EN 10.14.40.128 installed; doesn't change the pref after installation
| |
| **Ubuntu 12.04 32-bit: | |
| ***a) couldn't install
| |
| ***b) couldn't find a source for Ubuntu
| |
| ***c) not available for Ubuntu
| |
| ***d) couldn't find a source for Ubuntu
| |
| ***e) couldn't find a source for Ubuntu
| |
| ***f) couldn't find a source for Ubuntu
| |
| **Mac OSX 10.8.2: | |
| ***a) couldn't find a source for Mac
| |
| ***b) couldn't find a source for Mac
| |
| ***c) couldn't find a source for Mac
| |
| ***d) couldn't find a source for Mac
| |
| ***e) couldn't find a source for Mac
| |
| ***f) Incredibar EN 3.16.0.3 installed; it doesn't change the pref after installation
| |
| **Windows Vista 32-bit:
| |
| ***Ask.com add-on:
| |
| ****i) changes the pref; the notification appears and works as expected (see attached photo)
| |
| ****ii) when choosing "Yes, use Google", the pref resets to its default value
| |
| **Windows XP 32-bit:
| |
| ***Ask.com add-on:
| |
| ****couldn't install
| |