Firefox OS/Comms/Dialer/Sprint/v2.1-S1: Difference between revisions

From MozillaWiki
< Firefox OS‎ | Comms‎ | Dialer‎ | Sprint
Jump to navigation Jump to search
Line 58: Line 58:
==Day 10: August 4==
==Day 10: August 4==
{{:FirefoxOS/Comms/Dialer/Sprint/v2.1-S1/20140804-Minutes|Meeting Minutes}}
{{:FirefoxOS/Comms/Dialer/Sprint/v2.1-S1/20140804-Minutes|Meeting Minutes}}
====gtorodelvalle====
* Administrative:
** I spent most of today "welcoming" Jorge Prudencio, the new intern who will join us :) You know, installing the environment and so on. I will introduce him to you tomorrow hopefully.
* {{Bug|977056}} - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
** Patch ready.
** ui-review+ by Carrie. I will record a new video tomorrow showing the suggested conference call duration. This is already included in the patch to be reviewed.
** I could not record the video due to a bug when establishing the second call: https://www.dropbox.com/s/8uhokyag1mzu8qm/add_second_call.png I will check with you during the meeting and if not know, I will create the bug.
* {{Bug|1043347}} - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
** ui-review+ by Carol.
** Asked for review from Anthony.
** Rebased :-)
* {{Bug|977588}} - [Dialer] The Active call screen does not have the option to place calls on hold:
** Proposal made to Carrie and asked need-info to her regarding the final implementation.
** Hopefully she agrees since we are following the proposed path ;)
** Paco is working on the visual part.


====pacorampas====
====pacorampas====

Revision as of 15:40, 4 August 2014

Bugs

Bugs Taken in Planning

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
967440 Anthony Ricaud (:rik) Remove some reflows on the keypad - No cf_feature-b2g [priority][planned-sprint c=3][in-sprint=v2.0-S6] RESOLVED FIXED
995938 David Garcia [:davidg][retired] Device does not play an 'end tone' when the call is finished --- No cf_feature-b2g [priority][planned-sprint c=2] VERIFIED FIXED
998147 Tamara Hills [:thills] [Dialer] A Missed Call notification is given when chosing to hang up on an incoming call 2.0+ No cf_feature-b2g [tarako-bug-bash-1.3T][planned-sprint][in-sprint=v2.0-S6] VERIFIED FIXED
1006592 Gabriele Svelto [:gsvelto] While sending USSD code, last dialed number by user appears in dialer app 2.0+ No cf_feature-b2g [planned-sprint] VERIFIED FIXED
1010104 Germán Toro del Valle (:gtorodelvalle) [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size --- No cf_feature-b2g [planned-sprint c=1][in-sprint=v2.0-S6] RESOLVED FIXED
1015883 Gabriele Svelto [:gsvelto] [Dialer][Call Screen][Call Waiting] Apply the visual refresh to the CDMA call waiting scenario - No cf_feature-b2g [planned-sprint c=3] RESOLVED FIXED
1023246 Paco Rampas [:paco] [Flame][v1.4][Gaia::Dialer]The contact’s photo is shown incompletely in the call log edit screen. --- No cf_feature-b2g torch [planned-sprint] RESOLVED WONTFIX
1033937 Paco Rampas [:paco] [Calllog] Tap on Withheld number in call log, item highlighted, but stay highlighted when finger released - No cf_feature-b2g [planned-sprint] VERIFIED FIXED
1039553 Doug Sherk (:drs) (inactive) [Dialer][Call Screen] It's not possible to start a second call --- No cf_feature-b2g [planned-sprint] RESOLVED WORKSFORME

9 Total; 0 Open (0%); 5 Resolved (55.56%); 4 Verified (44.44%);

Bugs Taken but not Completed

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
1039643 Tamara Hills [:thills] Write some unit tests for shared/js/dialer/contacts.js --- No cf_feature-b2g [planned-sprint c=][in-sprint=v2.1-S1] RESOLVED FIXED

1 Total; 0 Open (0%); 1 Resolved (100%); 0 Verified (0%);

Bugs Taken During Sprint

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
1021478 Doug Sherk (:drs) (inactive) Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message 2.0M+ No cf_feature-b2g RESOLVED FIXED
1030623 Paco Rampas [:paco] [Dialer] No space between text and border when Contact with long name and number matching hits --- No cf_feature-b2g VERIFIED FIXED
1043318 Paco Rampas [:paco] [Dialer] [Keypad] On suggestion item when the text goes outside the edge, you can drag the upper part and move the whole screen. --- No cf_feature-b2g RESOLVED FIXED
1043904 Paco Rampas [:paco] [Dialer][Call screen] There is a empty line at bottom of background image --- No cf_feature-b2g VERIFIED FIXED
1047224 Paco Rampas [:paco] [Dialer] [Keypad] Follow up for 1043318 --- No cf_feature-b2g RESOLVED FIXED

5 Total; 0 Open (0%); 3 Resolved (60%); 2 Verified (40%);

All Issues for this Sprint

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Whiteboard Status Resolution
967440 Anthony Ricaud (:rik) Remove some reflows on the keypad - --- [priority][planned-sprint c=3][in-sprint=v2.0-S6] RESOLVED FIXED
995938 David Garcia [:davidg][retired] Device does not play an 'end tone' when the call is finished --- --- [priority][planned-sprint c=2] VERIFIED FIXED
998147 Tamara Hills [:thills] [Dialer] A Missed Call notification is given when chosing to hang up on an incoming call 2.0+ --- [tarako-bug-bash-1.3T][planned-sprint][in-sprint=v2.0-S6] VERIFIED FIXED
1006592 Gabriele Svelto [:gsvelto] While sending USSD code, last dialed number by user appears in dialer app 2.0+ --- [planned-sprint] VERIFIED FIXED
1010104 Germán Toro del Valle (:gtorodelvalle) [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size --- --- [planned-sprint c=1][in-sprint=v2.0-S6] RESOLVED FIXED
1015883 Gabriele Svelto [:gsvelto] [Dialer][Call Screen][Call Waiting] Apply the visual refresh to the CDMA call waiting scenario - --- [planned-sprint c=3] RESOLVED FIXED
1021478 Doug Sherk (:drs) (inactive) Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message 2.0M+ --- RESOLVED FIXED
1023246 Paco Rampas [:paco] [Flame][v1.4][Gaia::Dialer]The contact’s photo is shown incompletely in the call log edit screen. --- --- torch [planned-sprint] RESOLVED WONTFIX
1030623 Paco Rampas [:paco] [Dialer] No space between text and border when Contact with long name and number matching hits --- --- VERIFIED FIXED
1033937 Paco Rampas [:paco] [Calllog] Tap on Withheld number in call log, item highlighted, but stay highlighted when finger released - --- [planned-sprint] VERIFIED FIXED
1039553 Doug Sherk (:drs) (inactive) [Dialer][Call Screen] It's not possible to start a second call --- --- [planned-sprint] RESOLVED WORKSFORME
1043318 Paco Rampas [:paco] [Dialer] [Keypad] On suggestion item when the text goes outside the edge, you can drag the upper part and move the whole screen. --- --- RESOLVED FIXED
1043904 Paco Rampas [:paco] [Dialer][Call screen] There is a empty line at bottom of background image --- --- VERIFIED FIXED
1047224 Paco Rampas [:paco] [Dialer] [Keypad] Follow up for 1043318 --- --- RESOLVED FIXED

14 Total; 0 Open (0%); 8 Resolved (57.14%); 6 Verified (42.86%);

Bugs Redirected

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Whiteboard Status Resolution
967440 Anthony Ricaud (:rik) Remove some reflows on the keypad - --- [priority][planned-sprint c=3][in-sprint=v2.0-S6] RESOLVED FIXED
995938 David Garcia [:davidg][retired] Device does not play an 'end tone' when the call is finished --- --- [priority][planned-sprint c=2] VERIFIED FIXED
998147 Tamara Hills [:thills] [Dialer] A Missed Call notification is given when chosing to hang up on an incoming call 2.0+ --- [tarako-bug-bash-1.3T][planned-sprint][in-sprint=v2.0-S6] VERIFIED FIXED
1006592 Gabriele Svelto [:gsvelto] While sending USSD code, last dialed number by user appears in dialer app 2.0+ --- [planned-sprint] VERIFIED FIXED
1010104 Germán Toro del Valle (:gtorodelvalle) [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size --- --- [planned-sprint c=1][in-sprint=v2.0-S6] RESOLVED FIXED
1015883 Gabriele Svelto [:gsvelto] [Dialer][Call Screen][Call Waiting] Apply the visual refresh to the CDMA call waiting scenario - --- [planned-sprint c=3] RESOLVED FIXED
1023246 Paco Rampas [:paco] [Flame][v1.4][Gaia::Dialer]The contact’s photo is shown incompletely in the call log edit screen. --- --- torch [planned-sprint] RESOLVED WONTFIX
1033937 Paco Rampas [:paco] [Calllog] Tap on Withheld number in call log, item highlighted, but stay highlighted when finger released - --- [planned-sprint] VERIFIED FIXED
1039553 Doug Sherk (:drs) (inactive) [Dialer][Call Screen] It's not possible to start a second call --- --- [planned-sprint] RESOLVED WORKSFORME

9 Total; 0 Open (0%); 5 Resolved (55.56%); 4 Verified (44.44%);


Daily Meetings

  • Current hosts: drs, gtorodelvalle, thills
  • Hosts rotate every week.
  1. If you're not available for a standup that you're scheduled to host, then ask for someone else to host instead for just that time.
  2. Start by pinging everyone who should be participating.
  3. List any administrative items you have, and then ask for more from other people (look at the Etherpad).
  4. Look at the list of blockers and blocker nominations and see if there's anything new or that needs action. Mention these during this time.
  5. Move to individual updates. Go alphabetically, in descending order.
  6. If someone's update is taking longer than 3-4 minutes, you should generally cut them off and ask them to talk about it after the standup.
  7. Copy the reports from the GDoc to the wiki page for that day. Use the Etherpad-to-Wiki converter to format it. You can just copy and paste the whole thing and the converter will do everything for you.
  8. Ask the person who should be hosting the week after you if they'll be available. If not, move onto the next person.

Day 10: August 4

drs

  • On public holiday on Monday, will provide my update on Tuesday.
  • Sprint planning will be on Tuesday.
  • Please run the standup as usual on Monday. Anthony and I will not be there.
  • I will host it in return for you hosting it on Friday :p Ups! It seems it's Tamara's turn :)

gtorodelvalle

  • Administrative:
    • I spent most of today "welcoming" Jorge Prudencio, the new intern who will join us :) You know, installing the environment and so on. I will introduce him to you tomorrow hopefully.
  • bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
    • Patch ready.
    • ui-review+ by Carrie. I will record a new video tomorrow showing the suggested conference call duration. This is already included in the patch to be reviewed.
    • I could not record the video due to a bug when establishing the second call: add_second_call.png I will check with you during the meeting and if not know, I will create the bug.
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • ui-review+ by Carol.
    • Asked for review from Anthony.
    • Rebased :-)
  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold:
    • Proposal made to Carrie and asked need-info to her regarding the final implementation.
    • Hopefully she agrees since we are following the proposed path ;)
    • Paco is working on the visual part.

pacorampas

  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
    • I'm working on some failures that German said me
  • bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
  • bug 1030623 -
    • It is waiting for 1043318 to land

thills

  • bug 1039643 - Have a patch for review and waiting for that right now.
  • bug 1026692 - Started looking at this and bug 1043133 depends on this so I'm looking at 1043133 right now.

// Part-time people (not required to update this)

Rik

  • PTO

pacorampas

  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
    • I'm working on some failures that German said me
  • bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
  • bug 1030623 -
    • It is waiting for 1043318 to land

thills

  • bug 1039643 - Have a patch for review and waiting for that right now.
  • bug 1026692 - Started looking at this and bug 1043133 depends on this so I'm looking at 1043133 right now.

Rik

  • PTO

Day 9: August 1

drs

  • Admin:
    • I'm meeting with Lawrence (:lmandel) on Tuesday to talk about information that relman can provide us with to help us. Anthony and I have been compiling a list for this, please add to it if you have anything: https://etherpad.mozilla.org/relman-information
    • Went back to talk with Vance about CDMA in NA.
  • Next steps:
    • bug 1047224 - [Dialer] [Keypad] Follow up for 1043318
      • Need to review this for Paco.
    • bug 991573 - Copy improvements in Call Barring service through MMI
      • I need to talk with Gabriele about this.
    • bug 1037066 - [Dialer] Keypad background color changes are delayed
      • Investigated this, I think we're going to have to do a Gaia-side workaround and not use touch listeners, or manually set the "active" state on the keypad.
    • bug 1045820 - Port dialer's SimPicker implementation to GaiaSimPicker
      • Put up a patch, but we're going to change bug 1037868, so this will need a bit more work first before it goes into review.
    • bug 982163 - Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call()
      • Going to check if we can remove this.
  • Done:

Rik

gtorodelvalle

  • Administrative:
    • Sadly I won't be able to join me to the meeting so it would be great, Doug, if you could host it :) Thanks!
      • <drs> Will do! Thanks for letting me know.
  • bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
    • Patch ready.
    • ui-review+ by Carrie. I will record a new video tomorrow showing the suggested conference call duration. This is already included in the patch to be reviewed.
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • ui-review+ by Carol.
    • Asked for review from Anthony.
  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold:
    • Proposal made to Carrie and asked need-info to her regarding the final implementation.
    • Hopefully she agrees since we are following the proposed path ;)

pacorampas

  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
    • I'm working on some failures that German said me
  • bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
  • bug 1030623 -
    • It is waiting for 1043318 to land
  • bug 1047224 - [Dialer] [Keypad] Follow up for 1043318

thills

  • bug 1039643 - Have a patch for review and waiting for that right now.

Day 8: July 31

drs

  • Admin:
    • bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen
      • What happened with this bug was really unfortunate. You can read comment 76 for a summary. I'm meeting with Lawrence on Tuesday to talk about what we can do to prevent this from happening again in the future. I'm going to provide him with all the info that we'd like to have on the regular from relman.
      • <Rik> Not entirely related but https://bugzilla.mozilla.org/show_bug.cgi?id=1021478#c50 is really helpful notice
  • Next steps:
    • bug 991573 - Copy improvements in Call Barring service through MMI
      • Review- for David, I need to talk with Gabriele about this.
    • bug 1037868 - Create gaia-sim-picker component
      • Review- from Kevin. Also needs review from Anthony.
    • bug 1037066 - [Dialer] Keypad background color changes are delayed
      • Going to work on this today.
    • bug 1045820 - Port dialer's SimPicker implementation to GaiaSimPicker
      • This has turned into a port of every app, so it's taking a bit longer than I wanted it to.
  • Done:
    • bug 1021478 - Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
      • Landed on master, then got 1.4+ status, so now I have to uplift it.

Rik

// Better for wiki

  • Looked into how to split the call duration work bug 877971, will open bugs later:
    • Insert duration in call log DB
    • Create new page (could be split in several steps too)
    • Link page to main call log

gtorodelvalle

  • Administrative:
    • Nothing to report.
  • bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
    • Patch ready.
    • ui-review+ by Carrie. I will record a new video tomorrow showing the suggested conference call duration. This is already included in the patch to be reviewed.
  • bug 889737 - [MMI] Unify both sendMMI() and dial() functions:
    • I have been familiarising with this bug since I have been kindly asked to include it in our next sprint.
    • The approach seems to be the one suggested by Anthony at https://bugzilla.mozilla.org/show_bug.cgi?id=1031193#c1
    • <Rik> How can we include in the next sprint since the Gecko work is not done?
    • Yeap, does not make much sense to me either :)
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • ui-review+ by Carol.
    • Asked for review from Anthony.
  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold:
    • Helping Paco to try to get a working patch ASAP :)

thills

  • bug 1039643 - Took help from Rik yesterday on this. Created a workaround for the issues I ran into trying to reuse the mock_fb object. Posted the latest patch for feedback from Rik.

// Part-time people (not required to update this)

pacorampas

  • Absent/no report

Day 7: July 30

drs

  • Admin:
    • bug 1029142 - Call log deletions don't persist after killing the app
      • I think this will become a blocker. If anyone has bandwidth, we should take it. If not, we can take it next sprint.
  • Next steps:
    • bug 991573 - Copy improvements in Call Barring service through MMI
      • Need to review this for David.
    • bug 1037868 - Create gaia-sim-picker component
      • I put this up and got feedback+ from Kevin. I need to move over the unit tests, and then we'll be good to go into real review for this.
    • bug 1037066 - [Dialer] Keypad background color changes are delayed
      • Going to work on this today.
    • bug 1045820 - Port dialer's SimPicker implementation to GaiaSimPicker
      • I have a WIP, going to try to finish this today.
  • Done:
    • bug 1021478 - Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
      • Posted another revision, got review+ from Anthony, need to land it.

Rik

  • Still hasn't started on call duration work, too many interruptions yesterday and today :(
  • Discussed bug 959011 with Julien
  • Helped Carrie run the prototype
  • Helped thills with tests
  • Emailed release management to get bug 1018283 to land
  • bug 1038714 is no longer a 2.1 feature nor something we want to fix
  • Tried to reproduce bug 1039610, no idea why it's working now
  • I'm not sure yet if bug 1043318 is a Gaia or Gecko bug so asked help
  • Thinking about 2.2, I'd like to split Dialer and Contacts so we need some investigation first, opened bug 1046090 for that and put that in the next sprint.
  • Reviews

gtorodelvalle

  • Administrative:
    • <drs> I put the meeting notes and minutes for today on the wiki. Please try to remember next time. I think you were in a hurry and had a lot to do, so it's ok.
    • Yeah, I copied them before leaving to do it later and when I was about to do it yesterday night I noticed you had already done it, so thank you ;)
  • bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
    • Patch ready.
    • Demo at http://youtu.be/iF1K2DovRV8 I will include it on our Demo section once some issues I asked Carrie about the time to be shown are clarified.
    • Asked for revision from Anthony until Carol and Carrie reply to my ui-review request.
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • ui-review+ by Carol.
    • Asked for review from Anthony.
  • bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen
    • <drs> We need to figure out what to do with this now that it was backed out of 2.0. I've had a lot of experience with the problem you're facing now. Let's chat tomorrow (Tuesday).
    • New patch included applying Doug's suggestion.
    • Asked for approval for v2.0 as agreed with Anthony.
  • bug 967440 - Remove some reflows on the keypad:
    • Provided feedback to Anthony as requested.
  • bug 1030811 - CallScreen app debugging not working:
    • Provided feedback to Paul Rouget about the issue.

pacorampas

  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
    • Working on visual part
    • Added the on hold button
    • I started with the logic
    • Splitted in two bugs
  • bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
  • bug 1030623 -
    • It is waiting for 1043318 to land

thills

  • bug 1039643 - Still working on this and taking some help from Anthony where I am stuck.

// Part-time people (not required to update this)

Day 6: July 29

drs

  • Admin:
    • Not enough demos.
    • Concerned about schedule/progress so far.
  • Next steps:
    • bug 1037868 - Create gaia-sim-picker component
      • I put up an example case for Kevin and he found the problem in my code, so I'm going to continue on this.
    • bug 1037066 - [Dialer] Keypad background color changes are delayed
      • Will work on this if I have time.
  • Done:
    • bug 1021478 - Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
      • I put up a second revision of my patch for Anthony to review.
    • bug 911055 - [zffos1.1][P3][Dailer]DuT doesn allow to dial a <<pause>>
      • Review- again for David.
    • bug 967440 - Remove some reflows on the keypad
      • Review- for Anthony. This is a great patch but it's so big that it was bound to have problems.

Rik

gtorodelvalle

  • Administrative:
    • Nothing to report
  • bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
    • Patch ready.
    • Demo at http://youtu.be/iF1K2DovRV8 I will include it on our Demo section once some issues I asked Carrie about the time to be shown are clarified.
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • ui-review+ by Carol.
    • Asked review from Anthony.
  • bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen
    • <drs> We need to figure out what to do with this now that it was backed out of 2.0. I've had a lot of experience with the problem you're facing now. Let's chat tomorrow (Tuesday).
    • Wow! I was (wrongly) sure that no strings were modified. Next time I will check it no matter how sure I am :(
    • <drs> It happens. There's a saying that if you never miss a flight, you're spending too long at the airport. But if you're missing many, you're not getting there early enough.

pacorampas

  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
    • Working on visual part
    • Added the on hold button
    • I started with the logic
    • Splitted in two bags
  • bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
    • we are testing differents hits sate
  • bug 1043318 - [Dialer] [Keypad] On suggestion item when the text goes outside the edge, you can drag the upper part and move the whole screen.
    • I have asked Rik to improve the code of suggestion. (As a comment on this bug)
    • It is ready to land. When this bug will land, the 1030623 bug will land also

thills

  • bug 1039643 - I took some feedback from Rik on this and am re-working things a bit to focus more towards the output validation than validation of function calls via spies.

Day 5: July 28

drs

  • Admin:
    • Nothing new.
  • Next steps:
    • bug 1037066 - [Dialer] Keypad background color changes are delayed
      • Next bug to work on, and my last assigned for this sprint. I have a WIP patch posted already.
      • <Rik> I thought the patch was just to showcase an APZC bug. Do you think it will be a Gaia fix?
      • It's not a bug with APZC I don't think, just a limitation. Even if it's an APZC bug, it'll be a lot faster to fix in Gaia for now. I'll check with kats and Botond though.
    • bug 1037868 - Create gaia-sim-picker component
      • :kgrandon wants a reduced test case for a potential platform problem I'm facing.
  • Done:
    • bug 1039553 - [Dialer][Call Screen] It's not possible to start a second call
      • Resolved WFM.
    • bug 1021478 - Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
      • I put up a patch for Anthony to review.
    • bug 911055 - [zffos1.1][P3][Dailer]DuT doesn allow to dial a <<pause>>
      • Review- for David. This will probably need some new unit tests.

Rik

  • Moved my dogfooding phone to Flame.
  • bug 967440 is ready-ish. I'm checking that the tests pass, testing on the device again before submitting it
  • Will work on bug 877971 after my needinfos/feedbacks are done.

gtorodelvalle

  • Administrative:
    • Nothing to report
  • bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
    • Retook this bug.
    • Filed a new one I found (see next).
    • Have a working patch.
    • Trying to find out why if there is a conference call among 3 parties, if 1 of them leaves the conference when the participant list overlay is shown, the other one is "magically" removed from the list.
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • ui-review+ by Carol.
    • Asked review from Anthony.

thills

  • bug 1039643 - Working on this still. Put a version for feedback to make sure I'm going in right direction with this.

// Part-time people (not required to update this)

pacorampas

  • Absent/no report

Day 4: July 25

drs

  • Admin:
    • Tamara and I couldn't get our Wasabi devices connected to NA carriers, so I emailed Wesley to ask for help based on the information that the carriers provided.
  • Next steps:
    • bug 1037066 - [Dialer] Keypad background color changes are delayed
      • Next bug to work on, and my last assigned for this sprint. I have a WIP patch posted already.
    • bug 1021478 - Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
      • We now have a correct solution according to Carrie, so I'm going to clean this up and take it into review.
    • bug 911055 - [zffos1.1][P3][Dailer]DuT doesn allow to dial a <<pause>>
      • Need to review this for David. I took a cursory look at this and it looks great.
  • Done:
    • bug 1039553 - [Dialer][Call Screen] It's not possible to start a second call
      • Can't repro on Flame / master, asked for qawanted.
    • bug 1037868 - Create gaia-sim-picker component
      • I've posted a WIP patch where I'm blocked on what :kgrandon believes may be a platform issue.

Rik

  • Still into bug 967440, working on the unit tests. A lot of tests for FontSizeManager are missing :(

gtorodelvalle

  • Administrative:
    • Nothing to report
  • bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
    • Retook this bug.
    • Filed a new one I found (see next).
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • Need-infoed Carol asking for visual specs.
    • Working on this bug. The main problem I found is that |APP=callscreen make install-gaia && adb shell stop b2g && adb shell start b2g| no longer work and I have to run |make install| (which takes ages) instead :( Hopefully bug 1000049 will land soon :)
    • <drs> I tried this and it worked fine for me. I tried looking into a way to run the callscreen as its own app but it seems pretty heavily embedded in the system app (see dialer_agent.js).

thills

Wasabi device - Sprint says they cannot take a device that is not "made for sprint". They scanned the MEID and IMEI and said that the only way to get it to work is to have it added to their database. Verizon has a website where you can figure out whether it will work by adding IMEI and MEID. I entered both of these and it says that the device will not work with Verizon.

  • bug 1039643 - Still in progress. Not ready for review yet.

pacorampas

  • Absent/no report

Day 3: July 24

drs

  • Admin:
    • I went to the stores of a couple of carriers nearby to try to get the Wasabi CDMA device connected to a network here and it's not looking good. I need to contact Wesley but I don't think this is actually possible.
  • Next steps:
    • bug 1037868 - Create gaia-sim-picker component
    • bug 1039553 - [Dialer][Call Screen] It's not possible to start a second call
      • Will do this in parallel with bug 1037868, haven't started yet.
      • <Rik> That sounds higher priority to me, we should discuss
      • It is, I'm going to do it today.
  • Done:

Rik

  • Deep into bug 967440, remove reflows. I'm seeing the end of it but not there yet. I hope to submit a patch tonight.

gtorodelvalle

  • Administrative:
    • I WON'T BE ABLE TO JOIN THE MEETING July 24 :-(
  • bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
    • Approval granted.
    • New rebasing needed and TBPL reporting only errors not related to this patch.
    • Asked Ryan about how to proceed (if I should land it in v2.0) or there are sheriffs for that. Waiting for his reply ;)
    • Authorised by Ryan to merge the patch in v2.0, aaand merged! ;)
  • bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
    • Retook this bug.
    • Filed a new one I found (see next).
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • Need-infoed Carol asking for visual specs.

thills

  • bug 1039643 - Still working on this. Hope to have something for feedback in next day or so.
  • bug 998147 - drs has landed the gaia portion for me.

pacorampas

  • Absent/no report

Day 2: July 23

drs

  • Admin:
    • I have a Wasabi device now (our only CDMA one) and I believe Tamara does too. I've been doing some research on it and I'm going to try to get it on a network.
  • Next steps:
    • bug 1035183 - Matching numbers screen results is not properly localized for 10+ matches
      • Backed out of 2.0 and waiting for bug 1018494 to be uplifted before re-uplifting it.
    • bug 1037868 - Create gaia-sim-picker component
      • Working on this now.
    • bug 1039553 - [Dialer][Call Screen] It's not possible to start a second call
      • Will do this in parallel with bug 1037868, haven't started yet.
  • Done:
    • Researched CDMA a bit.
    • bug 998147 - [Dialer] A Missed Call notification is given when chosing to hang up on an incoming call
      • Review+ for Tamara
    • bug 1006592 - While sending USSD code, last dialed number by user appears in dialer app
      • Review- for Gabriele

Rik

  • Reviews
  • UX mock up for the Call log duration
  • Opened Facebook follow up for suggestion bar bug 1042562 and migrate call log insertion to data store bug 1042576. I think the datastore one will have a great impact.

gtorodelvalle

  • Administrative:
    • As a suggestion and although I would say it is more Doug's than mine, when possible I think we should probably try to run IRC-reviews in parallel with using Github or Bugzilla since it speeds the landing up a lot :) At least to fully understand the requests of the reviewer (and that's mainly on me :) ).
      • <drs> I think our current system is fine. I generally ask for IRC review when I want to get something landed quickly or I feel bad about it and don't want to waste more of someone's time. Remember that IRC reviews are sync so it's more costly for the reviewer.
      • In fact, I would say it is more costly for the submitter since it is the reviewer the one who decides when to run it :p But I am fine with it ;) Sometimes I find myself wanting to ask something to the reviewer and I have to leave my comments in Github and wait the next round :)
      • <drs> Yeah, in that case it's fine to ask on IRC, but doing a full IRC review as much as possible seems like overkill to me.
      • Totally agreed ;)
    • (just informative) Paco's patches with third party apps failing tests landed in master.
  • bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
    • Mari Ángeles has asked Stephany to try to push it forward ;)
  • bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size:
    • Currently including Doug's comments in the patch.
    • Implemented the new version with no getScenario() as suggested by Doug.
    • Asked revision to Doug about the new version. New revision asked ;)
    • r+ by Doug. Waiting for the tests to pass to land it in master.
  • bug 1024506 - While call is "connecting", "Add other call", "Keypad" and "microphone" buttons should be disabled:
    • Implemented Anthony's suggestions.
    • Asked for a new revision.

pacorampas

  • bug 1023246 - [Flame][v1.4][Gaia::Dialer]The contact’s photo is shown incompletely in the call log edit screen.
    • Working on this
    • Testing number and time of reflows
  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
    • Working on visual part
    • I am testing with pau a new hit state

thills

  • bug 1039643 - Still working on this.
  • bug 998147 - The gecko portion is landed. review is done for gaia portion and ready to go.
    • <drs> Do you need this landed?

Day 1: July 22

drs

  • Admin:
    • Nothing new.
  • Next steps:
    • bug 1035183 - Matching numbers screen results is not properly localized for 10+ matches
      • Backed out of 2.0 and waiting for bug 1018494 to be uplifted before re-uplifting it.
    • bug 1037868 - Create gaia-sim-picker component
      • Working on this now.
    • bug 1039553 - [Dialer][Call Screen] It's not possible to start a second call
      • Will do this in parallel with bug 1037868, haven't started yet.
  • Done:
    • bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size
      • Reviewed for Germán, review+
    • bug 1021478 - [1.4] Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
      • Figured out some test failures for Wei.

Rik

  • admin : I added a Demo section on our sprint page, I intend to fill it as I go
  • Sprint planning
  • Reviews

gtorodelvalle

  • Administrative:
    • Paco's patch for "bug 1030623 - [Dialer] No space between text and border when Contact with long name and number matching hits" can be landed since the tests failing has nothing to do with the proposed patch.
    • Paco's patch for bug 1033937 - "[Calllog] Tap on Withheld number in call log, item highlighted, but stay highlighted when finger released" can be landed since the tests failing has nothing to do with the proposed patch.
    • Should we directly merged them or do you prefer us to cross check it with you? You know I get scared when I see Travis in red :p
  • bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
    • Mari Ángeles has asked Stephany to try to push it forward ;)
  • bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size:
    • Currently including Doug's comments in the patch.
    • Implemented the new version with no getScenario() as suggested by Doug.
    • Asked revision to Doug about the new version. New revision asked ;)
  • bug 1030623 - [Dialer] No space between text and border when Contact with long name and number matching hits:
    • Solving some issues with the tests. In fact, not related to the proposed patch.
  • bug 1024506 - While call is "connecting", "Add other call", "Keypad" and "microphone" buttons should be disabled:
    • Implemented Anthony's suggestions.

pacorampas

  • bug 1023246 - [Flame][v1.4][Gaia::Dialer]The contact’s photo is shown incompletely in the call log edit screen.
    • Working on this

thills

  • bug 1039643 - Started looking on this to add the unit tests for the contacts.js
  • bug 998147 - Spent some time on trying to figure out how to merge this with the previous bug I was working on since the changes are in the same area. Will probably just create a new branch for this.

Retrospective

Retrospective Etherpad

Things we did well

  • <drs> The team is starting to feel like a unified force instead of a loosely related group.
  • <drs> The daily standup seems to still really be helping and we've ironed out a bunch of details (though see below).
  • <drs> We got our blockers down to 0 and were the first comms subteam to do so.

Things we could do better

  • <drs> Switching the standup host every day is cumbersome and doesn't allow people to get better at it.
  • <drs> Sprint planning was really weak, I should have prepared better.
    • <drs> Between blockers and reorganization, I had very little time to spend figuring out what to do next. I'm happy we did get started on the sheet navigation prototype, though. This won't be a problem this sprint.
    • <Rik> I think dialer-most-wanted will help a lot.
  • <drs> We are not doing a good job keeping everyone involved in long-term projects. In particular, we're not getting enough feedback or ideas. Now that we've cleared our blockers and we're not really under any serious pressure, we should be able to step back and think about these things.
    • <drs> Suggestions? What would get you more involved?
  • <gtorodelvalle> In this sprint we at Telefónica had many distractions from what was previously agreed as work to be done during the current sprint planning (IOT and certification guys' requests).

Action items

  • <drs> Switch standup host to weekly rotation. (thills' idea)
  • <drs> I think we should start doing demos of significant features/bug fixes.
  • <drs> I also think we should start setting time aside to improve our technical documentation. This is all we have right now: https://wiki.mozilla.org/FirefoxOS/Comms/Dialer#Feature.2FSubcomponent_Documentation
    • <gsvelto> We should also document our code better, our in-code documentation currently leaves a lot to be desired (which is an euphemism for complete absence of comments in the code). As a side note we could explicitly start asking for better in-code documentation in reviews.
      • <gsvelto> Enforce documenting stuff that you touch.
  • <gtorodelvalle> We need a way to proceed in the presence of not previously considered bugs, mainly coming from IOT and certification guys at Telefónica. Probably raising the issue when they pop up and consider any needed rescheduling for the sprint.
    • <drs> Can we talk about these as they come up? At the daily standup.
    • <gtorodelvalle> Absolutely ;)

Demos

Retrieved from "https://wiki.allizom.org/index.php?title=Firefox_OS/Comms/Dialer/Sprint/v2.1-S1&oldid=1002216"