Confirmed users
26
edits
AMO/history: Difference between revisions
Wikify links
(First attempt) |
(Wikify links) |
||
| Line 10: | Line 10: | ||
It was reported that the signing of the [https://bugzilla.mozilla.org/show_bug.cgi?id=1152457 400 add-ons] caused crashes of Firefox versions 28 and below (and derivatives) when doing a version update check. We thus decided to revert the signing of those add-ons until we find a fix for that issue. | It was reported that the signing of the [https://bugzilla.mozilla.org/show_bug.cgi?id=1152457 400 add-ons] caused crashes of Firefox versions 28 and below (and derivatives) when doing a version update check. We thus decided to revert the signing of those add-ons until we find a fix for that issue. | ||
* https://bugzilla.mozilla.org/show_bug.cgi?id=1158467 Signed extensions on AMO have invalid signatures | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1158467 1158467] Signed extensions on AMO have invalid signatures | ||
** create PR https://github.com/mozilla/olympia/pull/526 to revert auto signing | ** create PR [https://github.com/mozilla/olympia/pull/526 #526] to revert auto signing | ||
* cherry-pick and tag https://github.com/mozilla/olympia/compare/2015.04.24...2015.04.25 | * cherry-pick and tag [https://github.com/mozilla/olympia/compare/2015.04.24...2015.04.25 2015.04.25] | ||
** https://github.com/mozilla/olympia/commit/0882d3ab830c6c07b698e4eb850c464af8e088d8 Revert auto signing (bug 1158467) | ** [https://github.com/mozilla/olympia/commit/0882d3ab830c6c07b698e4eb850c464af8e088d8 0882d3a] Revert auto signing (bug 1158467) | ||
| Line 22: | Line 22: | ||
We thus decided to push to production, and run the script on a chosen list of [https://bugzilla.mozilla.org/show_bug.cgi?id=1152457 400 add-ons]. | We thus decided to push to production, and run the script on a chosen list of [https://bugzilla.mozilla.org/show_bug.cgi?id=1152457 400 add-ons]. | ||
* https://bugzilla.mozilla.org/show_bug.cgi?id=1070227 Write a script to sign all existing add-ons (send email to addon owners) | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1070227 1070227] Write a script to sign all existing add-ons (send email to addon owners) | ||
** create PR https://github.com/mozilla/olympia/pull/525 | ** create PR [https://github.com/mozilla/olympia/pull/525 #525] | ||
* cherry-pick and tag https://github.com/mozilla/olympia/compare/2015.04.22...2015.04.24 | * cherry-pick and tag [https://github.com/mozilla/olympia/compare/2015.04.22...2015.04.24 2015.04.24] | ||
** https://github.com/mozilla/olympia/commit/a9638bb431ac9fd1b99edf5f3895a8c7cd9d1e82 Send an email to addon owners after their addon got auto signed (bug 1070227) | ** [https://github.com/mozilla/olympia/commit/a9638bb431ac9fd1b99edf5f3895a8c7cd9d1e82 a9638bb] Send an email to addon owners after their addon got auto signed (bug 1070227) | ||
| Line 33: | Line 33: | ||
The tag 2015.04.22 that was planned to be pushed to production was not, because we decided we needed to send mails to the add-on owners. | The tag 2015.04.22 that was planned to be pushed to production was not, because we decided we needed to send mails to the add-on owners. | ||
* https://bugzilla.mozilla.org/show_bug.cgi?id=1156333 Don't review a file if its signing failed | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1156333 1156333] Don't review a file if its signing failed | ||
** create PR https://github.com/mozilla/olympia/pull/524 | ** create PR [https://github.com/mozilla/olympia/pull/524 #524] | ||
/!\ cannot be cherry-picked on the tag in production, as it touches codes related to unlisted addons, which isn't in production yet. | /!\ cannot be cherry-picked on the tag in production, as it touches codes related to unlisted addons, which isn't in production yet. | ||
| Line 47: | Line 47: | ||
We tagged for a push to stage, and planned a push to production on thursday 2015-04-23. | We tagged for a push to stage, and planned a push to production on thursday 2015-04-23. | ||
* reviewed https://github.com/mozilla/olympia/pull/515 | * reviewed [https://github.com/mozilla/olympia/pull/515 #515] | ||
* https://bugzilla.mozilla.org/show_bug.cgi?id=1148447 Adjust flow to be steps 1 -> 2 -> 3ish -> 7 | * [https://bugzilla.mozilla.org/show_bug.cgi?id=1148447 1148447] Adjust flow to be steps 1 -> 2 -> 3ish -> 7 | ||
** update PR https://github.com/mozilla/olympia/pull/505 following reviews | ** update PR [https://github.com/mozilla/olympia/pull/505 #505] following reviews | ||
* create bug https://bugzilla.mozilla.org/show_bug.cgi?id=1157215 add a waffle flag for the automatic validation | * create bug [https://bugzilla.mozilla.org/show_bug.cgi?id=1157215 1157215] add a waffle flag for the automatic validation | ||
** create PR https://github.com/mozilla/olympia/pull/521 | ** create PR [https://github.com/mozilla/olympia/pull/521 #521] | ||
* committed https://github.com/mozilla/olympia/commit/343dfec0f9ccebc28f004fe90b0ca62f235518cf Add lib.crypto.tasks to the CELERY_IMPORTS: celery workers on -dev and stage were failing because this was missing | * committed [https://github.com/mozilla/olympia/commit/343dfec0f9ccebc28f004fe90b0ca62f235518cf 343dfec] Add lib.crypto.tasks to the CELERY_IMPORTS: celery workers on -dev and stage were failing because this was missing | ||
* create bug https://bugzilla.mozilla.org/show_bug.cgi?id=1157444 Only bulk sign versions that are compatible with recent versions of Firefox | * create bug [https://bugzilla.mozilla.org/show_bug.cgi?id=1157444 1157444] Only bulk sign versions that are compatible with recent versions of Firefox | ||
** create PR https://github.com/mozilla/olympia/pull/523 | ** create PR [https://github.com/mozilla/olympia/pull/523 #523] | ||
* cherry-pick and tag https://github.com/mozilla/olympia/compare/2015.04.21...2015.04.22 | * cherry-pick and tag [https://github.com/mozilla/olympia/compare/2015.04.21...2015.04.22 2015.04.22] | ||
** https://github.com/mozilla/olympia/commit/343dfec0f9ccebc28f004fe90b0ca62f235518cf | ** [https://github.com/mozilla/olympia/commit/343dfec0f9ccebc28f004fe90b0ca62f235518cf 343dfec] Add lib.crypto.tasks to the CELERY_IMPORTS | ||
** https://github.com/mozilla/olympia/commit/ed854c15883a3af2bbb49f73a2d91c63c0456554 Only bulk sign recent firefox files (bug 1157444) | ** [https://github.com/mozilla/olympia/commit/ed854c15883a3af2bbb49f73a2d91c63c0456554 ed854c1] Only bulk sign recent firefox files (bug 1157444) | ||
* sign_addons bulk signing script tested on: | * sign_addons bulk signing script tested on: | ||
** https://addons.allizom.org/fr/firefox/addon/flash-video-downloader/versions/ | ** [https://addons.allizom.org/fr/firefox/addon/flash-video-downloader/versions/ flash-video-downloader]: correctly signed all versions above ff10 that were reviewed | ||
** https://addons.allizom.org/fr/thunderbird/addon/lookout/versions/ | ** [https://addons.allizom.org/fr/thunderbird/addon/lookout/versions/ lookout]: correctly didn't sign any version, it's compatible thunderbird and seamonkey only | ||