Confirmed users
14
edits
Sheriffing/How:To:Comm-central: Difference between revisions
Sheriffing/How:To:Comm-central (view source)
Revision as of 22:02, 18 September 2015
, 18 September 2015Add tree status etherpad
(Reordered) |
(Add tree status etherpad) |
||
| Line 13: | Line 13: | ||
# Add the intermittent-failure keyword. '''This is important, it will not show up in suggestions if you do not have this.''' | # Add the intermittent-failure keyword. '''This is important, it will not show up in suggestions if you do not have this.''' | ||
# Copy sufficient details from the bug to diagnose the results. Use the log viewer, it actually works better than TBPL's. | # Copy sufficient details from the bug to diagnose the results. Use the log viewer, it actually works better than TBPL's. | ||
# Make sure to add the new bug to [https://thunderbird.etherpad.mozilla.org/tree-status the tree status etherpad]. | |||
Note: Newly-filed bugs do not show up in the test failure suggestions box immediately. | Note: Newly-filed bugs do not show up in the test failure suggestions box immediately. | ||
| Line 18: | Line 19: | ||
== How to give a+ when APPROVAL NEEDED == | == How to give a+ when APPROVAL NEEDED == | ||
# Deny approval if there is not at least 1 "successful" debug and opt version of tests on the latest checkin. This isn't a "everything before must go green" but "the previous checkin did not break everybody" check. | # Deny approval if there is not at least 1 "successful" debug and opt version of tests on the latest checkin. This isn't a "everything before must go green" but "the previous checkin did not break everybody" check. | ||
# Triage all problems. Get the unstarred failure count down to 0. | # Triage all problems. Get the unstarred failure count down to 0, or at least check the [https://thunderbird.etherpad.mozilla.org/tree-status the tree status etherpad] to ensure all failures are known and filed. | ||
# Do we have builds on all platforms? If no, and the patch is not a bustage fix, deny approval. | # Do we have builds on all platforms? If no, and the patch is not a bustage fix, deny approval. | ||
# Are the test failure counts going up? If there are too many reports, you can check the number of tests that failed by looking in the lower-left panel: it will say something like '''mozmill virtualenv''' 1090/<span style="color:red">7</span>. If that count goes up, there are probably new mozilla-central failures to be triaged. | # Are the test failure counts going up? If there are too many reports, you can check the number of tests that failed by looking in the lower-left panel: it will say something like '''mozmill virtualenv''' 1090/<span style="color:red">7</span>. If that count goes up, there are probably new mozilla-central failures to be triaged. | ||