Confirmed users
586
edits
Platform/GFX/Quantum Render: Difference between revisions
→On reftests: Add ordering of badness
(→Merging from mozilla-central: Add a note about new reftests) |
(→On reftests: Add ordering of badness) |
||
| Line 53: | Line 53: | ||
* File a bug for that reftest, and mark it as blocking {{bug|1322815}} (webrender-reftests). | * File a bug for that reftest, and mark it as blocking {{bug|1322815}} (webrender-reftests). | ||
* Update the Google sheet with the bug number and your name. | * Update the Google sheet with the bug number and your name. | ||
* Work on the fix. The best way to do this is to remove the fails-if or skip-if annotation in your local checkout and run the reftest using | * Work on the fix. The best way to do this is to remove the fails-if or skip-if annotation in your local checkout and run the reftest using <tt>mach reftest</tt>. Debug and fix as needed. Note that you can likely work on the bug on Windows/OS X locally, but we only run the tests on Linux in automation. So for best results, prefer working on Linux locally when possible. | ||
* If you need to do try pushes, use syntax | * If you need to do try pushes, use syntax <tt>try: -b do -p linux64-qr -u all[linux64-qr] -t none</tt>. You should do at least one try push after writing your fix to verify it works in automation, as well as to identify any other tests that are fixed by your patch. Make sure to update the annotations for all newly-passing tests as part of your final commit. Try not to introduce regressions, although breaking a small number of tests to make a larger number pass might be acceptable. | ||
* Land your fix with pre- or post-review as appropriate. | * Land your fix with pre- or post-review as appropriate. | ||
In general, tests that are marked <tt>skip-if(webrender)</tt> are the worst, because they cause the reftest run to crash or hang and prevent other reftests from running. Slightly better than this are the <tt>random-if(webrender)</tt> tests - these can intermittently fail or pass, and so mean that there is a race condition somewhere. Slighly better than this are the <tt>fail-if(webrender)</tt> tests - these fail, but at least they do so consistently. Best of all are the ones with no webrender annotation at all, which means they behave the same as a Gecko build would. | |||
== Committing changes == | == Committing changes == | ||