TPE-Layout/2017-01-17

Weekly Announcement

• Layout Standup
  • Daily to-dos/status recorder and tracker to help you back trace in past weeks or months.
  • Initial coverage: WFH / People who is unable to attend daily standup. Encourage for everybody.

Weekly Sharing

• Rust
  • auto-dereferencing rules.

Weekly Status

Cameron McCormack

Stylo

• bug 1322568 - stylo: disable style context tree verifications
  • r+ | land
• bug 1331294 - stylo: value from getComputedStyle is not updated after selector matching changes
  • r-
• bug 1331326 - stylo: shuffle around some nsIDocument fields to avoid rust-bindgen problems
  • r?

Other

• bug 1330236 - SVGTextContentElement::GetNumberOfChars is super inefficient due to sync reflows
  • r+
• bug 1330843 - Allow JS to create NAC pseudo-elements.
  • WIP

Stylo reviews

• bug 1330060 - stylo: Gecko_GetServoDeclarationBlock does more work than it needs to
• bug 1329854 - stylo: Track newly-appended subtrees when frame construction bails out due to lack of container frame
• bug 1297322 - expose Gecko prefs to Servo so that they can influence CSS parsing
• bug 1330824 - stylo: several style system tests fatally asserts with "Assertion failure: display->mAnimationNameCount > 0 (first item must be explicit)"
• bug 1331316 - Stylo: implement 1-arg CSS.supports()
• bug 1331213 - stylo: Parse and evaluate media queries using nsMediaFeatures

Other reviews

• bug 1325038 - Hit NS_ASSERTION in PreEffectsVisualOverflowCollector::GetPreEffectsVisualOverflowRect
• bug 1330190 - SEGV near null in [@ Get]
• bug 1331296 - Remove support for -moz-calc()

CJ Ku

• bug 1325865 - SVG: Percentage length values in mask elements are calculated incorrectly
  • land
• bug 1325038 - Hit NS_ASSERTION in PreEffectsVisualOverflowCollector::GetPreEffectsVisualOverflowRect
  • land
• bug 872483 - reftest text-svgglyphs/svg-glyph-mask.svg fails on all platforms
  • r?
• bug 537623 - mask/clip-path/filter attribute on <use> element uses wrong coordinate space
  • WIP

Farmer Tseng

• bug 1329881 - [Mortar] Implement converting PDF to EMF and printing for Windows
  • file
• Prepare/discuss present slide
  • https://docs.google.com/presentation/d/1AeKl3IUhI4Syp_g9KAY7r4J-BRgdFe7I4oa8PfScS7I/edit#slide=id.g1be6e74a05_9_127
• Provide/discuss proposals for Mortar printing
  • 1. PDFium generate Bitmap binary in Plugin Binary Process, send to Chrome process for printing
  • 2. PDFium generate EMF file in Plugin Binary Process, send to Chrome process for printing
  • 3. Create a sandboxed process to load PDFuim.dll, pass file handler from chrome process to dll process, save EMF file, then print EMF in chrome process.

Jeremy Chen

CSS Text Module Level 3

• bug 1316482 - Whitespace around the segment break should be removed before segment break transformation
  • Backout due to test failures on Win7 debug
  • re-land with skipping tests on Win7 debug for now
  • keep monitoring the intermittent bug 1300355
• bug 1056516 - presence of explicit soft-hyphen in a word should override automatic hyphenation
  • OOAD | wip

Other

• bug 1326189 - [css-ui] caret-color on visited links
  • r?

Review

• bug 1311244 - Implement the rendering of basic shape circle() for CSS shape-outside
• bug 1330630 - Intermittent 315920-26.html == http://10.0.2.2:8854/tests/layout/reftests/bugs/315920-26-ref.html | image comparison, max difference: 229, number of differing pixels: 46

Shing Lyu

Stylo

• Make Servo performance test run on Stylo
• Add custom timing test in Servo performance test for Stylo
• Re-running reftest

Servo

• Implemented display:inline-flex

Evangelism

• Coordinate NTU school project

Tingyu Lin

shape-outside

• bug 1311244 - Implement the rendering of basic shape circle() for CSS shape-outside
  • land
• bug 1330630 - Intermittent 315920-26.html == http://10.0.2.2:8854/tests/layout/reftests/bugs/315920-26-ref.html | image comparison, max difference: 229, number of differing pixels: 46
  • land

Tommy Kuo

Layout

• bug 1229979 - The shadow of decoration line is draw in a different color when the shadow blur is not zero
  • OOAD
• bug 1329381 - Computed value of background-repeat should be a list, each item consisting of: two keywords, one per dimension.
  • r? | WONTFIX
• bug 1229982 - Shadow of decoration is not drawn when shadow blur is applied if text is higher than the baseline
  • debug

BMO

• bug 1330884 - Centralize #bugzilla-body and #footer
  • file
• bug 1331302 - Restrict the max-width of the textarea of "add comment".
  • file
• bug 1331305 - Auto resize the height of textarea of "add comment"
  • file

Presentation API

• bug 1329902 - [Presentation WebAPI] fix device changed/removed event in AndroidCastDeviceProvider
  • review

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics