TPE-Layout/2017-08-15

Weekly Announcement

• Post 57 Work Planning
  • 2017Q4~2018H1 Planning
• Layout bug triage
  • Triage Dashboard
  • Collaboration model, e.g, Core::Tabel, Core::SVG, etc.

Weekly Sharing

• Astley Chen
  • More Rust Code?!

Weekly Status

Astley Chen

• bug 1388216 RESOLVED::FIXED stylo: Rendering of afr.com differs between stylo enabled and disabled nightly
  • Bug 1388216 - triaged and waiting for assigment.
• bug 1389553 NEW:: Crash in gfxTextRun::MeasureText
  • Bug 1389553 - triaged and monitoring.
• bug 1149357 NEW:: Not setting a width and height on srcset image causes incorrect width for shrink-wrapping ancestor
  • Bug 1149357 - triaged and in radar.

Boris Chiou

• bug 1374233 RESOLVED::FIXED stylo: Clamp negative interpolated values for non-negative properties while using negative timing functions
  • Landed bug 1374233 - stylo: Clamp negative interpolated values for non-negative properties while using negative timing functions
• bug 1302946 RESOLVED::FIXED Stylo: Implement CSS transitions
  • Closed bug 1302946 - Stylo: Implement CSS transitions
• bug 1292283 RESOLVED::FIXED stylo: Enable test_transitions_per_property.html
  • Landed bug 1292283 - stylo: Enable test_transitions_per_property.html
• bug 1387948 RESOLVED::FIXED stylo: Interpolation of font-weight is not correct in test_transitions_per_property.html
  • Fixed bug 1387948 - stylo: Interpolation of font-weight is not correct in test_transitions_per_property.html
  • Landed bug 1387948 - stylo: Interpolation of font-weight is not correct in test_transitions_per_property.html
• bug 1362896 ASSIGNED:: stylo: Implement compute_distance for TransformList
  • Wrote patches for bug 1362896 - stylo: Implement compute_distance for TransformList
  • Wrote some test cases for bug 1362896 - stylo: Implement compute_distance for TransformList
• bug 1389429 NEW:: stylo: Divided by zero on non-normalizable direction vector of rotate3d transform function
  • Filed bug 1389429 - stylo: Divided by zero on non-normalizable direction vector of rotate3d transform function
• bug 1388216 RESOLVED::FIXED stylo: Rendering of afr.com differs between stylo enabled and disabled nightly
  • Fixed bug 1388216 - stylo: Rendering of afr.com differs between stylo enabled and disabled nightly
• bug 1389023 ASSIGNED:: stylo: The interpolation of perspective transform is not correct
  • Filed bug 1389023 - stylo: The interpolation of perspective transform is not correct

Cameron McCormack

• Reviewed https://github.com/servo/servo/pull/17973
• Reviewed https://github.com/servo/servo/pull/17992
• Reviewed https://github.com/servo/servo/pull/17999
• Submitted https://github.com/servo/servo/pull/18017
• Submitted https://github.com/servo/servo/pull/18037
• bug 1388234 RESOLVED::FIXED stylo: Assertion failure: !StylistNeedsUpdate()
  • Reviewed bug 1388234
• bug 1388877 RESOLVED::FIXED stylo: Some failing first-line reftests
  • Reviewed bug 1388877
  • Reviewed bug 1388877
• bug 1388943 RESOLVED::FIXED stylo: logical border properties don't force non-native appearance
  • Reviewed bug 1388943
• bug 1370508 NEW:: stylo: generic XML documents do not use stylo
  • Reviewed bug 1370508
• bug 1382925 RESOLVED::FIXED stylo: Keep the UA parts of the stylist across changes to document sheets
  • Landed bug 1382925
• bug 1366163 RESOLVED::FIXED stylo: rendering of <video controls> and <audio controls> is wrong
  • Reviewed bug 1366163
• bug 1385656 RESOLVED::FIXED stylo: RecoverLetterFrames doesn't play nicely with ::first-line
  • Reviewed bug 1385656
• bug 1388626 RESOLVED::FIXED stylo: implement dynamic restyling for ::-moz-xul-anonymous-block anon boxes
  • Reviewed bug 1388626
• bug 1388113 Invalid bug or security bug
  • Uploaded patch for bug 1388113
• bug 1387983 RESOLVED::FIXED Test case to ensure data:stylesheet to be considered same origin
  • Reviewed bug 1387983
• bug 1389153 RESOLVED::FIXED Stylo: Disable more shadow DOM tests
  • Reviewed bug 1389153
• bug 1388941 RESOLVED::FIXED stylo: min font size doesn't work within ruby
  • Reviewed bug 1388941
• bug 1388193 NEW:: Consider allowing the '-moz-context-properties' property to be used by all WebExtension
  • Respond to bug 1388193 needinfo
• bug 1389154 NEW:: stylo: Stop wallpapering over the sizing-orthog-vrl-in-htb-* tests.
  • Reviewed bug 1389154
• bug 1384602 RESOLVED::FIXED stylo: Squashed boxes in YouTrack Agile Boards view
  • Reviewed bug 1384602
• bug 1389871 NEW:: stylo: only clear relevant origins when medium features change
  • Reviewed bug 1389871
• bug 1383869 RESOLVED::FIXED Stylo: Mac bidi reftests fail in Gecko vs. Stylo mode, font sizing seems different
  • Reviewed bug 1383869
• bug 1389937 ASSIGNED:: stylo: the cascade origin lookup order introduced in bug 1382925 doesn't match gecko.
  • Uploaded patches for bug 1389937
• bug 1388855 NEW:: have CSS parser find source map URLs and preserve them on style sheet
  • Reviewed bug 1388855
• bug 1389041 RESOLVED::FIXED A simple optimization to test_value_computation.html
  • Reviewed bug 1389041
• bug 1369815 NEW:: Implement 'minimal-ui' and 'standalone' matching for display-mode media queries
  • Re-reviewed a patch in bug 1369815?
  • Reviewed bug 1369815
• bug 1381744 RESOLVED::FIXED Add web-platform tests for image, css and fonts for data: URI
  • Reviewed bug 1381744
• bug 1388625 RESOLVED::FIXED stylo: Restyle various wrapper anonymous boxes
  • Reviewed bug 1388625
• bug 1388216 RESOLVED::FIXED stylo: Rendering of afr.com differs between stylo enabled and disabled nightly
  • Reviewed bug 1388216

CJ Ku

• bug 1389068 RESOLVED::FIXED Add comment for GetPreEffectsVisualOverflow
  • Bug 1389068 filed and r?
  • Bug 1389068 landed.
• bug 1388953 NEW:: Rename variable name of nsSVGDisplayableFrame type from svg to displayable
  • Bug 1388953 filed
• bug 590434 RESOLVED::DUPLICATE SVG filter are not fully applied when changing an HTML img source
  • Bug 590434 fixed-dup
• bug 577824 UNCONFIRMED:: HTML element attached is not rendered if an SVG filter is applied to it
  • Bug 577824 upload a patch
  • Bug 577824 upload patches and give a reply on bugzilla
• bug 1385745 ASSIGNED:: Only first line is visible in inline element with filter and box-decoration-break:clone
  • Bug 1385745 reviewed
• bug 1388985 ASSIGNED:: css clip-path with basic-shape rendering should respect box-decoration-break
  • Bug 1388985 reviewed
• bug 1389437 NEW:: currentColor should not be converted to a specific color value before the CSS property is inherited
  • Bug 1389437 filed
• bug 1385929 RESOLVED::FIXED Find a way to prevent duplicate gfxContext::Save/Restore
  • Bug 1385929 landed

Farmer Tseng

• bug 1382509 ASSIGNED:: Build PDFium as a separate library instead of linking it into libxul
  • Pushed try, uploaded patches, r? on Bug 1382509
• bug 1388951 ASSIGNED:: [PDF gtest] Compare EMF contents with reference
  • Filed Bug 1388951
  • Pushed to try, uploaded patches , requested feedback on Bug 1388951
  • Updated the steps to build pdfium.dll from google source on Bug 1388951
• bug 1358076 RESOLVED::FIXED [PDF gtest] Implement unit test for PDFViaEMFPrintHelper
  • Landed patches on Bug 1358076

Jeremy Chen

• bug 1375332 ASSIGNED:: stylo: font-size doesn't always respond to language-specific minimum size when using charset-derived language
  • Best practice of debugging w/ rr [Bug 1375332]
• bug 1387982 NEW:: stylo: The serialization of filter has unit but the expected value is unitless in test_transitions_per_property.html
  • Investigated Bug 1387982
• bug 1367118 RESOLVED::FIXED stylo: investigate the disabled SVG related tests
  • Resolved Bug 1367118

Ting-Yu Lin

• PTO 8/8 ~ 8/11
• bug 1374902 NEW:: stylo: Have unprefixed :fullscreen pseudo-class guarded behind full-screen-api.unprefix.enabled
  • Reviewed bug 1374902.

Tommy Kuo

• bug 1384802 NEW:: Stylo: Empty rules should still be returned by inIDOMUtils.getCSSStyleRules
  • Trace code for inDOMUtils::GetCSSStyleRules (bug 1384802)
  • Upload patch to ask to review and run a try (Bug 1384802)

Ya-Chieh Wu

• Bug1379306 r+
• bug 8894712 Invalid bug or security bug
  • Bug 8894712 f?

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics