TPE-Layout/2017-09-05

Weekly Announcement

• Sheriff in Asia
  • Send your requests in https://wiki.mozilla.org/Sheriff

Weekly Status

Astley Chen

• bug 1347133 NEW:: Intermittent shape-outside-polygon-026.html == shape-outside-polygon-026-ref.html | image comparison, max difference: 255, number of differing pixels: 800000
  • Bug 1347133 - intermittent blank reftest test tracked in bug 1300355.
  • Bug 1347133 - intermittent failure in shape-outside reftest.
• bug 1394278 NEW:: Font changes in-line when lang="nan"
  • Bug 1394278 - update test result and set to macOS only issue.
• bug 1388931 NEW:: Consider removing SVGPathSeg APIs
  • Bug 1388931 - interop issue needs further address.
• bug 1300355 NEW:: intermittent blank reftest test or reference screenshots on win7 PGO
  • Bug 1347133 - intermittent blank reftest test tracked in bug 1300355.
• bug 1390105 NEW:: [webvtt] German umlauts leave black border which makes them unreadable on white background
  • Bug 1390105 - update finding and provided workaround to Benjamin.

Boris Chiou

• bug 1393605 RESOLVED::FIXED stylo: panicked at 'determinant should now be 1 or -1'
  • Landed bug 1393605 - stylo: panicked at 'determinant should now be 1 or -1'
• bug 1395881 RESOLVED::FIXED stylo: Enable table-overflowed-by-animation.html
  • Reviewed bug 1395881
• bug 1392161 ASSIGNED:: stylo: Length values should not be rounded to Au for computed transform
  • Wrote patches for bug 1392161 - stylo: Length values should not be rounded to Au for computed transform
  • Wrote patches to introduce TransformLength and TransformLengthOrPercentage. CalcLengthOrPerecentage uses Au in both specified and computed values, so I skip this case for now, for bug 1392161
• bug 1396442 RESOLVED::FIXED stylo: Enable clipped-animated-transform-1.html for styloVsGecko
  • Reviewed bug 1396442 - stylo: Enable clipped-animated-transform-1.html for styloVsGecko
• bug 1396535 NEW:: Transform translate rounding issue if we use relative length
  • Filed Bug 1396535 - Transform translate rounding issue if we use relative length
• bug 1390039 RESOLVED::FIXED stylo: Implement compute_distance for mismatched transform lists
  • Landed bug 1390039 - stylo: Implement compute_distance for mismatched transform lists

Cameron McCormack

• Continue Stylo memory investigations; start prototyping CascadeData sharing while waiting for njn's Stylist measurements
• Continuing to investigate Stylo memory issues
• bug 1393189 RESOLVED::FIXED stylo: Assertion failure: IsResolved()
  • Reviewed some parts of bug 1393189
• bug 1395312 RESOLVED::FIXED Table backgrounds should use the visibility of the cell, not of the col/colgroup/row/rowgroup
  • Reviewed bug 1395312
• bug 835204 ASSIGNED:: "Segoe UI Light" not recognized as a font-family name (was: Font will not display)
  • Reviewed bug 835204
• bug 1394662 RESOLVED::FIXED Consider making ::-moz-table-column a non-inheriting anon box
  • Reviewed bug 1394662
• bug 1394729 RESOLVED::FIXED Measure memory usage of Stylo's Rule Tree
  • Reviewed bug 1394729
• bug 1387905 RESOLVED::FIXED stylo: Algorithm for specificity is different causes devtools test to fail
  • Reviewed bug 1387905
• bug 1395650 RESOLVED::FIXED Make anonymous colgroups non-inheriting anon boxes
  • Reviewed bug 1395650
• bug 1367854 NEW:: stylo: Memory usage seems to be higher than Gecko
  • Updated bug 1367854 with results from experimenting with arena allocation
• bug 1395586 NEW:: Add accessors to trivial nsStyleDisplay members, and make them private.
  • Reviewed bug 1395586

CJ Ku

• bug 1395873 RESOLVED::FIXED Changes in bug 1361639 caused some deadcode in SVGTransformableElement::GetAnimatedTransformList
  • Bug 1395873 landed
  • Bug 1395873 upload patch
• bug 1382534 NEW:: Black gaps when scrolling BBC photo gallery
  • Bug 1382534 comment feedback for how to get clip bound of a clip-path
• bug 1395976 NEW:: Add more test cases in test_bbox-changes.xhtml
  • Bug 1395976 filed
• bug 1118710 NEW:: SVG mask animation is not working
  • Bug 1118710 WIP
• bug 1361639 RESOLVED::FIXED getBBox returns wrong x,y for use-element
  • Bug 1361639 landed
  • Bug 1361639 WIP
  • Bug 1361639 upload a patch, still need test cases.
• bug 1396489 NEW:: Let gfxContext::GetClipExtents be able to return clipped rect in either user space or device space
  • Bug 1396489 upload patches
• bug 1396025 NEW:: Write a comment to explain the difference between eBBoxIncludeFill and eBBoxIncludeFillGeometry
  • Bug 1396025 file and upload a patch
• bug 1395439 RESOLVED::FIXED Clean out useless flags to reuse cache FillGeometry in nsSVGUtils::GetBBox
  • Bug 1395439 filed
  • Bug 1395439 landed

Farmer Tseng

• Mortar Printing
  • Created a child process while printing
  • Study how to create a child process
  • Study how to setup IPC between parent and child process

Jeremy Chen

• bug 1395479 RESOLVED::DUPLICATE stylo: the rule list of an element with @keyframe rule is empty on DevTools
  • Triaged Bug 1395479
• bug 1394994 ASSIGNED:: Stylo: Keyframe rules missing line / column info
  • Addressed reviewer's comments and got r+, got postive try run, created servo PR [Bug 1394994]
  • Fixed unit test failures caused by servo PR, got r+ with the fix, wait for a positive try before landing [Bug 1394994]
  • Investigated Bug 1394994
  • Studied, posted an implementation plan, start to work on WIPs [Bug 1394994]
  • Uploaded a WIP [Bug 1394994]
  • Uploaded patchset for review, pushed a try [Bug 1394994]
• bug 1359303 RESOLVED::FIXED stylo: should not skip parent display-based style fixups for NAC that is not a NAC root
  • Investigated and NI bz for advice [Bug 1359303]
  • Landed Bug 1359303
  • Uploaded a patch for review [Bug 1359303]

Ting-Yu Lin

• bug 1382078 ASSIGNED:: stylo: XBL style doesn't respond to media changes
  • Addressed review comments for bug 1382078.
  • Investigate bug 1382078.
  • Investigated the reason for bug 1382078 backout
  • Landed bug 1382078.
  • Uploaded patches for bug 1382078 to support media changes for XBL styleset.
• bug 1384232 RESOLVED::FIXED stylo: Assertion failure: oldStyleContext->ComputedData() != newContext->ComputedData()
  • Reviewed bug 1384232.
• bug 1394304 REOPENED:: Support always open urlbar result in a new tab
  • Landed bug 1394304.
  • Uploaded a new patch for bug 1394304.

Tommy Kuo

• bug 1391198 RESOLVED::FIXED stylo: The order of rules in DevTools is not specificity order when all declarations in a rule are !important.
  • Got r+ (bug 1391198)
  • Landed (bug 1391198)
  • Run a try to test how many test cases would be fixed (bug 1391198)
  • Trace code for rule tree of gecko (bug 1391198)
  • Update patches and ask to review (bug 1391198)
  • Upload WIP patches (bug 1391198)
• bug 1380590 NEW:: stylo: the fill color should be transparent when `svg.context-properties.content.enabled=false` and no fallback color given
  • Ask to review (bug 1380590)
  • Debug (bug 1380590)
  • Revise patches and ask to review (bug 1380590)
  • Trace code (bug 1380590)
  • Update patches and ran a try (bug 1380590)
  • Upload patches and run a try (bug 1380590)
• bug 1395479 RESOLVED::DUPLICATE stylo: the rule list of an element with @keyframe rule is empty on DevTools
  • Investigate the failure of devtools test cases and file bug (bug 1395479)

Ya-Chieh Wu

• bug 332740 NEW:: [BC] rowspan and border-collapse: collapse breaks border rendering
  • Debug Bug 332740
• bug 895096 NEW:: border-collapsed table borders have inconsistent widths when device pixel scale is not 1 (zoom)
  • Address the review comment of bug 895096
• bug 410959 ASSIGNED:: [BC] Table cell border widths render incorrectly at various zoom levels
  • Debug Bug 410959

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics