Confirmed users
1,927
edits
Phabricator/TestPlan: Difference between revisions
→Test Plan: Enumerate points of Test Plans and Results
(more test cases) |
(→Test Plan: Enumerate points of Test Plans and Results) |
||
| Line 39: | Line 39: | ||
====Test Plan==== | ====Test Plan==== | ||
# Create a new BMO account. | |||
# Make sure to include an irc nick in the Real Name field. | |||
#* E.g. "John Doe [:jdoe]" | |||
# Go to Phabricator and login as the new user. | |||
# Finish account creation. | |||
====Results==== | ====Results==== | ||
# After logging into Phabricator, on the "Create a New Account" page, | |||
## Username should be prefilled with the irc nick, | |||
## Real Name is correct and does not contain [] or any other extraneous characters. | |||
# Clicking register approval completes account creation without error. | |||
# The account works as expected. | |||
[EDGE CASE] Currently when you revoke the "MozPhab" API key on BMO, there is no way to create a new one for Phabricator to use. | [EDGE CASE] Currently when you revoke the "MozPhab" API key on BMO, there is no way to create a new one for Phabricator to use. | ||
| Line 57: | Line 57: | ||
====Test Plan==== | ====Test Plan==== | ||
# Make sure you have arc properly setup on your machine and have run <code>arc install-certificate</code> using the Phabricator user you wish to test with as documented above. | |||
# Go to BMO and create a new bug as the Bugzilla user that the Phabricator account is connected to. (Or use an existing public bug). | |||
#* To create bugs directly and bypass triaging, go to https://bugzilla.allizom.org/enter_bug.cgi?product=Firefox&format=__default__ (staging) or https://bugzilla-dev.allizom.org/enter_bug.cgi?product=Firefox&format=__default__ (dev) | |||
# Using the repo listed in the "Getting Started" section above that matches the environment you are testing, make some change to a file. | |||
# Run <code>hg commit -A -m 'commit1: New changes</code> | |||
# Run <code>arc diff .^</code> | |||
# Input something for the title, summary, test plan, and the correct bug id. | |||
# Save and exit the file. | |||
====Results==== | ====Results==== | ||
# <code>arc diff</code> only submitted the 1 newly created commit. | |||
# Visit Phabricator and there should be a new revision with the title. | |||
# The revision should contain the correct diff of the changes that were made. | |||
# The "Bugzilla Bug ID" is correct. | |||
## The Bug number is correct. | |||
## The link is correct based on the environment (bugzilla.allizom.org for staging, bugzilla-dev.allizom.org for dev). | |||
#* Note: If the bug id is short (like 3, 92, etc, which is common on local test environments) the link will not work but that is fine because it only works on very long bug ids which match what new bugs on production bmo will be using. | |||
# Visiting the bug on bugzilla shows an <code>x-phabricator-request</code> attachment. | |||
=== Updating a revision with an amended commit is successful === | === Updating a revision with an amended commit is successful === | ||
====Test Plan==== | ====Test Plan==== | ||
# <code>hg update</code> to a commit which you previously submitted with arc | |||
# Make a change and run <code>hg commit --amend</code> | |||
# Run <code>arc diff .^</code> | |||
====Results==== | ====Results==== | ||
# arc should automatically detect a revision and ask you if you want to update it. | |||
# The revision is updated with the new diff on Phabricator: | |||
## The History tab should have two entries, Diff 1 and Diff 2. | |||
## The Commits tab should have a single entry. | |||
# The bug id and other information remains unchanged. | |||
=== Creating a secure revision is successful === | === Creating a secure revision is successful === | ||
| Line 95: | Line 95: | ||
====Test Plan==== | ====Test Plan==== | ||
# Go to bugzilla and create a security bug: | |||
#* Click "Edit Bug", open the "Security" panel, and check one of the security-sensitive boxes, e.g. "Security-Sensitive Core Bug". | |||
# Create a new hg commit. | |||
# Run <code>arc diff .^</code>. | |||
# Enter the title, summary, test plan, and the bug id of the security bug. | |||
# Submit the revision. | |||
====Results==== | ====Results==== | ||
# The diff and information of the revision are as expected. | |||
# The revision has a "Custom Policy" attached to it. | |||
# The revision added the creator as a subscriber. | |||
# The revision is visible to the user who made it. | |||
# The revision is visible to users belonging to the security groups of the bug. | |||
# The revision is NOT visible to the public without logging in. | |||
# The revision is NOT visible to logged in members without the correct permission. | |||
# There is an <code>x-phabricator-request</code> attachment on the bug in Bugzilla. | |||
=== Creating a revision checks the bug id === | === Creating a revision checks the bug id === | ||
====Test Plan==== | ====Test Plan==== | ||
# Create a new hg commit. | |||
# Run <code>arc diff .^</code> | |||
# Enter information for the title, summary, and test plan. | |||
# Enter the bug id as specified for each expected result below. | |||
====Results==== | ====Results==== | ||
# Entering no bug id fails with a helpful message. | |||
# Entering an invalid bug id, e.g "abcd efg" or "$1000", fails. | |||
# Entering the id of a bug that does not exist fails. | |||
# Entering the id of a bug of a secure revision that the user does not have access to fails. | |||
# Entering a valid bug id is successful. | |||
=== Creating multiple revisions with the same bug id is successful === | === Creating multiple revisions with the same bug id is successful === | ||
====Test Plan==== | ====Test Plan==== | ||
# Create a new hg commit. | |||
# Run <code>arc diff .^</code> | |||
# Enter information for the title, summary, and test plan. | |||
# Enter the bug id. | |||
# Repeat and create another revision with the same bug id. | |||
====Result==== | ====Result==== | ||
# Both revisions are created successfully. | |||
# There are 2 corresponding <code>x-phabricator-request</code> attachments on the bug in Bugzilla. | |||
=== Requesting and leaving a review on a revision is successful === | === Requesting and leaving a review on a revision is successful === | ||
====Test Plan==== | ====Test Plan==== | ||
# Ensure that you have 2 Phabricator accounts that log in via Bugzilla ready to go. | |||
# Create a commit, run <code>arc diff .^</code>. | |||
# Input the title, summary, test plan, and bug id of a public bug. | |||
# For the "Reviewers" field enter the Phabricator user name of the other account. | |||
# Log into Phabricator as the reviewer account. | |||
# Add the "Accept Revision" action at the bottom. | |||
# Add the "Request Changes" action at the bottom. | |||
====Results==== | ====Results==== | ||
# The Phabricator attachment on Bugzilla is present. | |||
# The Phabricator attachment on the bug should have no r+ flags. | |||
=== Resigning as a reviewer removes r+ === | === Resigning as a reviewer removes r+ === | ||
====Test Plan==== | ====Test Plan==== | ||
# Ensure that you have 2 Phabricator accounts that log in via Bugzilla ready to go. | |||
# Create a commit, run <code>arc diff .^</code>. | |||
# Input the title, summary, test plan, and bug id of a public bug. | |||
# For the "Reviewers" field enter the Phabricator user name of the other account. | |||
# Log into Phabricator as the reviewer account. | |||
# Add the "Accept Revision" action at the bottom. | |||
# Add the "Resign as Reviewer" action at the bottom. | |||
====Results==== | ====Results==== | ||
# The Phabricator attachment on Bugzilla is present. | |||
# The Phabricator attachment on the bug should have no r+ flags. | |||
=== Plan Changes clears r+s === | === Plan Changes clears r+s === | ||
====Test Plan==== | ====Test Plan==== | ||
# Ensure that you have 2 Phabricator accounts that log in via Bugzilla ready to go. | |||
# Create a commit, run <code>arc diff .^</code>. | |||
# Input the title, summary, test plan, and bug id of a public bug. | |||
# For the "Reviewers" field enter the Phabricator user name of the other account. | |||
# Log into Phabricator as the reviewer account. | |||
# Add the "Accept Revision" action at the bottom. | |||
# Log into Phabricator as the revision author account. | |||
# Add the "Plan Changes" action at the bottom. | |||
====Results==== | ====Results==== | ||
# The Phabricator attachment on Bugzilla is present. | |||
# The Phabricator attachment in Bugzilla does not have any r+ flags. | |||
=== Abandoning a revision obsoletes the attachment === | === Abandoning a revision obsoletes the attachment === | ||
====Test Plan==== | ====Test Plan==== | ||
# Create a new bug. | |||
# Create a commit and run <code>arc diff .^</code>. | |||
# Input the title, summary, test plan, and bug id of the newly created bug. | |||
# Go to the newly created revision and perform the "Abandon Revision" action. | |||
====Results==== | ====Results==== | ||
# The bug has no active attachments listed. | |||
# The bug has one obsolete attachment listed, linking to the created revision. | |||
=== Reclaiming a revision unobsoletes the attachment === | === Reclaiming a revision unobsoletes the attachment === | ||
====Test Plan==== | ====Test Plan==== | ||
# In the revision created as part of the "Abandoning a revision obsoletes the attachment" test, perform the "Reclaim revision" action. | |||
====Results==== | ====Results==== | ||
# The bug's Phabricator attachment is unobsoleted. | |||