Confirmed users
3,376
edits
Auto-tools/Projects/Stockwell/disable-recommended: Difference between revisions
Auto-tools/Projects/Stockwell/disable-recommended (view source)
Revision as of 16:30, 9 February 2018
, 9 February 2018→Requesting review: - minor updates
(→Making a patch: - making a patch.) |
m (→Requesting review: - minor updates) |
||
| Line 171: | Line 171: | ||
=== Requesting review === | === Requesting review === | ||
In bugzilla, in the bug with [stockwell disable-recommended], use "Attach File" to attach your patch. Browse to find the patch in <your repo directory>/.hg/patches. Make sure you select "patch" for the Content Type. Then request review, "r?", and select a reviewer. In most cases, ask :gbrown or :jmaher for review. | In bugzilla, in the bug with [stockwell disable-recommended], use "Attach File" to attach your patch. Browse to find the patch in <your repo directory>/.hg/patches. Make sure you select "patch" for the Content Type. Then request review, "r?", and select a reviewer. In most cases, ask :gbrown or :jmaher for review. | ||
In the above section it was suggested to copy your patch to ~/ via | |||
cp .hg/patches/bug1234567.patch ~/ | |||
In doing this, you could easily find your patch when in bugzilla and looking to attach a file since it will be ~/bug1234567.patch. | |||
A few extra notes here: | |||
* when uploading a patch the checkbox for "assign this bug to myself" is checked by default, uncheck this as you are just disabling a test | |||
* use a description, not the patch name. Something like: |disable test on <platforms>| | |||
There are additional, generic instructions for getting Mozilla reviews at: | There are additional, generic instructions for getting Mozilla reviews at: | ||