Security/Tracking protection/Bug triage: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
(Use the URL field and mention the Disconnect categories)
(→‎Reproducing bugs: Use of the "user story" field)
Line 30: Line 30:


# Close any unreproducible bugs with <tt>WORKSFORME</tt>.
# Close any unreproducible bugs with <tt>WORKSFORME</tt>.
# Find the offending blocked resource and add a comment to the bug.
# Find the blocked resource(s) responsible for the breakage (using [https://addons.mozilla.org/firefox/addon/umatrix/ uMatrix]) and add it to the '''user story''' field.
# Tag bugs with the category that causes the breakage in the whiteboard field (use [https://github.com/mozilla-services/shavar-list-creation/blob/master/disconnect_mapping.py this mapping] for Twitter, Google and Facebook resources in the ''Disconnect'' category):
# Tag bugs with the category that causes the breakage in the '''whiteboard''' field (use [https://github.com/mozilla-services/shavar-list-creation/blob/master/disconnect_mapping.py this mapping] for Twitter, Google and Facebook resources in the ''Disconnect'' category):
#* '''tp-ads''' for the Advertising category
#* '''tp-ads''' for the Advertising category
#* '''tp-analytics''' for the Analytics category
#* '''tp-analytics''' for the Analytics category
#* '''tp-social''' for the Social category
#* '''tp-social''' for the Social category
#* '''tp-content''' for the Content category (only part of the strict list)
#* '''tp-content''' for the Content category (only part of the strict list)

Revision as of 23:24, 21 June 2018

As bugs come into the Firefox::Tracking Protection component, the bug triage owner should follow these steps:

  1. Move misplaced bugs into the right component:
    • Platform bugs should be moved into Toolkit::Safe Browsing
    • Server-side bugs should be moved into Cloud Services::Server: Shavar
  2. Ensure the URL of the broken page is in the URL field
  3. Breakage bugs should block one of these meta bugs:
    • tppaywall if TP is triggering a paywall / adblocker detection script (e.g. FuckAdBlock)
    • tpvideo if TP is blocking the playing of videos
    • tplogin if TP is breaking the login/registration flow of a site (including SSO providers)
    • tpimages if TP is blocking necessary/useful images (excluding display ads)
    • trackingprotection otherwise
  4. Close paywall-related bugs as WONTFIX.
  5. Mark bugs that have the same root cause (e.g. Facebook videos are blocked on site X) as DUPLICATE of one another.
  6. Add the tp-entitylist whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization.
  7. Add the tp-needsrepro whiteboard tag if the problematic resource is not mentioned in the bug.
  8. For feature requests and bugs that require a product decision:
    1. Tag with the tp-product whiteboard tag.
    2. NEEDINFO :pdol with a suggested decision (typically P3 or WONTFIX).
  9. Move to Tech Evangelism: Desktop any bug that needs to be resolved by the site owners (e.g. to avoid relying on trackers for their site's functionality to work).
  10. Set a priority on the bug:
    • tp-needsrepro: P3
    • tp-product: --
    • tp-entitylist: P2
    • Tech Evangelism: --

Reproducing bugs

Someone looking at the tp-needsrepro bugs should:

  1. Close any unreproducible bugs with WORKSFORME.
  2. Find the blocked resource(s) responsible for the breakage (using uMatrix) and add it to the user story field.
  3. Tag bugs with the category that causes the breakage in the whiteboard field (use this mapping for Twitter, Google and Facebook resources in the Disconnect category):
    • tp-ads for the Advertising category
    • tp-analytics for the Analytics category
    • tp-social for the Social category
    • tp-content for the Content category (only part of the strict list)