Firefox/Meeting/09-Oct-2018

(Mozilla Non-Confidential)

Instructions for Meeting Leader

After the meeting is done, you need to:

1. Post these notes to the wiki.
2. Clear this document for the next meeting leader

Instructions for non-Meeting Leaders

Reminder that a lot of this gets distilled for dissemination to a wider audience. Please be a good citizen and include links/bug numbers when applicable. (Makes life easier for at least mconley.)

Today’s meeting leader is: mikedeboer

General Topics / Roundtable

• [mconley] MyQOnly (WebExtension that puts review count in the browser toolbar)
  • Updated to use pagescraping for Phabricator, which should give you much more accurate results (there were some cases that would fall through)
  • Source. Pull requests and issues welcome.
• [mconley] In this recent bug, I made RemoteWebProgressManager transfer listeners between process flips
  • This means that nsIWebProgressListener’s attached to <xul:browser> will survive remote-to-remote process flips. But they’re lost as soon as they cross the remote-non-remote boundary.

Introductions

• No introductions this week.

Resolved bugs (excluding employees)

• Fixed more than one bug
  • Abdoulaye O. LY
  • Sean Reeise [:sreeise]
  • Tim Nguyen :ntim
  • Tomislav Jovanovic :zombie
• New contributors (🌟 = first patch)
  • 🌟 Markus Staab [:maggus.staab] removed two expensive selectedItem getter accesses in the tabbed browser.
  • 🌟 Amir fixed a bug where the Network Monitor would mangle the display of the response body
  • 🌟 Raza Haider ported about:restartrequired to Fluent
  • Jason Chapin made the naming of some SessionStore.jsm methods clearer
  • 🌟 kenokamo fixed the contrast of the Tracking Protection icon in the Network Monitor
  • 🌟 lennonj1 ported about:config to Fluent
  • Lucas Luna Souza fixed the Network Monitor so that it also displays the HTTP response code text
  • 🌟 meag.harty fixed a bug where the Network Monitor wouldn’t let you Edit and Resend an XHR when filtering requests by XHR

Activity Stream

• No updates this week.

Add-ons / Web Extensions

• Search engines are being converted to webextension style packaging (tracker bug)
• about:addons is getting some visual tweaks.
• Extensions can now create devtools sidebar panes.
• Content scripts can now read from a <canvas> that they have modified.
• Small fixes/improvements to the identity and menus APIs.

Application Services (Sync / Firefox Accounts / Push)

• No updates this week.

Browser Architecture

• Roadmap
• Tree replacement plan

Developer Tools

• 📲 Remote Debugging: you can now connect to remote tabs on devices (set devtools.aboutdebugging.new-enabled to true, install the ADB extension, connect your phone, open about:debugging).
• ⚛ DevTools Fission: work continues to refactor the devtools remote protocol transport layer in order to make transitioning to Fission easier (check out the enormous bug dependency tree).
• 🐛 Debugger:
  • Quality and stability: improving Step Out (to avoid having to click several times), maintaining the expanded state for variables while stepping, auto-expanding the source file currently open in the Sources pane.
  • New features in development: column breakpoints and XHR breakpoints.
  • Prototypes ongoing for WebReplay in DevTools (note that WebReplay is ON in nightly!)
• 🚀 Performance: all times low for the inspector open/reload time after Gabriel's massive patch queue on bug 1494162. 🎉🎉🎉🎉
• 💻 Console: The "Boogaloo" project completed: JSTerm (the console's input bar) is now more powerful and easy to use (syntax highlighting, in-line style, top-level await, autocompletion improvements, history reverse search).
• 🖌 Design Tools:
  • You can now overlay multiple CSS grids at the same time (bug 1317102).
  • The new flexbox item sizing tool is shaping up really nicely (share the love on twitter, bug 1478396).
  • And we're working hard on landing our first version of CSS changes tracking in the inspector.
• ♿ Accessibility: You can now see contrast ratio information for text/background colors on hover when selecting elements in the a11y inspector (bug 1473037)!

Fission

• Added a mechanism to simulate Fission for current frame scripts and actors depending on events, allowing us to write Fission-compatible code and later prevent the landing of Fission-incompatible code
• Created a patch to simulate a potential Fission API for the parent process to communicate with child actors, for a similar reason as above
• Built a proof of concept for the Fission API above for the DateTimePicker

Fluent

• No updates this week.

Lint

• Blogged about “What’s next for ESLint on Firefox Source Code”
• ESLint now uses node from the .mozbuild directory if it is present there (if you’ve run bootstrap recently).
• Preparing to land comma-dangle for the rest of mozilla-central next week (Fri 20th Oct)
• We also have various mentored bugs underway for enabling ESLint on more test directories (e.g. parts of docshell + dom)

NodeJS

• No updates this week.

Performance

• florian
  • New about:performance UI has been enabled by default in Nightly!
    • File bugs in Toolkit :: Performance Monitoring
  • These are the mock-ups for what we hope to eventually ship to release users.
    • Shows an Energy Impact score in abstract units per tab / script / add-on
    • Allows user to close the tab, and in the future pause its JavaScript execution
• Gijs
  • Further work to avoid spurious about:blank creation
    • Made nsISecureBrowserUI::Init take a docshell instead of a content window
    • Working to make the docshell responsible for determining a window's outerWindowID, so we don't have to end up creating an about:blank window just to get it (outerWindowID will remain on window, but is also now on the docshell)
    • Fixed an error in BrowserWindowTracker where it was not properly accounting for Browser::Init messages being from background windows
    • Bunch of investigation (thanks Neil!) in focus issues on Linux that reared their head with some/all attempts to reduce about:blank creation. Going to keep going with addressing this in tests.
  • Also looking to make sure our IME code doesn’t cause focus entering input/textarea/contenteditables to flush layout.
• mconley
  • Working on separating the Activity Stream content process. This will let us take advantage of the ScriptPreloader work that imjching worked on during his internship.
    • Stopped sending CPOWs from RemoteWebProgress.jsm
    • Made RemoteWebProgressManager survive content process switches
  • Have patches up to gut browser-tabsintitlebar.js of layout logic, and put most of the onus on the Gecko Layout engine to put the tabs in the titlebar
• dthayer
  • Working on splitting our input to WebRender into multiple documents / render roots, allowing us to eventually output these to separate framebuffers which we can hand to the OS compositor, allowing us to not have to paint the whole window every time something in the chrome changes / animates
  • Fixed a tab switch regression blocking the process priority manager. Hoping to enable process deprioritization on Windows in Nightly shortly, allowing us to deprioritize processes of background tabs
  • Sorted out a kink with deferring InitOSFileConstants' startup IO, due to off-main-thread use of nsDirectoryService, which maintains a non-thread-safe cache
  • Wrote a blog post about the Client Storage work on macOS

Policy Engine

• Policy for Security Devices (PKCS #11) landed
• Policy for DNS Over HTTPS being reviewed
• Up Next:
  • Installing certificates
  • Browser Startup Page
  • Changing Locale
• Plan is for all policy changes to be in by the end of the week

Privacy/Security

• Firefox Monitor launched and is quickly approaching ~170k sign-ups after launch - Q3 goal was 10k.
• A few decisions on Content Blocking in Firefox 63: FastBlock will not be exposed in Firefox 63, while Cookie Restrictions will ride the trains with 63, prefed-off by default (pref-on planned for 65). The new Content Blocking UI will ride the trains to release as well. All the final pref flips here.

Search and Navigation

Address Bar & Search

• Bookmarked origins are now autofilled regardless of their visited status (bug 1493636)
• Fixed autofill when only bookmarks should be suggested (bug 1489060)
• Fixed a problem with highlighting search engine aliases in the Address Bar (bug 1491724)
• Fixed a bug where scrolling in the search bar may change the current search engine (Bug 1496478)

Places

• Reduced history I/O when the same page is refreshed by a call to location.hash and the page title doesn’t change (bug 1489503)

Test Pilot

• No updates this week.

Web Payments

• Completed our Milestone 3 at the end of Q3!
  • Planning to enable Payment Request with basic-card on Nightly in the next week or so for en-US builds in the US and CA
• Started Milestone 4 this week with the goal of completion by end of Q4. Priorities are: the tab modal payment sheet, handling spec additions (e.g. retry, merchant field-specific errors, and new events) and error handling
• Completed
  • Prefs
    • Link to Firefox Options/Preferences from the PaymentRequest dialog
    • Update the Preferences text and layout for Web Payments
  • Change PaymentRequest UI to support users retrying upon payment failure
  • Add tooltip beside 'save to Firefox' checkbox
  • Save/Next button Refinements
  • Credit card network logos
    • Show card network logos on the card add/edit screens
    • Use card network icons in manage credit cards list
  • Add the CVV security code field to the add card form and make it required in all places
  • Remove Custom Elements polyfill from Web Payments UI
• In Progress
  • Tab-modal Payment Request sheet
  • CVV Tooltip
  • "Forms & Autofill" about:preferences regression

This week I learned

• (from Mossop and Gijs) - If you need a true binary file, TextDecoder does NOT work. Use File.createFromNsIFile(certfile) and then a FileReader (reader.readAsBinaryString(file)) [mkaply]

Meeting Leader Rotation

Add your name below if you want to be in the rotation of leaders:

• mconley
• lina
• johannh
• MattN
• RyanVM
• felipe
• mikedeboer
• 6a68