MozillaWiki

Auto-tools/Projects/Stockwell/disable-recommended: Difference between revisions

Page Discussion

Auto-tools/Projects/Stockwell/disable-recommended (view source)

Revision as of 02:04, 16 July 2019

770 bytes removed ,  16 July 2019
Made some changes about asking a review part.
(Removed deprecated info about making a patch with mq and added info about moz-phab patches.)
(Made some changes about asking a review part.)
Line 176: Line 176:
  moz-phab                                                    //upload the changes to phabricator
  moz-phab                                                    //upload the changes to phabricator


NOTE:
* The comment for the commit needs to follow the general pattern above: "Bug xxx - <patch description>. r=yyy"
* Phabricator automatically detects the reviewer from the commit message and asks for a review to the specified person.
* In most cases, for disable patches use r=gbrown or r=jmaher, except if you are disabling for webrender only, then use r=kats.


NOTE: the self review is a great time to make sure:
NOTE: the self review is a great time to make sure:
Line 181: Line 185:
* you are only editing one line in a file, not multiple lines on accident
* you are only editing one line in a file, not multiple lines on accident
* a chance to review your syntax and any comments
* a chance to review your syntax and any comments
NOTE: the comment for the commit needs to follow the general pattern above: "Bug xxx - <patch description>. r=yyy"
See also https://developer.mozilla.org/en-US/docs/Mozilla/Mercurial .
== Requesting review ==
In bugzilla, in the bug with [stockwell disable-recommended], use "Attach File" to attach your patch. Browse to find the patch in <your repo directory>/.hg/patches. Make sure you select "patch" for the Content Type. Then request review, "r?", and select a reviewer. In most cases, ask :gbrown or :jmaher for review.
'''One exception is if you are disabling a test that is webrender only, please make sure to ask :kats for review.'''
In the above section it was suggested to copy your patch to ~/ via
cp .hg/patches/bug1234567.patch ~/
In doing this, you could easily find your patch when in bugzilla and looking to attach a file since it will be ~/bug1234567.patch.
A few extra notes here:
* when uploading a patch the checkbox for "assign this bug to myself" is checked by default, uncheck this as you are just disabling a test
* use a description, not the patch name.  Something like: |disable test on <platforms>|


There are additional, generic instructions for getting Mozilla reviews at:
There are additional, generic instructions for getting Mozilla reviews at:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch


Csabou
Confirmed users
13

edits

Retrieved from "https://wiki.allizom.org/Special:MobileDiff/1215102"