Confirmed users
1,345
edits
Platform/PrefsOverhaul: Difference between revisions
→{{mok|}} static-prefs
Nnethercote (talk | contribs) |
Nnethercote (talk | contribs) |
||
| Line 119: | Line 119: | ||
* Use of getters avoids possible mistyping of pref names. | * Use of getters avoids possible mistyping of pref names. | ||
* <tt>MediaPrefs</tt> can be removed. (But not <tt>gfxPrefs</tt>, yet; that's a harder nut to crack.) | * <tt>MediaPrefs</tt> can be removed. (But not <tt>gfxPrefs</tt>, yet; that's a harder nut to crack.) | ||
** <tt>gfxPrefs</tt> was removed in {{Bug|1550422}}. | |||
* Initializing from binary should be faster than parsing a data file. | * Initializing from binary should be faster than parsing a data file. | ||
* Unblocks <tt>less-racy-VarCache-prefs</tt>. | * Unblocks <tt>less-racy-VarCache-prefs</tt>. | ||
| Line 124: | Line 125: | ||
Downsides | Downsides | ||
* Adding/removing/modifying one of these prefs causes a lot of recompilation. | * Adding/removing/modifying one of these prefs causes a lot of recompilation. | ||
** {{Bug|1564724}} and {{Bug|1563139}} improved things by (a) generating the header file from a YAML file, and (b) splitting that generated header file into many smaller pieces, each one causing much less recompilation when changed. | |||
== {{mdone|}} <tt>less-racy-VarCache-prefs</tt> == | == {{mdone|}} <tt>less-racy-VarCache-prefs</tt> == | ||