Add-ons/Reviewers/Guide/Review Decision: Difference between revisions

Add-ons/Reviewers/Guide/Review Decision (view source)

Revision as of 21:33, 27 July 2020

323 bytes added , 27 July 2020

→‎Completing the Review: Updating review action descriptions

Kewisch

251

edits

@@ Line 33: / Line 33: @@
 </pre>
-=== Reviewer Replies and Information Requests ===
+=== Reviewer Replies ===
-If you do not have all information required to complete the review, or you have reached one of the cases detailed later on this page, you can request more information from the developer. All communication between developers and reviewers is captured on the review history page.
+With a reviewer reply, you can convey information to the developer. You can use this action to answer questions the developer may have about your review. All communication between developers and reviewers is captured on the review history page.
-To do so, select the “Reviewer Reply” action. For requesting more information, please also ensure that you correctly set the “Require developer to respond” checkbox: if you have a question or comment where the developer must reply, please check the box. If it is an answer to the developer’s question that requires no further action, leave it unchecked. Doing so makes sure the correct email template is used and AMO knows to remind us when the developer has not responded to the request.
+If you need the developer to take action, please make use of a delayed rejection instead. Doing so makes sure the correct email template is used and AMO knows to remind us when the developer has not responded to the request.
-If more information is requested and the developer responds, you will receive email with the developer’s response. At this time you should return to the review page to continue reviewing using the information you received from the developer. Note that the developer may follow up with further questions about the information you are requesting. In all cases, please answer developers in a timely manner ('''within 2 days''').
+If you are unsure how to answer a response from a developer, or the developer is disputing your review, please get in touch with admins to make sure the developer receives a reply. Involving a second reviewer to confirm your review can also be helpful if the developer does not want to accept your reasoning.
+=== Delayed Rejection ===
+If the add-on has minor policy issues that don’t require an immediate rejection, the delayed rejection action should be used. AMO will then reach out to the developer, asking them to resolve the issue within the requested time frame. If the developer fails to comply, the marked versions will be rejected.
+To use a delayed rejection, select “Reject Multiple Versions”, and select the option to delay the rejection. All versions you have selected will be rejected after the time passes.
+If the developer responds, you will receive email with the developer’s response. At this time you should return to the review page to continue reviewing using the information you received from the developer. Note that the developer may follow up with further questions about the information you are requesting. In all cases, please answer developers in a timely manner ('''within 2 days'''). If you are answering questions that require no further response, please use the “reviewer reply” action.
 If you cannot complete the review after the developer has provided information, please at least check if the developer has provided the information you have requested and leave a comment on the version so that other reviewers can continue your work.
@@ Line 44: / Line 51: @@
 Similarly, if you come across an add-on where the developer has provided information but the original reviewer has not followed up within that time, you are welcome to complete the review. The original reviewer may have prior knowledge that would speed up the review, but at the same time we do not want to keep developers waiting.
-If you are unsure how to answer a response from a developer, or the developer is disputing your review, please get in touch with admins to make sure the developer receives a reply. Involving a second reviewer to confirm your review can also be helpful if the developer does not want to accept your reasoning.
-=== Rejection ===
+=== Immediate Rejection ===
 Rejecting an add-on’s versions can mean anything from showing an outdated version of the add-on to completely hiding the listing from addons.mozilla.org (when rejecting all public versions). Especially in the post-review model where add-ons are reviewed after initial approval, a rejection can lead to frustration from the developer. At the same time, we need to ensure that there are no policy violations that threaten user security or privacy.
-'''Our general policy is to only reject when necessary'''. Rejection is necessary when an add-on has security or privacy issues, doesn't meet our content policies, or fits one of the examples described later on.
+'''Our general policy is to only reject immediately when necessary'''. Rejection is necessary when an add-on has security or privacy issues, doesn't meet our content policies, or fits one of the examples described later on.
 If the issues you have found are severe enough to warrant a rejection, you will need to determine when the developer started to use the code in question, so you can determine which versions to reject. Generally it is sufficient to check back until the last reviewed version, for example using a [https://en.wikipedia.org/wiki/Bisection_(software_engineering) bisection] approach. If the issue also exists in that last reviewed version, you will need to track back further.
-In case of a rejection, developers may have questions on how to best resolve the policy issues, or if they have trouble understanding the message. Similar to the information request, please answer in a timely manner using the reviewer reply feature.
+In case of a rejection, developers may have questions on how to best resolve the policy issues, or if they have trouble understanding the message. Similar to the delayed rejection, please answer in a timely manner using the reviewer reply feature.
 === Super-Review ===
-Using the “Request Super Review” action will put the add-on into the admin queue. There are few select cases where this would occur, please see the examples below for further details. If you have a concern that needs immediate admin attention, please get in touch with the admins via the channel described in the Escalation section, as there is no specific notifications to admins when you request super review.
+Using the “Request Super Review” action will put the add-on into the admin queue. There are few select cases where this would occur, please see the examples below for further details. If you have a concern that needs immediate admin attention, please get in touch with the admins via the channel described in the Escalation section, as there are no specific notifications to admins when you request super review.
 === Escalation ===
@@ Line 64: / Line 70: @@
 === Multiple Categories of Issues ===
-If you find multiple issues within the add-on where there are both information requests and rejections, you may reject the add-on. Please make sure to clearly separate info requests from rejection reasons. An example on how this can be done is shown above.
+If you find multiple issues within the add-on where there are both delayed and immediate rejections, you may reject the add-on immediately. Please make sure to clearly separate information needed to complete the review from rejection reasons. An example on how this can be done is shown above.
 If you find either a case warranting a super-review or an escalation combined with other issues, you can leave the issues you have found as a comment, noting the review is incomplete (e.g. lead with “Before requesting super-review, I have found the following issues that may be useful to complete the review”)