TestEngineering/Performance/Onboarding

Getting Started

If you're looking for a guide to help you get going, the new contributor page should have all the information you need.

Meetings

• When: Weekly on Wednesdays at 15:00 UTC (08:00 PST, 11:00 EST, 18:00 EET)
• Where: Zoom ID 110-819-485
• Notes: Google Docs

Phonebook

The people directory is a secure place to quickly find your team members and easily discover new ones.

Please ensure your profile has:

• photo (of you!)
• username (this is included in your profile URL)
• GitHub identity
• #Bugzilla identity
• Matrix nick
• Slack nick

Calendar

There's a Performance shared calendar (iCal), which is primarily used for PTO. Add this calendar to your google calendar by taking the iCal link and using it in the "Add Calendar -> From URL" section.

PTO

Add any PTO to the shared calendar (see above) and team meeting notes so the team are aware. During PTO please also update your name in Bugzilla's user preferences to indicate that you are away, and when you will return.

Communication

Groups

Feel free to sign up to the following groups, and post to them when you have something to share or questions to ask.

• perftest is for team communications and setting up test accounts
• performance is for general discussion and announcements
• perfteam is for the broader performance team
• perf-sheriffs is for discussions related to performance sheriffing
• perftest-alerts is for alerts related to performance tests

Matrix

Feel free to browse through the full list at your leisure and find things that interest you. Here are some to start with:

• #perf- General performance chat
• #perftest- Public team channel
• #perfteam- Public performance team channel
• #perfsheriffs- Performance sheriffs channel

Slack

Here are some useful Slack channels to start with:

• #announcements - Global communication and announcements
• #moco - Used for questions during internal meetings
• #newsroom - Firefox and relevant tech news
• #servicedesk - Internal IT support for employees
• #peopleteam - People support
• #perf-donut - Channel for donut pairings within the perf team

Credentials

There's a shared 1Password vault for credentials that you may need to access. Please submit a request for 1Password from ServiceDesk. Once you have an account and the software set up (available on iOS, Android, Windows, macOS) you can be added to the team vault.

Hardware

List any hardware devices that you have assigned to you in this document. This can be valuable if we need to identify somebody on the team that has a specific device or platform for running tests, reproducing issues, etc. You may need additional hardware such as mobile devices, laptops, etc. You can request this equipment from The Hub.

Bugzilla

You will need to create an account in Mozilla's instance of Bugzilla. See BMO/UserGuide for how to get started. It's helpful to include your Matrix/Slack handle in your name field prefixed by : so you can quickly be identified by other users of Bugzilla. Other details that can be helpful are your preferred pronouns, current timezone, and if you're currently on PTO. For example:

 Dave Hunt [:davehunt] [he/him] ⌚BST (away until 1st January 2021)

Products/Components

The relevant components for the team are:

• Testing::AWSY
• Testing::mozperftest
• Testing::Performance
• Testing::Raptor
• Testing::Talos

Whiteboard Entries

The following whiteboard entries are used by the team:

• [perftest:triage] - discussion required in triage.
• [perf:responsiveness] - related to responsiveness.
• [perf:workflow] - related to the performance workflow.

Keywords

• perf-alert - relates to a performance alert (regressions and improvements).

Resources

• Bug writing guidelines
• Bugzilla etiquette

GitHub

If you don't already have one, you will need to create a GitHub account and enable two-factor authentication.

We have a GitHub team for simplifying access to repositories. All team members that belong to the Mozilla organisation should be added to this team as members. Team maintainers can add new members following the process documented here. Other contributors will need to be manually granted access to individual repositories as needed.

Shared folder

We have a shared folder in Google Drive.

Sheriffing

Performance sheriffs will need to complete the following:

• Request an LDAP account
• Request commit access:
  • Level 1: bug 1398609
  • Level 3: bug 1509284
• Request access to Treeherder sheriff group: bug 1506882
• Training (ranked)
• Join the perf-sheriffs Google Group

Review policy

When you push a commit up for review, you should use the following syntax to request review from the perftest review group:

 r=#perftest

For most patches, a single r+ from one reviewer is required to be allowed to be sent off for integration. More reviewers can pitch in on the same review, and Lando will in this case automatically rewrite the commit message to show who was involved signing off the patch, for example:

 Bug 1546611 - Fix "None" checks when validating test manifests; r=perftest,dhunt

[the section "Write Sensible Commit Messages" here for how to form good commit titles and summaries].

When you occasionally you have to single out individuals for specific topic expertise, you add an exclamation mark behind the nickname:

 r=#perftest,dhunt!

This will add the patch to the shared review queue, but also block the review from landing pending Dave's approval. Requested changes by other reviewers will also block the review.

Note that a Herald rule exists that will set this group as a blocking reviewer for certain paths in the tree. This was configured via bug 1618249.

Module ownership policy

If a patch touches code in a module owned by someone outside of the team, you must follow the module ownership policy and request review from the module owner or a peer listed in Modules.

Duties

Everyone on the team will be expected to carry out the following duties to ensure effective collaboration both within the team, and with other teams.

Code reviews

Visit active revisions in Phabricator every day to:

• Review any Must Review and Ready to Review patches. Pay particular attention to any patches that have yourself as the sole reviewer. Consider adding the #perftest review group for a wider audience of reviewers. All review requests should receive a response (not necessarily a complete review) within 1 working day.
• Follow up on any Waiting on Review patches by prompting appropriate team members for a review.
• Review any Waiting on Authors patches and prompt the authors if there is an action they need to take.

Bugzilla requests

Visit the request queue in Bugzilla every day and filter by your account to see all requests that have been submitted for you. Requests for P1/P2 bugs should recieve a response within 1 working day. All other requests should receive a response within 5 working days.