Media/WebRTC/libwebrtc Update Process: Difference between revisions

Clarify extract-for-git.py some more
(Break out Reacting to loop-ff.sh section to highlight the three types of failures to deal with)
(Clarify extract-for-git.py some more)
Line 88: Line 88:
  tail -f .moz-fast-forward/logs/log-loop-ff.txt | grep loop-ff
  tail -f .moz-fast-forward/logs/log-loop-ff.txt | grep loop-ff
* [[libwebrtc GYP generated Java files|GYP generated Java files]]
* [[libwebrtc GYP generated Java files|GYP generated Java files]]
* If you are requested to run <code>extract-for-git.py</code>, note that <code>loop-ff.sh</code> offers some information in initial vendoring that is is useful later, but not repeated in <code>verify_vendoring.sh</code>. Specifically, the tip about <code>tip::tip</code>:
* If instructed to run [https://searchfox.org/mozilla-central/rev/3b707c8fd7e978eebf24279ee51ccf07895cfbcb/dom/media/webrtc/third_party_build/extract-for-git.py#9-12 extract-for-git.py], note that <code>loop-ff.sh</code> has more context than <code>verify_vendoring.sh</code> and offers information that is relevant: Specifically, the tip about <code>tip::tip</code>:
     If you have previously run loop-ff.sh successfully, there may be a new
     If you have previously run loop-ff.sh successfully, there may be a new
     change to third_party/libwebrtc that should be extracted and added to
     change to third_party/libwebrtc that should be extracted and added to
Line 97: Line 97:
         git am mailbox.patch)
         git am mailbox.patch)


* It may not always be <code>tip::tip</code> depending on what was necessary to fix the issue (say a BUILD.gn change, followed by moz.build generation, and those moz.build files committed in a separate commit).
* Replace <code>tip</code> here with your (fix-xxx) mercurial patch, if it is not at tip (e.g. if it is followed by (fix-xxx) - moz.build file updates).


=== Backing out ===
=== Backing out ===
24

edits