Media/WebRTC/Up-streaming Changes: Difference between revisions

From MozillaWiki
< Media‎ | WebRTC
Jump to navigation Jump to search
(Fix title)
(No difference)

Revision as of 19:06, 10 August 2023

Prerequisites

  • Install the prerequisite software for libwebrtc development as instructed here.
  • While that is installing create an account with the upstream repo. In order to submit patches as a Mozilla employee this will involve filling out a corporate contributor agreement via this bug. Also see the sections Contributing Your First Patch and Contributor Agreement for more information about the agreement itself.

One can check that one has been successfully added here. When you click "Manage your Agreements" at the bottom of the page should see that you have a Mozilla Corporate CLA listed. If you aren't already logged into a Google service, you will need to use Mozilla's SSO portal to log in to gmail or any other google product.

Installing Commit-Id Git Commit Hook Plugin

In order to push patch stacks (instead of squashing), one needs to have a Git commit hook installed to correlate the stack patches using a Change-Id.

  • To install the commit hook follow the instructions here.
  • The Change-Id Docs can be found here.

Checking Out The Source

  • Use the instructions here to checkout the upstream repo if you have not already.

Running Tests

  • While these instructions are for running Chromium tests, the same process applies for libwebrtc. There is no facility to help you run all the tests, you need to run all the test binaries that are produced. There are no facilities for helping you identify which tests you should be running. Inserting an RTC_CHECK(false), can be useful for verifying that one is testing using the correct binary.

Submitting Code

Opening An up-stream Bug

Submitting An up-stream Patch

Requesting A Reviewer

Asking For CI Runs

Tracking Progress

There is a spreadsheet to track the progress of our in progress up-stream patches.