Thunderbird/Students/StatusUpdates/2010-03-19: Difference between revisions

Thunderbird/Students/StatusUpdates/2010-03-19 (view source)

1,081 bytes added , 21 March 2010

33

edits

@@ Line 30: / Line 30: @@
 ===== Wei Xian Woo  =====
+My work on supporting additional window types is currently suspended. After Blake's 2nd review of my first patch, I made a few minor changes he suggested and submitted the patch again for a 3rd review -- this time by Andrew Sutherland. He pointed out a number of things and I spent the week making some of these changes. They include:
+* Listening to the "quit-application" event, which is essential to handling the "File -> Quit" case. It was apparent from Andrew's very first comment about my patch that I made a false assumption.
+* Renaming some functions so their names would be slightly more descriptive. For example, |getState| vs |getWindowStateForSessionPersistence| in the 3-pane window class.
+* Making the interaction between the session store manager and the 3-pane window more natural. By trying to preserve existing logic made things seem somewhat awkward.
+* Adding detail to some comments. For example, "the last state string" vs "the JSON stringified representation of the last saved state".
+I expect to submit a revised patch before the end of the coming week.
 ==== Who’s writing the blog post this week? ====
 Tim Miller