947
edits
Auto-tools/Projects/MozmillBuildbot: Difference between revisions
note buildbotcustom PYTHONPATH issue
(more detective work on download issue and a new patch) |
(note buildbotcustom PYTHONPATH issue) |
||
| Line 35: | Line 35: | ||
The patch at http://k0s.org/mozilla/hg/buildbotcustom/.hg/patches/rev/71b8c045d03a reveals <tt>build.source.changes</tt> is in fact an empty tuple. This is from ''force build'' | The patch at http://k0s.org/mozilla/hg/buildbotcustom/.hg/patches/rev/71b8c045d03a reveals <tt>build.source.changes</tt> is in fact an empty tuple. This is from ''force build'' | ||
== Tips == | |||
* buildbotcustom is not a python package. On the VM, it is installed in <tt>/tools/buildbotcustom/buildbotcustom</tt> which is added on <tt>cltbld</tt> login to <tt>PYTHONPATH</tt>. On a local machine, I use a [http://pypi.python.org/pypi/virtualenv|virtualenv] to isolate python development. I download buildbotcustom to <tt>$VIRTUAL_ENV/buildbotcustom/buildbotcustom</tt> and then add <tt>$VIRTUAL_ENV/buildbotcustom</tt> to the <tt>PYTHONPATH</tt> in the <tt>$VIRTUAL_ENV/bin/activate</tt> file so that the code is available within the virtualenv. | |||
== Outstanding Work == | == Outstanding Work == | ||
* Add corrections to https://wiki.mozilla.org/Buildbot and linked pages | * Add corrections to https://wiki.mozilla.org/Buildbot and linked pages | ||
== Long-term Recommendations == | == Long-term Recommendations == | ||
| Line 45: | Line 51: | ||
* '''Use templates for buildbot-configs:''' the configurations in http://hg.mozilla.org/build/buildbot-configs are hard-coded for the setup for VMs. Instead, they could be made templates for easy deployment. Cleanup should also be done so that the configurations are more universal and adding new configurations is easy. | * '''Use templates for buildbot-configs:''' the configurations in http://hg.mozilla.org/build/buildbot-configs are hard-coded for the setup for VMs. Instead, they could be made templates for easy deployment. Cleanup should also be done so that the configurations are more universal and adding new configurations is easy. | ||
* '''Make buildbotcustom a python package:''' reason: there's no reason not to (except legacy reasons, continue reading) and having the python be installable saves the trouble with messing with the <tt>PYTHONPATH</tt>. There is a considerable downside in practical terms, however; http://hg.mozilla.org/build/buildbotcustom is a top level repository; all files therein would have to be moved to http://hg.mozilla.org/build/buildbotcustom/buildbotcustom with the top level directory containing a <tt>setup.py</tt> file. While the effort is minimal, it may cause issues for existing installations which, while easily resolvable, might involve some work. | |||