Confirmed users, Bureaucrats and Sysops emeriti
2,088
edits
Jetpack/Contribution: Difference between revisions
→How to Make Code Contributions
| Line 19: | Line 19: | ||
# Write a test ([https://jetpack.mozillalabs.com/sdk/latest/docs/#guide/packaging intro], [https://jetpack.mozillalabs.com/sdk/latest/docs/#module/jetpack-core/unit-test API]) | # Write a test ([https://jetpack.mozillalabs.com/sdk/latest/docs/#guide/packaging intro], [https://jetpack.mozillalabs.com/sdk/latest/docs/#module/jetpack-core/unit-test API]) | ||
# Attach your code changes and tests in a combined patch to the bug | # Attach your code changes and tests in a combined patch to the bug | ||
# Ask for code review by setting the "review" flag on your attachment to "?" and entering the email | # Ask for code review by setting the "review" flag on your attachment to "?" and entering the email of the appropriate developer | ||
* | |||
* For Mozilla platform usage, ask Drew, Myk or Dietrich (and they can find the domain expert) | = Reviewers = | ||
* For API and developer ergonomics review, ask Myk | |||
* All changes must be reviewed by Atul, until the platform settles | |||
* On top of Atul's review: | |||
** For review of Mozilla platform usage and best practices, ask review from Drew, Myk or Dietrich (and they can find the domain expert) | |||
** For API and developer ergonomics review, ask Myk | |||