Platform/JS Compartments Mochitest

This page is a tracking page for getting the JS compartments work to pass xpcshell tests and Mochitests and other automated test suites.

How to get the patch queue

Install hg queues.

Then add to .hg/patches/.hg/hgrc

[paths]

default = http://hg.mozilla.org/users/mrbkap_mozilla.com/brain-transplants

Then go into .hg/patches and hg pull, hg up and then go back to ../../ and do hg qpush -a. Build. Every time we update the queue you have to do qpop -a in the repository, then pull and update the patch queue, and then go back and do qpush -a to get the patches applied again.

QA

Started build for QA to test.

Fixed:

• Adblock doesn't seem to filter (tries to call a function on undefined).
• Adblock crashes.

xpcshell

default compartment leaks

done

bug 599761 (_newJSDContext)

bug 599762 (js::ctypes::CClosure::ClosureStub)

bug 600022 (XPCShellEnvironment::Init())

bug 600032 (JetpackChild::Init())

bug 600173 (atoms should always be in the default compartment)

bug 600580 (_newJSDContext, part 2)

bug 600402 (don't copy strings for the same compartment)

Mochitest

Run with python runtests.py --total-chunks=20 --this-chunk=n --autorun --debugger=gdb where n is the chunk you want to examine.

Remaining large-ish items

Post b7:

• document.domain (we currently don't revoke access to the document's original domain, we probably should do that).
• Error hacks?
• Fix error messages for property access denied. Old message included two origins, new one doesn't, and it looks like we're not using any of the localization that the old message had. Error console should show both origins, exception message probably (?) shouldn't.
• Confirm that the fix in docshell/test/chrome/test_bug454235.xul is appropriate.
• We no longer support .wrappedJSObject on location and XMLHttpRequest. Confirm that it was ok to remove those from tests/js/src/xpconnect/tests/mochitest/test_bug553407.html.

FIXED issues:

• I allow named frames to be created on xray wrappers so parent[name] works.
• Fix up XrayWrappers
• Make chrome wrappers expose nothing by default
• added scriptOnly check to chrome object and make all XOWs script only
• Location object
• nsJSContext::BindCompiledEventHandler(), target and funobj from
• Components.utils.import() from non-chrome code.
• DocShell navigation tests
• XPCNativeWrapper.unwrap() different compartments
• IndexedDB and DOM worker tests, need cross compartment structured clone (jorendorff/bent)
• XPCNW holder objects vs JS_ClearScope()

Remaining test failures

http://mochi.test:8888/tests/dom/tests/mochitest/whatwg/test_postMessage_joined.html

Asserts to death:

http://mochi.test:8888/tests/toolkit/components/microformats/tests/test_Microformats_add.html

Mochichrome

13 failing tests out of 14051, in these files:

chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_evalInSandbox.xul
-> add a function that the sandbox can call which forwards to getClassName

No idea what that comment about getClassName means. What is happening here is that the test is using exactly the same technique GreaseMonkey uses to set up the sandbox, and that doesn't work anymore.

The specific issue is with code that does sandbox.__proto__ = new XPCNativeWrapper(window); where the caller is chrome, but sandbox and window are same-domain. When we rewrap the XPCNativeWrapper, it becomes a simple cross-compartment wrapper without X-ray behavior.

The whole rewrapping mechanism works as designed right up to WrapperFactory::Rewrap where it's actually time to create the new wrapper. We have a flags parameter that indicates we want X-ray behavior. But we create a wrapper without it.

We could just make that work, but mrbkap thinks we should instead provide a better sandboxing API and require GreaseMonkey (and any similar extensions) to switch to that.

-jorendorff, 10/5/2010

chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul

Lots of different issues:

7257 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | enumeration over XOWs walks the prototype chain - got "host,hostname,port", expected "assign,foopy,hash,host,hostname,href,pathname,port,protocol,reload,replace,search"

Enumeration bug. "for (e in location)" doesn't walk the prototype chain.

7259 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | wrapper iterators are properly iterators - got "object", expected "function,function,function,number,string,string,string,string,string,string,string,string"

Enumeration bug. "Iterator(new XPCNativeWrapper(location))" is busted. I will look into this further.

7261 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | enumeration over SJOWs walks the prototype chain and works over XOWs - got "", expected "assign,foopy,hash,host,hostname,href,pathname,port,protocol,reload,replace,search"

Enumeration bug. Same kind of problem but here we're trying to iterate over iwin.wrappedObject.location.

7268 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | cyclic proto value allowed

We do iwin.__proto__ = iwin and expect it to fail, but this just creates a new ordinary data property called __proto__ on the holder.

7269 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | iwin.eval does not throw an exception

iwin.eval("'PASS'") must not throw an exception. But it is throwing.

iwin.eval is undefined.

7271 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | Unable to wrap a primitive, even without 'new'

An old feature we didn't retain. XPCNativeWrapper("") is expected to return "". Maybe we can just remove the test.

7276 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | XPCNativeWrappers allow expandos through
   let iwin = $('ifr').contentWindow;
   let (w = new XPCNativeWrapper($('ifr').contentWindow)) {
       w.foopybar = 5;
       ok(!("foopybar" in iwin), "XPCNativeWrappers allow expandos through");
       ...

XPCNativeWrappers must not allow expandos through. But they do.

7284 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | delete doesn't delete underlying properties - got undefined, expected 5
   let iwin = $('ifr').contentWindow;
   let (w = new XPCNativeWrapper($('ifr').contentWindow)) {
       ...
       iwin.foopy = 5;
       ok(delete w.foopy, "delete returns true");
       is(iwin.foopy, 5, "delete doesn't delete underlying properties");

Again, an XPCNativeWrapper must not allow chrome to delete expando properties. I'm not sure why we don't want to allow that, but we're allowing it.

7288 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/js/src/xpconnect/tests/chrome/test_wrappers-2.xul | allowed to update iwin.__proto__ to null - got [], expected null

Possibly just noise. If I comment out the cyclic-__proto__ test, this one passes.

But I can't imagine why iwin.__proto__ appears to be [] here. I looked, and the value we eventually return is a cross-compartment XrayWrapper of an OuterWindowProxy. The value should be null.

-jorendorff, 10/5/2010

I am also getting these failures:

7353 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/layout/base/test/chrome/test_printpreview.xul | Timers should have run! - didn't expect "0 timers", but got it
7354 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/layout/base/test/chrome/test_printpreview.xul | Timers should have run! - didn't expect 0, but got it

Browserchrome

Failures:

chrome://mochikit/content/browser/toolkit/components/console/hudservice/tests/browser/browser_webconsole_netlogging.js
chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_461743.js
chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowser_newwindow_stopcmd.js
chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_forgetthissite.js
chrome://mochikit/content/browser/browser/components/preferences/tests/browser/browser_privacypane_1.js
chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js
chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_library_middleclick.js

make check

Passes

make jstestbrowser (jsreftest)

We're seeing this consistently on debug builds on try.

TEST-UNEXPECTED-FAIL | js1_8/regress/regress-464418.js | application timed out after 330 seconds with no output