User:GavinSharp/Code Review: Difference between revisions

(Created page with "=Effective Code Review= ==Preliminary questions== Things to ask yourself when you receive a review request. * am I the best person to review this? ** is someone else better suit...")
 
Line 42: Line 42:
** bring in domain experts when there's any doubt at all
** bring in domain experts when there's any doubt at all


==Overall==
==Key Points==
* don't be reluctant to redirect requests, or ask for additional help
* don't be reluctant to redirect requests, or ask for additional help
* be friendly; particularly for first-time or infrequent contributors (doesn't always come naturally!)
* be friendly; particularly for first-time or infrequent contributors (doesn't always come naturally!)
Confirmed users, Bureaucrats and Sysops emeriti
722

edits