AMO:Editors/EditorGuide/AddonReviews: Difference between revisions

AMO:Editors/EditorGuide/AddonReviews (view source)

Revision as of 10:02, 8 February 2012

151 bytes added , 8 February 2012

m

added info about checking for zombie compartments in chrome

One

Confirmed users

206

edits

@@ Line 378: / Line 378: @@
 | style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" |
 |- style="vertical-align: top;" id="leaks"
-| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Memory leaks from content
+| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Memory leaks from content or chrome
 | style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Preliminary Review
-| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | If an add-on touches the content in any way, we need to test the add-on on a page where it works, close the page, and then look in about:memory. Remaining compartments related to the page indicate a memory leak. More details [https://developer.mozilla.org/en/Extensions/Performance_best_practices_in_extensions#Avoid_Creating_Memory_Leaks here] and
+| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | If an add-on touches the content in any way, we need to test the add-on on a page where it works, close the page, and then look in about:memory?verbose. Remaining compartments related to the page indicate a memory leak. After disabling the add-on (and minimizing memory usage) the add-on should no longer use any memory. If it does, it leaks to chrome. More details [https://developer.mozilla.org/en/Extensions/Performance_best_practices_in_extensions#Avoid_Creating_Memory_Leaks here] and
 [https://developer.mozilla.org/en/Zombie_Compartments#Proactive_checking_of_add-ons here].
 |- style="vertical-align: top;" id="affiliate"