Confirmed users
9,511
edits
Web Testing/Automation/CodeReviewProcess: Difference between revisions
Web Testing/Automation/CodeReviewProcess (view source)
Revision as of 05:54, 29 March 2012
, 29 March 2012→How to do a merge?
| Line 64: | Line 64: | ||
If the pull request contains changes in the private files update or ask someone to update the private files | If the pull request contains changes in the private files update or ask someone to update the private files | ||
*Ex: Update the ''webqa-credentials.yml'' if there are changes in this file | *Ex: Update the ''webqa-credentials.yml'' if there are changes in this file | ||
'''IMPORTANT:''' Post-merge, stick around to ensure that subsequent build is green, or at least adds no new failures | |||
== Who can do merges? == | == Who can do merges? == | ||
* '''For starters, you *cannot* merge-in your own code/pull requests''' | * '''For starters, you *cannot* merge-in your own code/pull requests''' | ||
* Anyone who has tested the patch (and made sure it's had two reviews) | * Anyone who has tested the patch (and made sure it's had two reviews) | ||