AMO:Editors/EditorGuide/CommonThemeProblems: Difference between revisions

no edit summary
No edit summary
Line 13: Line 13:
<br>http://forums.mozillazine.org/viewtopic.php?f=18&t=2131121
<br>http://forums.mozillazine.org/viewtopic.php?f=18&t=2131121
<br>http://forums.mozillazine.org/viewtopic.php?f=18&t=1953371&start=60
<br>http://forums.mozillazine.org/viewtopic.php?f=18&t=1953371&start=60
====Firefox not going into full screen mode properly on Win7 Aero====
====Win7 Aero not going into full screen mode properly====
On Win7 with Aero Glass support Firefox doesn't always go to full screen mode from a normal window properly. The resolution to this issue is to add the following code to your browser.css file somewhere below where the main-window is made transparent to support Aero glass.
On Win7 with Aero Glass support Firefox doesn't always go to full screen mode from a normal window properly. The resolution to this issue is to add the following code to your browser.css file somewhere below where the main-window is made transparent to support Aero glass.
<br>---
<br>---
Line 26: Line 26:
<br>For more information about this issue please see https://bugzilla.mozilla.org/show_bug.cgi?id=732757 and http://forums.mozillazine.org/viewtopic.php?f=18&t=2438459.
<br>For more information about this issue please see https://bugzilla.mozilla.org/show_bug.cgi?id=732757 and http://forums.mozillazine.org/viewtopic.php?f=18&t=2438459.
===OS X===
===OS X===
====OS X Lion toolbar button icons are missing====
====OS X Lion missing toolbar button icons====
Due to Firefox bugs 679708 (https://bugzilla.mozilla.org/show_bug.cgi?id=679708) and 702558 (https://bugzilla.mozilla.org/show_bug.cgi?id=702558), it appears that your toolbar buttons may be broken on FF8+ running on Mac OS-X Lion. In order to work around this issue, you need to either rename any of the following files that are in your chrome://browser/skin/ folder and fix any references to those files, or copy them to the folder chrome://browser/skin/lion/:
Due to Firefox bugs 679708 (https://bugzilla.mozilla.org/show_bug.cgi?id=679708) and 702558 (https://bugzilla.mozilla.org/show_bug.cgi?id=702558), it appears that your toolbar buttons may be broken on FF8+ running on Mac OS-X Lion. In order to work around this issue, you need to either rename any of the following files that are in your chrome://browser/skin/ folder and fix any references to those files, or copy them to the folder chrome://browser/skin/lion/:
<br>&nbsp;&nbsp;&#42; keyhole-circle.png
<br>&nbsp;&nbsp;&#42; keyhole-circle.png
Line 35: Line 35:
<br>&nbsp;&nbsp;&#42; places/toolbar.png
<br>&nbsp;&nbsp;&#42; places/toolbar.png
===Linux===
===Linux===
====Linux drop down select box fields are showing both drop arrow and spinner arrows====
====Linux select box showing both drop arrow and spinner arrows====
On Linux: The styling of drop down select box fields are showing both a drop arrow and up/down spinner arrows.&nbsp;&nbsp;The problem is commonly caused by a "-moz-appearance:menulist" style rule in chrome://global/skin/menulist.css. Once the offending rule is found, it should be deleted and manual styling used.
On Linux: The styling of drop down select box fields are showing both a drop arrow and up/down spinner arrows.&nbsp;&nbsp;The problem is commonly caused by a "-moz-appearance:menulist" style rule in chrome://global/skin/menulist.css. Once the offending rule is found, it should be deleted and manual styling used.
====Firefox app button not styled on Linux, but is styled on Windows====
====Firefox app button not styled on Linux, but is styled on Windows====
Line 41: Line 41:
==Toolbars and Menus==
==Toolbars and Menus==
===Firefox App Button===
===Firefox App Button===
====App button doesn't change styling for private browsing mode====
====Firefox app button doesn't change styling for private browsing mode====
When in private browsing mode there is no visual difference to the Firefox app button that is displayed when tabs are on top and the menu bar is disabled.
When in private browsing mode there is no visual difference to the Firefox app button that is displayed when tabs are on top and the menu bar is disabled.
====Text only toolbar buttons not aligned properly====
====Text only toolbar buttons not aligned properly====
When text only toolbar buttons are selected in customize toolbars, text labels in toolbar buttons are not aligning properly. The common cause of this is style rules that reference [iconsize="small"] without excluding [mode="text"]. The solution usually is to append :not ([mode="text"]) to those style rules. For instance use 'toolbar[iconsize="small"]:not ([mode="text"])'. A little experimenting may be required to fully address this issue with your theme.
When text only toolbar buttons are selected in customize toolbars, text labels in toolbar buttons are not aligning properly. The common cause of this is style rules that reference [iconsize="small"] without excluding [mode="text"]. The solution usually is to append :not ([mode="text"]) to those style rules. For instance use 'toolbar[iconsize="small"]:not ([mode="text"])'. A little experimenting may be required to fully address this issue with your theme.
===Address Bar===
===Address Bar===
====The identity box is missing padlock icons for secure sites====
====Identity box is missing padlock icons for secure sites====
In FF14+ the identity box has been significantly changed and the favicon has been replaced by an icon that indicates the website's status. In the case of secure sites the icon MUST be a padlock. For more information please see: https://wiki.mozilla.org/AMO:Editors/EditorGuide/ThemeReviews#Identity_Boxes
In FF14+ the identity box has been significantly changed and the favicon has been replaced by an icon that indicates the website's status. In the case of secure sites the icon MUST be a padlock. For more information please see: https://wiki.mozilla.org/AMO:Editors/EditorGuide/ThemeReviews#Identity_Boxes
====No visual clue for disabled url bars====
====No visual clue for disabled url bars====
There needs to be a visual clue when URL bar is disabled. To test this please go to https://bug486395.bugzilla.mozilla.org/attachment.cgi?id=370495 using the default theme and activate the "click me" link. The URL bar of the resulting popup window is disabled.
There needs to be a visual clue when URL bar is disabled. To test this please go to https://bug486395.bugzilla.mozilla.org/attachment.cgi?id=370495 using the default theme and activate the "click me" link. The URL bar of the resulting popup window is disabled.
===Address Bar "Door Hangers"===
===Address Bar "Door Hangers"===
====Sync panel on door hangers not styled====
====Door hanger sync panel is not styled====
The sync panel at the bottom of the "door hanger" for the save password panel displayed when a user logs into a website needs to be styled to match rest of panel including border. This issue also applies to the edit bookmark panel, which is activated by double clicking on the bookmark star in the URL bar. For details, please see https://bugzilla.mozilla.org/show_bug.cgi?id=708797
The sync panel at the bottom of the "door hanger" for the save password panel displayed when a user logs into a website needs to be styled to match rest of panel including border. This issue also applies to the edit bookmark panel, which is activated by double clicking on the bookmark star in the URL bar. For details, please see https://bugzilla.mozilla.org/show_bug.cgi?id=708797
=="About" Pages==
=="About" Pages==
===About:addons===
===About:addons===
====Icons for disabled add-ons need to be grey scale====
====Disabled add-on icons are not grey scale====
In Tools &gt; Add-ons, the icons of disabled icons need to be converted to grey scale. To accomplish this you need to add the following style rule to the css file extensions.css:
In Tools &gt; Add-ons, the icons of disabled icons need to be converted to grey scale. To accomplish this you need to add the following style rule to the css file extensions.css:
<br>---
<br>---
Line 64: Line 64:
<br>---
<br>---
===About:memory===
===About:memory===
====About:memory does not collapse correctly====
====About:memory does not collapse====
The styling of about:memory is a little messed up in that nodes do not collapse as they should when clicked on. To fix this issue you need to copy the following file from the latest version of Firefox to your theme: chrome://global/content/aboutMemory.css
The styling of about:memory is a little messed up in that nodes do not collapse as they should when clicked on. To fix this issue you need to copy the following file from the latest version of Firefox to your theme: chrome://global/content/aboutMemory.css
===About:permissions===
===About:permissions===
Line 81: Line 81:
{to be added}
{to be added}
===Web Console===
===Web Console===
====Toggle buttons on web console do not change appearance====
====Web console  buttons do not change appearance====
On the web console (Tools &gt; Web Developer &gt; Web Console), the toolbar buttons on the left-hand side do not change their appearance between their toggled on and toggled off status as a result it is not possible to determine which buttons are enabled.
On the web console (Tools &gt; Web Developer &gt; Web Console), the toolbar buttons on the left-hand side do not change their appearance between their toggled on and toggled off status as a result it is not possible to determine which buttons are enabled.
====Web console close button is missing====
====Web console close button is missing====
Line 88: Line 88:
On the web console (Tools &gt; Web Developer &gt; Web Console) the sprite mapping for the close button is messed up.
On the web console (Tools &gt; Web Developer &gt; Web Console) the sprite mapping for the close button is messed up.
===Style Inspector===
===Style Inspector===
====The style inspector is completely unstyled====
====Style inspector is completely unstyled====
The style inspector that is part of FF10.0+ needs to be styled. Using the default theme in the latest Firefox, please try Tools &gt; Web Developer &gt; Inspect to see how this new feature functions and how it should be styled. You'll probably want to copy the files from the folder "browser/devtools/" from the default theme into your theme and then modify as necessary to achieve the desired look.
The style inspector that is part of FF10.0+ needs to be styled. Using the default theme in the latest Firefox, please try Tools &gt; Web Developer &gt; Inspect to see how this new feature functions and how it should be styled. You'll probably want to copy the files from the folder "browser/devtools/" from the default theme into your theme and then modify as necessary to achieve the desired look.
====The style inspector's bread crumb buttons are hard to read====
====Style inspector's bread crumb buttons are hard to read====
The text labels of breadcrumbs on the style inspector (Tools &gt; Web Developer &gt; Inspect) are too similar to the background colors making them very hard to read. Please choose text label colors that stand out against the background color better. The style rules for these labels can be found near the end of chrome://browser/skin/browser.css. The color style for the follow statements need to be adjusted:
The text labels of breadcrumbs on the style inspector (Tools &gt; Web Developer &gt; Inspect) are too similar to the background colors making them very hard to read. Please choose text label colors that stand out against the background color better. The style rules for these labels can be found near the end of chrome://browser/skin/browser.css. The color style for the follow statements need to be adjusted:
<br>---
<br>---
Line 102: Line 102:
<br>&nbsp;&nbsp;.inspector-breadcrumbs-classes {
<br>&nbsp;&nbsp;.inspector-breadcrumbs-classes {
<br>---
<br>---
====The style inspector breadcrumb button backgrounds are not consistent between pre-FF14 and FF14+====
====Style inspector breadcrumb button backgrounds are not consistent between pre-FF14 and FF14+====
The use of the styling rule "fill" in -moz-border-image is incompatible with versions of Firefox older than FF14, however, its use is needed for FF14+. Themes that use -moz-border-image and support both FF14+ and older versions of Firefox need to use both the older and newer methodologies like the following example.&nbsp;&nbsp;In most themes this issue specifically affects the breadcrumbs toolbar of the style inspector.
The use of the styling rule "fill" in -moz-border-image is incompatible with versions of Firefox older than FF14, however, its use is needed for FF14+. Themes that use -moz-border-image and support both FF14+ and older versions of Firefox need to use both the older and newer methodologies like the following example.&nbsp;&nbsp;In most themes this issue specifically affects the breadcrumbs toolbar of the style inspector.
<br>---
<br>---
Line 131: Line 131:
<br>&nbsp;&nbsp;.muteButton[muted="true"] {...}
<br>&nbsp;&nbsp;.muteButton[muted="true"] {...}
<br>---
<br>---
====Unknown namespace for videocontrols.css====
==Error Console Warnings==
===Unknown namespace for videocontrols.css===
The error console is reporting the following issue:
The error console is reporting the following issue:
<br> ----------
<br> ----------
Line 142: Line 143:
<br>---
<br>---
<br>You can generate the error console message by going to https://www.mozilla.org/mission/. If you are using the extension Console² (https://addons.mozilla.org/en-US/firefox/addon/console²) you can easily filter out content related messages to see just chrome issues.
<br>You can generate the error console message by going to https://www.mozilla.org/mission/. If you are using the extension Console² (https://addons.mozilla.org/en-US/firefox/addon/console²) you can easily filter out content related messages to see just chrome issues.
==Error Console Warnings==
===Warning: Unknown Property (Obsolete CSS Rules)===
===Obsolete CSS Rules===
====-moz-border-radius====
====Warning: Unknown property '-moz-border-radius'. Declaration dropped====
Firefox no longer supports -moz-border-radius style properties. Use CSS standard border-radius properties instead (supported by Firefox since FF4.0). See: https://developer.mozilla.org/en/CSS/border-radius
Firefox no longer supports -moz-border-radius style properties. Use CSS standard border-radius properties instead (supported by Firefox since FF4.0). See: https://developer.mozilla.org/en/CSS/border-radius
====Warning: Unknown property '-moz-box-shadow'. Declaration dropped====
====-moz-box-shadow====
Firefox no longer supports -moz-box-shadow style property. Use CSS standard box-shadow property instead (supported by Firefox since FF4.0). See: https://developer.mozilla.org/en/CSS/box-shadow
Firefox no longer supports -moz-box-shadow style property. Use CSS standard box-shadow property instead (supported by Firefox since FF4.0). See: https://developer.mozilla.org/en/CSS/box-shadow
====Warning: Unknown property '-moz-transition'. Declaration dropped.====
====-moz-transition====
Firefox no longer supports -moz-transition style property. Use CSS standard transition property instead (supported by Firefox since FF4.0). See: https://developer.mozilla.org/en/CSS/transition
Firefox no longer supports -moz-transition style property. Use CSS standard transition property instead (supported by Firefox since FF4.0). See: https://developer.mozilla.org/en/CSS/transition


Confirmed users
116

edits