|
|
| Line 1: |
Line 1: |
| = Overview =
| | Moved over to https://github.com/mozilla/addon-sdk/wiki/contribute |
| | |
| * Changes should follow the [[Labs/Jetpack/Design_Guidelines|design guidelines]] for Jetpack
| |
| * All changes must be accompanied by tests
| |
| * In order to land, patches must have review from a core Jetpack developer
| |
| * Patches should have additional API review when needed
| |
| * Patches should have additional review from a Mozilla platform domain-expert when needed
| |
| | |
| If you have questions, ask in [irc://irc.mozilla.org/#jetpack #jetpack on IRC] or on the [http://groups.google.com/group/mozilla-labs-jetpack Jetpack mailing list].
| |
| | |
| = How to Make Code Contributions =
| |
| | |
| If you have code that you'd like to contribute the Jetpack project, follow these steps:
| |
| | |
| # Look for your issue in the [https://bugzilla.mozilla.org/buglist.cgi?quicksearch=product%3ASDK bugs already filed]
| |
| # If no bug exists, [https://bugzilla.mozilla.org/enter_bug.cgi?product=Add-on%20SDK&component=general file one here]
| |
| # Make your changes, per the [[Labs/Jetpack/Contribution#Overview|Overview]]
| |
| # Write a test ([https://jetpack.mozillalabs.com/sdk/latest/docs/#guide/implementing-reusable-module intro], [https://jetpack.mozillalabs.com/sdk/latest/docs/#module/api-utils/unit-test API])
| |
| # Attach your code changes and tests in a combined patch to the bug
| |
| # Ask for code review by setting one or more "review" flags on your attachment to "?" and entering the email of the appropriate developer (noted in [[Labs/Jetpack/Contribution#Reviewers|Reviewers]] below)
| |
| | |
| = Reviewers =
| |
| | |
| * All changes must be reviewed by someone on the Jetpack review crew:
| |
| ** Alex (apoirot@mozilla.com, in bugzilla: poirot.alex@gmail.com)
| |
| ** Brian (warner@mozilla.com, in bugzilla: warner-bugzilla@lothar.com)
| |
| ** Dave Mason (dcm@mozilla.com)
| |
| ** Dave Townsend (mossop@mozilla.com, in bugzilla: dtownsend+bugmail@oxymoronical.com)
| |
| ** Dietrich (dietrich@mozilla.com)
| |
| ** Drew (adw@mozilla.com)
| |
| ** Irakli (gozala@mozilla.com, in bugzilla: rFobic@gmail.com)
| |
| ** Mark (mhammond@mozilla.com, in bugzilla: mhammond@skippinet.com.au)
| |
| ** Myk (myk@mozilla.org)
| |
| ** Will (wbamberg@mozilla.com)
| |
| * For review of Mozilla platform usage and best practices, ask Dietrich, Drew, or Dave Townsend to find the domain expert.
| |
| * For API and developer ergonomics review, ask Irakli.
| |