Gaia/UX Branch/Maintenance: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
(→‎Process: Add relevant link)
Line 28: Line 28:
== Patching ==
== Patching ==


To keep commit history clean, sometimes it makes sense to use git patch instead of merging a pull request.
To keep commit history clean, sometimes it makes sense to use git patch instead of merging a pull request. When patching, use git am to preserve the original commit details.
 
When patching, use this format:
 
    Bug 123456 - Apply patch from f4fdd305b24ac62248f28ee7cebde966f4f3d804
   
    From f4fdd305b24ac62248f28ee7cebde966f4f3d804 Mon Sep 17 00:00:00 2001
    From: Joe Schmo <jschmo@hotmail.com>
    Date: Thu, 29 Nov 2012 12:45:52 -0500
    Subject: [PATCH] Bug 813140 - Contacts iconography fix for contact
    details screen
   
    Bug 813140 - Contacts iconography fix for contact details screen
   
    This change fixes Bug 813140: [Gaia::Contacts] Contact Details page not
    using the latest iconography from Visual Design.


== Bugzilla ==
== Bugzilla ==

Revision as of 19:17, 11 December 2012

Pull Requests

Merged with master:

  • ux-2012-11-29-cherry-picked
  • ux-2012-11-22-cherry-picked

Process

  • Update the UX Branch Daily by fetching and merging from upstream/master
  • Review pull requests 2-3 times a week
    • Check bug in Bugzilla.
    • Priority is given to commits that address bugs in: http://bit.ly/TE1jzg
    • Add Status Whiteboard "uxbranch" (if it doesn't have the tag already)
    • Only one commit per fix!
    • Make sure commit message is in correct format and has a bug number. If commit message is incorrect, we must make sure to fix it when we cherry-pick the commit at the end of the week (see below). If necessary, apply as patch and fix commit message.
    • Review patch, understand risk-level of patch
    • Apply patch locally and test on-device
    • If all is OK, merge pull request.
    • Add Status Whiteboard "landed in uxbranch"
  • Create a pull request for landed, qa-verified bugs every week.
    • Cherry pick commits verified by QA and merged into UX, but not yet in master. Prefer cherry-picking the original commit instead of the merge commit.
    • Issue pull request.
    • Include links to bugs in pull request message.

Note: you can get the original commit for a merge by clicking on the right-hand parent commit.

Patching

To keep commit history clean, sometimes it makes sense to use git patch instead of merging a pull request. When patching, use git am to preserve the original commit details.

Bugzilla