Gaia/SMS/Scrum/2

List of bugs

http://mzl.la/1lMrWiE: SMS issues handled by the SMS subteam (blocks the sprint bug 1015843)

Full Query

ID	Assigned to	Summary	Blocking b2g	Whiteboard	Resolution
963013	Oleg Zasypkin [:azasypkin]	[Messages][Refresh] Update bubbles style and layout of the thread.	---	[p=1]	FIXED
963109	Steve Chung [:steveck]	[Messages] Multi-recipient participants view should show back button instead of cross one	---	[p=1][not-part-of-initial-sprint]	FIXED
990537	Julien Wajsberg [:julienw]	[DSDS] Messaging. Apply Visual Refresh to DSDS scenarios.	---	[p=2]	FIXED
1003820	Steve Chung [:steveck]	[Messages] Recipients container grows without limit breaking the layout	2.0+	[p=1]	FIXED
1008127	Pavel Ivanov [:ivanovpavel][:pivanov] UX	[Messages][Refresh] Subject handling in the Composer	---	[sprint2 p=3][sprint3 p=2][not-part-of-initial-sprint]	FIXED
1008890	Oleg Zasypkin [:azasypkin]	[Messages] Thread carrier header isn't localized correctly right after language switch	---	[p=1][not-part-of-initial-sprint]	FIXED
1010093	Steve Chung [:steveck]	[Message] Visual refresh for delivery/read report icon in thread view	---	[p=1]	FIXED
1011654	Oleg Zasypkin [:azasypkin]	[B2G][SMS]Opening the messages app after sending a message from the Call log causes the sent notification sound to occur a second time	1.4+	[p=1]	FIXED
1013295	Oleg Zasypkin [:azasypkin]	[Messages] Migrated messages don't have a proper sentTimestamp	1.4+	[p=1]	FIXED
1015867	Julien Wajsberg [:julienw]	[Messages] The editable composer should take more space	2.0+	[sprint2 p=2][sprint3 p=1]	FIXED
1017018	Oleg Zasypkin [:azasypkin]	[Messages] Bug 963018 regresses the localizability of the "To:" string in the recipient panel	2.0+	[p=1][not-part-of-initial-sprint]	FIXED

11 Total; 11 Open (100%); 0 Resolved (0%); 0 Verified (0%);

Remaining points

	Remaining points
Start	12
Day 2	12
Day 3	11
Day 4
Day 5
Day 6
Day 7
Day 8
Day 9
Day 10
End

http://mzl.la/1hpuoKO: All SMS issues tracked for this sprint (target milestone)

Full Query

ID	Assigned to	Summary	Blocking b2g	Resolution
951682		[meta][Messages][Refresh] Composer. Update layout and styles.	---	FIXED
963013	Oleg Zasypkin [:azasypkin]	[Messages][Refresh] Update bubbles style and layout of the thread.	---	FIXED
963018	Joan Leon [:joan]	[Messages][Refresh] Update styles of the Composer	---	FIXED
963109	Steve Chung [:steveck]	[Messages] Multi-recipient participants view should show back button instead of cross one	---	FIXED
1003820	Steve Chung [:steveck]	[Messages] Recipients container grows without limit breaking the layout	2.0+	FIXED
1007591	Marina Rodríguez [:mai]	[SMS] Make SMS react upon the IAC broadcast from Cost Control application to friendly mute Cost Control specific SMS	---	FIXED
1008890	Oleg Zasypkin [:azasypkin]	[Messages] Thread carrier header isn't localized correctly right after language switch	---	FIXED
1010093	Steve Chung [:steveck]	[Message] Visual refresh for delivery/read report icon in thread view	---	FIXED
1010690	Steve Chung [:steveck]	[Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground	1.3T+	FIXED
1011654	Oleg Zasypkin [:azasypkin]	[B2G][SMS]Opening the messages app after sending a message from the Call log causes the sent notification sound to occur a second time	1.4+	FIXED
1013295	Oleg Zasypkin [:azasypkin]	[Messages] Migrated messages don't have a proper sentTimestamp	1.4+	FIXED
1014178	Doug Sherk (:drs) (inactive)	[Visual Refresh][Messages] Thread messages view contains last-child selectors and is slightly misaligned	---	FIXED
1016541	Paco Rampas [:paco]	Thread and Composer. The input placeholder text (Message) should be italic	---	FIXED
1017018	Oleg Zasypkin [:azasypkin]	[Messages] Bug 963018 regresses the localizability of the "To:" string in the recipient panel	2.0+	FIXED
1017024	Julien Wajsberg [:julienw]	[Messages] Bug 963018 change panel's default height and leads the notification mispositioned	2.0+	FIXED

15 Total; 15 Open (100%); 0 Resolved (0%); 0 Verified (0%);

Sprint planning

Minutes are on a separate page.

Daily meetings

Day 2: May, 27th

Steve

• Just finish bunch of reviews 1st round
• Bug 1010093 [Message] Visual refresh for delivery/read report icon in thread view:
  • Vicky granted the latest image assets changes, so I'll update the images with some JS changes later
• Bug 1003820 [Messages] Recipients container grows without limit breaking the layout
  • Will fire another patch for ui-review

Julien

• I updated the Scrum pages
• I tried to reproduce Bug 1010690 (v1.3t, the notification is not played when reading a Video or playing a Music), but still couldn't; I'll try once again today with the files they used
• I have all information for bug 1015867 (max-height for the composer from Victoria) so I'll be able to start working on it (but I'd like to land the refresh for the composer and thread panels first)
• I moved forward on the Simulator branch that I started some weeks ago: https://github.com/julienw/gaia/compare/sms-simulator, one goal is to make it easier to hack the application in DSDS mode. But the style is strange right now, especially compared to running the app without the simulator.
• Today: I definitely want to do all pending reviews, so I won't probably do much real code.

Oleg

• Fixed nits for v1.4 blockers bug 1011654 (duplicated sent audio) and bug 1013295 (invalid sentTimestamp) + rebased it on current master and asked for review;
• Fixed comments that Julien left in Joan's patch for bug 963013 (update message bubble styles), testing it right now, trying to improve it a bit and will ask for review today. \o/
• Also asked Victoria what to do with long MMS subject (currently it's wrapped into two lines, but in Joan's patch ellipsis is used).

Today: will finish with patch for bug 963013 (update message bubble styles) + work on review comments for v1.4 blockers if any + will look into what I can pick up next.

Day 3: May, 28th

Steve

• Bug 1010093 [Message] Visual refresh for delivery/read report icon in thread view
  • Patch given for review
• Bug 1003820 [Messages] Recipients container grows without limit breaking the layout
  • Update the patch for ui-review again
• Bug 963109 - [Messages] Multi-recipient participants view should show back button instead of cross one
  • Just start to work
• Code reviews: Bug 1011654/Bug 1013295 from Oleg and bug 1014178 from Doug

Julien

• Bug 1010690 (v1.3t, the notification is not played when reading a Video or playing a Music)
  • still tried to reproduce this; found another issue in the process (bug 1016829: can't retrieve a MMS for SIM2)in old version v1.3t only, yes
  • still I don't reproduce :(
• Simulator branch
  • I understood why I get a strange layout: there are scrollbars painted everywhere while they're hidden in the responsive mode. I still don't know why we have scrollbars, maybe we removed some overflow: hidden in the composer patch...
• bug 963018: visual refresh for the composer
  • will land after the meeting (but not in the sprint ;) )
• bug 1015867: max-height for the composer
  • didn't have the time to work on this properly but I shared screenshots
• bug 974867: send email from MMS:
  • reviewed again, patch was really better

Today: more reviews, hope to start working on bug 1015867

Tomorrow, friday: I'm absent

Oleg

• Bug 1011654 - [B2G][SMS]Opening the messages app after sending a message from the Call log causes the sent notification sound to occur a second time;
  • Added tests for MessageManager.resendMessage, Steve found out that we didn't have any :)
  • v1.4 patch is reviewed, for master one I'm waiting for green Travis.
• Bug 1013295 - [Messages] Migrated messages don't have a proper sentTimestamp
  • Review nits fixed, master patch is landed, for v1.4 patch I'm waiting for green travis

\o/

• Bug 963013 - [Messages][Refresh] Update bubbles style and layout of the thread.
  • Got a bunch of new feedback from Victoria for the message bubble styles;
  • Also Victoria provided us with the new spec for carrier header(colors, size, alignments), that I'm going to implement today.
• Bug 1010093 - [Message] Visual refresh for delivery/read report icon in thread view
  • Reviewing

Today: will work on new carrier header for VR + review Bug 1010093 - [Message] Visual refresh for delivery/read report icon in thread view.

Day 4: May, 29th

Steve

• bug 1010093 [Message] Visual refresh for delivery/read report icon in thread view
  • Patch landed
• bug 1003820 [Messages] Recipients container grows without limit breaking the layout
  • Still waiting for ui-review again
• bug 963109 - [Messages] Multi-recipient participants view should show back button instead of cross one
  • Patch given but declined. Need to update for another review
• bug 1009098 - [Messages] The "composer" is displayed in the "edit" mode
  • Just start to work
• Clean code reviews: bug 1014178 from Doug and bug 963043 from julien
• [other]
• Some discussion with bug 829820 - Ability to mark selected SMS threads as read
  • There are many feature/recatoring mentioned in the bug. We might need to create a separate bugs for it.
  • Have some discussion with UX about the spec.

Oleg

• bug 1011654 - [B2G][SMS]Opening the messages app after sending a message from the Call log causes the sent notification sound to occur a second time;
  • Both v1.4 and master patches landed.
• bug 1013295 - [Messages] Migrated messages don't have a proper sentTimestamp
  • Both v1.4 and master patches landed. Will add related example to our Demo page.
• bug 963013 - [Messages][Refresh] Update bubbles style and layout of the thread.
  • Made quite big refactoring of message bubble styles (partially to get rid of some magic);
  • Moved message bubble style to a separate file as 200+ related lines deserve its own file :)
  • Made several rebases as sms.css was updated;
  • Will separate carrier header today and ask for code review as it may take time due to refactoring (later today will prepare new screenshots for ui-review).
• bug 1010093 - [Message] Visual refresh for delivery/read report icon in thread view
  • Reviewed.
• bug 990518 - [Messaging][Visual Refresh] Keyboard suggestions should update messaging composer layout.
  • Would like to test our idea with SettingListener today.
• [other]

Today: will split carrier header in thread view to style it differently, add example to our Demo page regarding to landed "sentTimestamp" patch + will look into bug 990518.

Demos

Bug 963018: Composer Visual Refresh

This bug was not in the sprint but landed during the sprint.

• 

  Before

• 

  After

Bug 1010093: delivery/read icon update

• 

  Before

• 

  After

Bug 1013295: Migrated messages don't have a proper sentTimestamp

If we migrated message from old database where sentTimestamp hadn't been yet suported, we hide label with invalid timestamp.

• 

  Before

• 

  After