Gaia/SMS/Scrum/2: Difference between revisions
Jump to navigation
Jump to search
Full Query
Full Query
(→Demos) |
|||
| Line 344: | Line 344: | ||
</gallery> | </gallery> | ||
=== Bug 1010093: delivery/read icon update === | === {{Bug|1010093}}: delivery/read icon update === | ||
<gallery widths=320px heights=480px> | <gallery widths=320px heights=480px> | ||
File:2014-05-29-17-00-49.png|'''Before''' | File:2014-05-29-17-00-49.png|'''Before''' | ||
| Line 350: | Line 350: | ||
</gallery> | </gallery> | ||
=== Bug 1013295: Migrated messages don't have a proper sentTimestamp === | === {{Bug|1013295}}: Migrated messages don't have a proper sentTimestamp === | ||
If we migrated message from old database where sentTimestamp hadn't been yet suported, we hide label with invalid timestamp. | If we migrated message from old database where sentTimestamp hadn't been yet suported, we hide label with invalid timestamp. | ||
| Line 358: | Line 358: | ||
</gallery> | </gallery> | ||
=== | === {{Bug|1017018}}: {{Bug|963018}} regresses the localizability of the "To:" string in the recipient panel === | ||
Example for Hungarian language. | Example for Hungarian language. | ||
Revision as of 14:20, 4 June 2014
List of bugs
http://mzl.la/1lMrWiE: SMS issues handled by the SMS subteam (blocks the sprint bug 1015843)
11 Total; 11 Open (100%); 0 Resolved (0%); 0 Verified (0%);
Remaining points
| Remaining points | |
|---|---|
| Start | 12 |
| Day 2 | 12 |
| Day 3 | 11 |
| Day 4 | 9 |
| Day 5 | 9 |
| Day 6 | 9 |
| Day 7 | 9 |
| Day 8 | 9 |
| Day 9 | |
| Day 10 | |
| End |
http://mzl.la/1hpuoKO: All SMS issues tracked for this sprint (target milestone)
15 Total; 15 Open (100%); 0 Resolved (0%); 0 Verified (0%);
Sprint planning
Minutes are on a separate page.
Daily meetings
Day 2: May, 27th
Steve
- Just finish bunch of reviews 1st round
- Bug 1010093 [Message] Visual refresh for delivery/read report icon in thread view:
- Vicky granted the latest image assets changes, so I'll update the images with some JS changes later
- Bug 1003820 [Messages] Recipients container grows without limit breaking the layout
- Will fire another patch for ui-review
Julien
- I updated the Scrum pages
- I tried to reproduce Bug 1010690 (v1.3t, the notification is not played when reading a Video or playing a Music), but still couldn't; I'll try once again today with the files they used
- I have all information for bug 1015867 (max-height for the composer from Victoria) so I'll be able to start working on it (but I'd like to land the refresh for the composer and thread panels first)
- I moved forward on the Simulator branch that I started some weeks ago: https://github.com/julienw/gaia/compare/sms-simulator, one goal is to make it easier to hack the application in DSDS mode. But the style is strange right now, especially compared to running the app without the simulator.
- Today: I definitely want to do all pending reviews, so I won't probably do much real code.
Oleg
- Fixed nits for v1.4 blockers bug 1011654 (duplicated sent audio) and bug 1013295 (invalid sentTimestamp) + rebased it on current master and asked for review;
- Fixed comments that Julien left in Joan's patch for bug 963013 (update message bubble styles), testing it right now, trying to improve it a bit and will ask for review today. \o/
- Also asked Victoria what to do with long MMS subject (currently it's wrapped into two lines, but in Joan's patch ellipsis is used).
Today: will finish with patch for bug 963013 (update message bubble styles) + work on review comments for v1.4 blockers if any + will look into what I can pick up next.
Day 3: May, 28th
Steve
- Bug 1010093 [Message] Visual refresh for delivery/read report icon in thread view
- Patch given for review
- Bug 1003820 [Messages] Recipients container grows without limit breaking the layout
- Update the patch for ui-review again
- Bug 963109 - [Messages] Multi-recipient participants view should show back button instead of cross one
- Just start to work
- Code reviews: Bug 1011654/Bug 1013295 from Oleg and bug 1014178 from Doug
Julien
- Bug 1010690 (v1.3t, the notification is not played when reading a Video or playing a Music)
- still tried to reproduce this; found another issue in the process (bug 1016829: can't retrieve a MMS for SIM2)in old version v1.3t only, yes
- still I don't reproduce :(
- Simulator branch
- I understood why I get a strange layout: there are scrollbars painted everywhere while they're hidden in the responsive mode. I still don't know why we have scrollbars, maybe we removed some overflow: hidden in the composer patch...
- bug 963018: visual refresh for the composer
- will land after the meeting (but not in the sprint ;) )
- bug 1015867: max-height for the composer
- didn't have the time to work on this properly but I shared screenshots
- bug 974867: send email from MMS:
- reviewed again, patch was really better
Today: more reviews, hope to start working on bug 1015867
Tomorrow, friday: I'm absent
Oleg
- Bug 1011654 - [B2G][SMS]Opening the messages app after sending a message from the Call log causes the sent notification sound to occur a second time;
- Added tests for MessageManager.resendMessage, Steve found out that we didn't have any :)
- v1.4 patch is reviewed, for master one I'm waiting for green Travis.
- Bug 1013295 - [Messages] Migrated messages don't have a proper sentTimestamp
- Review nits fixed, master patch is landed, for v1.4 patch I'm waiting for green travis
- Bug 963013 - [Messages][Refresh] Update bubbles style and layout of the thread.
- Got a bunch of new feedback from Victoria for the message bubble styles;
- Also Victoria provided us with the new spec for carrier header(colors, size, alignments), that I'm going to implement today.
- Bug 1010093 - [Message] Visual refresh for delivery/read report icon in thread view
- Reviewing
Today: will work on new carrier header for VR + review Bug 1010093 - [Message] Visual refresh for delivery/read report icon in thread view.
Day 4: May, 29th
Steve
- bug 1010093 [Message] Visual refresh for delivery/read report icon in thread view
- Patch landed
- bug 1003820 [Messages] Recipients container grows without limit breaking the layout
- Still waiting for ui-review again
- bug 963109 - [Messages] Multi-recipient participants view should show back button instead of cross one
- Patch given but declined. Need to update for another review
- bug 1009098 - [Messages] The "composer" is displayed in the "edit" mode
- Just start to work
- Clean code reviews: bug 1014178 from Doug and bug 963043 from julien
- [other]
- Some discussion with bug 829820 - Ability to mark selected SMS threads as read
- There are many feature/recatoring mentioned in the bug. We might need to create a separate bugs for it.
- Have some discussion with UX about the spec.
Oleg
- bug 1011654 - [B2G][SMS]Opening the messages app after sending a message from the Call log causes the sent notification sound to occur a second time;
- Both v1.4 and master patches landed.
- bug 1013295 - [Messages] Migrated messages don't have a proper sentTimestamp
- Both v1.4 and master patches landed. Will add related example to our Demo page.
- bug 963013 - [Messages][Refresh] Update bubbles style and layout of the thread.
- Made quite big refactoring of message bubble styles (partially to get rid of some magic);
- Moved message bubble style to a separate file as 200+ related lines deserve its own file :)
- Made several rebases as sms.css was updated;
- Will separate carrier header today and ask for code review as it may take time due to refactoring (later today will prepare new screenshots for ui-review).
- bug 1010093 - [Message] Visual refresh for delivery/read report icon in thread view
- Reviewed.
- bug 990518 - [Messaging][Visual Refresh] Keyboard suggestions should update messaging composer layout.
- Would like to test our idea with SettingListener today.
- [other]
Today: will split carrier header in thread view to style it differently, add example to our Demo page regarding to landed "sentTimestamp" patch + will look into bug 990518.
Day 5: May, 30th
Steve
- bug 1003820 [Messages] Recipients container grows without limit breaking the layout
- ui-review granted
- bug 963109 - [Messages] Multi-recipient participants view should show back button instead of cross one
- Patch landed
- bug 1009098 - [Messages] The "composer" is displayed in the "edit" mode
- Reviewing
- Clean code reviews: bug 963013 from Oleg and bug 963043 from partner
- bug 1010690 - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground:
- Just flash the latest tarako. This intermittent issue seems like a LMK that cause notification sometimes could not show up.
Today: Finish all the ongoing blockers and clean the review queue.
Oleg
- bug 1013295 - [Messages] Migrated messages don't have a proper sentTimestamp
- Added related example to our Demo page.
- bug 963013 - [Messages][Refresh] Update bubbles style and layout of the thread.
- Added last suggestions from Victoria;
- Cleaned this up and asked for review.
- bug 1008890 - [Messages] Thread carrier header isn't localized correctly right after language switch
- Prepared patch for this (as it makes easier to customize carrier header for bug 963013) and asked for review.
- bug 963109 - [Messages] Multi-recipient participants view should show back button instead of cross one
- Reviewed.
- bug 1009098 - [Messages] The "composer" is displayed in the "edit" mode
- Reviewed.
Today: will handle review comments for bug 1008890 and bug 963013 + will look into other blocker.
Day 6: June, 2nd
Attending: Julien, Oleg
Julien
(updates for last wednesday)
- Bug 1010690 (v1.3t, the notification is not played when reading a Video or playing a Music)
- still couldn't reproduce... but I'm glad Steve found at least one issue !
- bug 963018: visual refresh for the composer
- landed ! Took more time than expected, we should probably have included it in the sprint.
- bug 1015867: max-height for the composer
- not started yet... definitely today as I want a first review if we want it to land this sprint. Same for Bug 990537 for DSDS refresh.
- bug 974867: send email from MMS:
- there is a new patch ready for review, will need to have a look today too
Today:
- definitely some patches for both my bugs (dsds refresh + composer height)
- some reviews, but I'll try to timebox this.
Other: I have some difficulties to find time to code during this sprint :(
Oleg
- Bug 963013 - [Messages][Refresh] Update bubbles style and layout of the thread.
- Found and fixed regression in my patch - as we didn't clean up various CSS classes when leaving view(like 'has-carrier'), carrier header was visible in composer. It wasn't visible previously because we were using crazy selectors like "[class="panel has-carrier"]" to show carrier header that obviously didn't match "class="panel has-carrier new"" :) I changed it to ".has-carrier .carrier-wrapper". So I'm removing this class in "afterLeave" now.
- Bug 1008890 - [Messages] Thread carrier header isn't localized correctly right after language switch
- Fixed review nits (in review).
- Bug 1010690 - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground
- Was investigating and wasn't able to reproduce with devices I had;
- Also reviewed Steve's hot-fix on this, left small comment about other possibly missed files that may be required in one or another case.
- Bug 1017018 - [Messages] Bug 963018 regresses the localizability of the "To:" string in the recipient panel
- Reason of regression is "word-wrap: unset" for content editable container that was previously inherited as "word-wrap: break-word". Trying to understand why we needed "unset" for ".recipient[contenteditable=true]:focus" rule.
- (JW) note: in one of the WIP patch, there was some "word-wrap: pre-wrap" that I asked to remove because nobody knew about it; could it be this?
- -> I'll check, but don't think so.
- (JW) how could word-wrap influence this?
- -> I suspect that it actually wrapping to new line, that is why you see cursor at the beginning, but still not sure. Am I fixing issue that you've meant? :) Let me try with jsfiddle
- -> Try this http://jsfiddle.net/ugyEQ/
- (follow-up on IRC)
On Friday realized that Thursday was holiday in Germany :) So, Friday was short day for me.
Today: will prepare patch for bug 1017018
Day 7: June, 3rd
Attending: Steve, Julien, Oleg
Steve
- Bug 1003820 [Messages] Recipients container grows without limit breaking the layout
- Patch updated
- Bug 1010690 - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground
- I could only discover utils.js is missing in sms receiving page. But intermittent notification missing issue might still exist after fixing the parsing issue.
- Bug 1009098 - [Messages] The "composer" is displayed in the "edit" mode
- Patch landed
- Clean code reviews: Bug 963013 discussion with Oleg
Today:
- Land Bug 1003820 & Bug 1010690(partly, will try to reproduce it after landing the patch)
- Start bug 1017024 [Messages] Bug 963018 change panel's default height and leads the notification mispositioned
Julien
So, no patch yet :(
- bug 1015867: max-height for the composer
- still not started yet...
- Bug 990537 for DSDS refresh.
- I have a working "simulator" now, so I'll start working on this now. The simulator helps me to simulate DSDS on Firefox without changing the code.
- see https://github.com/julienw/gaia/compare/sms-simulator
- bug 974867: send email from MMS:
- there is a new patch ready for review, will review today, didn't look yesterday
- bug 1007591: IAC communication between cost control and SMS, to silence some received SMS from the operator (TEF is doing this patch)
- reviewed it once again, it's moving forward, they want to land it this week too
Today:
- definitely some patches for both my bugs (dsds refresh + composer height) (again)
- some reviews, but I'll try to timebox this. (again)
Oleg
- Bug 963013 - [Messages][Refresh] Update bubbles style and layout of the thread.
- Discussed "ellipsis vs line wrap" for long subjects with Omega and Jenny and ..... "line wrap" won! So leaving it as it was before (+ adjusted line-height and paddings per Victoria suggestion) :)
- Received all u-review+ I asked (ui-review+, code review in progress)
- Bug 1008890 - [Messages] Thread carrier header isn't localized correctly right after language switch
- Got rid of template in favour of direct DOM manipulations as Steve suggested (in review).
- Bug 1017018 - [Messages] Bug 963018 regresses the localizability of the "To:" string in the recipient panel
- Fixed small nit suggested by Steve (reviewed, check-in needed);
- Discussed regression with "word-wrap" with Jenny and Omega - current behaviour looks better for them, so it's not regression anymore, but unexpected small improvement :)
- Bug 925404 - [B2G] [SMS] Always include the phone number in the SMS Thread UI, even if the carrier is known
- Discussed this bug (including Bug 883911 - [SMS][MMS] Update all occurrences of "Type ? Carrier ? Number" strings to same format) with Victoria, please see details in bug 925404 comment 38.
- Started looking into places that should be updated.
Today: will work on bug 925404 so that we can finish with this set of issues. Also will probably look into DSDS update for the "Send" button (just a part that is responsible for displaying a SIM number near the button) per Arnau request, don't have a bug number yet.
Day 8: June, 4th
Steve
- bug 1003820 [Messages] Recipients container grows without limit breaking the layout
- Patch updated again because of the recipient list VR(and small fixing for alignment)
- bug 1010690 - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground
- Land the patch for fixing utils missing issue, still need to verify after landing this patch
- bug 898364 - Moving conversation thread database from Gecko to Gaia by introducing DataStore API
- Join the DataStore discussion for general(mostly on contacts app) and for message future plaining.
- Reviewed bug 1008890 and bug 1005866
- Loop Client meeting
- Except for bug 895484(and it was landed), there should be no other feature for message app...
- 2.1 Planing: Nothing really needed/committed for message app. Maybe Hadification only?
- wap/broadcast message handling: It could be 2 parts, one is ability setting specific channel depends on country (should be settings/RIL work) and another one is storing these messages in db
Today:
- Fix bug 1017024 and take other blocker
- Finish review(at least for 1st round) for bug 963013
Julien
- bug 1015867: max-height for the composer
- calculated the formula I wanted to use (a * vh + b) so that it can adapt on all devices; pending Vicky approval (maybe she gave it during my night ;) I didn't check yet )
- once I get approcal it should be easy to do a patch
- bug 990537 for DSDS refresh.
- WIP patch, something is not clear to me about how it should look like with a subject
- WIP patch adds back the SIM number (removed by the flexible layout for composer patch) and the "..." (moved by a building block change)
- maybe good enough for now, because there is more work pending on this button ? /ping Oleg
-> You mean new icon and new sim number indicator (number only)? -> yes -> right -> the button and sim indicator is currntlly handled by a common object in /shared, common for dialer and SMS; you can ask Doug about it, he did it. But now we need to know if we have the same look&feel for Dialer than for SMS, especially regarding the SIM indication. -> Ah, didn't know that it's shared, ok will ask -> look for "multi_sim_action_button" or something in shared/js -> so maybe I'll just take my WIP patch and move it in another bug to just fix the regressions so that we can have a clean state? -> +1 -> ok, I'll do this
- bug 974867: send email from MMS: (from madai)
- could not review, there was 5 patches + 2 pull request, I didn't know what to look at... (and I wanted to make them learn)
- bug 1007591: IAC communication between cost control and SMS, to silence some received SMS from the operator (TEF is doing this patch)
- spent a lot of time on this yesterday, testing and explaining promises to Marina, and suggesting code, should be ready today or tomorrow
- bug 992473: use mutation observers to retranslate DOM nodes when the l10n-id changes
- slightly reviewed their approach, they contacted me during the night because SMS shows a wrong behavior with their patch, so I'll need to dig this out
Others:
- lots of new bugs by external testing, I had to triage them. Lots of them were invalid/duplicate :/
Today:
- I want the 2 patches ready
- wlll finish reviewing the 2 patches that are due for this week
- will try to review at least one older review request to decrease my number
Oleg
- bug 963013 - [Messages][Refresh] Update bubbles style and layout of the thread.
- Had a discussion with Steve on "sticky" header (for date groups) performance implications. Steve is going to check that during review :) (ui-review+, in code review)
- bug 1008890 - [Messages] Thread carrier header isn't localized correctly right after language switch
- Uplifted small fix for ".has-carrier" from the messages bubble patch as both patches simplify ".has-carrier" selectors that lead to problem I mentioned at previous stand-up (in review).
- bug 1017018 - [Messages] Bug 963018 regresses the localizability of the "To:" string in the recipient panel
- Landed
- bug 925404 - [B2G] [SMS] Always include the phone number in the SMS Thread UI, even if the carrier is known
- In progress, moved all manipulations with phone type\carrier separators from JS to mark-up (via data-l10n-Id attributes). Want to check if that would be convenient to move it to a single html template that can be reused for all cases.
- bug 898364 - Moving conversation thread database from Gecko to Gaia by introducing DataStore API
- There were two discussions on DS today, one general and one messages DS specific, tried to summarize it in etherpad: https://etherpad.mozilla.org/messages-datastore Thanks for summarizing it to etherpad!
Today: will continue to work on bug 898364, and will check how I can help with bug 1008127 - [Messages][Refresh] Subject handling in the Composer
Day 9: June, 5th
Day 10: June, 6th
Demos
Bug 963018: Composer Visual Refresh
This bug was not in the sprint but landed during the sprint.
Before
After
bug 1010093: delivery/read icon update
Before
After
bug 1013295: Migrated messages don't have a proper sentTimestamp
If we migrated message from old database where sentTimestamp hadn't been yet suported, we hide label with invalid timestamp.
Before
After
bug 1017018: bug 963018 regresses the localizability of the "To:" string in the recipient panel
Example for Hungarian language.
Before
After
