Gaia/SMS/Scrum/4: Difference between revisions

From MozillaWiki
< Gaia‎ | SMS‎ | Scrum
Jump to navigation Jump to search
Line 182: Line 182:
Today: will handle review comments for patches in review + going to look into next blocker we have "{{Bug|1022755}} - Possible race in the SMS navigation code"
Today: will handle review comments for patches in review + going to look into next blocker we have "{{Bug|1022755}} - Possible race in the SMS navigation code"
===Day 5: 30th June===
===Day 5: 30th June===
==== Steve ====
* {{Bug|1010690}} - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground
** Will verify with latest build with gecko patch {{Bug|1026737}} landed(didn't have time to do it last week...)
* {{Bug|1022644}} - [Messages] Can't open the recipient panel if there are only 2 lines of recipients
** r+, but v1.3t need another implementation. So I'll commit another patch for 1.3t.
* {{Bug|1021513}} -  [Messages] Recipients list container scroll up automatically when dragging down the container for multiline recipients list mode
** Landed on master
* bug reviewing:
** {{Bug|974867}} -  [MMS]Auto suggestion for email address: Conflicts fixed and need another review.
** {{Bug|1013296}} - Compose. Change send button to an paper plane icon: Landed.
** {{Bug|1026575}} -  [B2G][SMS] Message preview in Messages app thread view disappears after opening app: Some suggestion given, but the patch looks fine
** {{Bug|1008127}} - [Messages][Refresh] Subject handling in the Composer: Some feedback given, patch works great but it need to fix the conflicts.
Today:
* Try to clean(or reduce) the review queue. Hope I could have some time for partner's patch...
* Create v1.3t patch for {{Bug|1022644}}
==== Julien ====
Today: Reading up all my mails, and trying to keep up with what happened during my break :)
==== Oleg ====
* {{Bug|1008127}} - [Messages][Refresh] Subject handling in the Composer
** Updated JS part according to review comments (retrieving subject input line height with "getComputedStyle"). Asked Pavel to update his PR with my latest changes (in review).
* {{Bug|1026575}} -  [B2G][SMS] Message preview in Messages app thread view disappears after opening app
** Updated patch according to review comments (cleaning up ThreadUI.recipients in "afterLeave" if next view isn't Composer + unit test) (in review).
* {{Bug|1010690}} - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground
** Cleaned up ni?=me as it's waiting for verification from Spreadtrum QAs. Will look once again if they still have this issue (awaiting QA verification).
* {{Bug|1021513}} - [Messages] Recipients list container scroll up automatically when dragging down the container for multiline recipients list mode
** Reviewed, looks good, r+'d (landed).
* {{Bug|1022755}} - Possible race in the SMS navigation code
** Still looking into this (can be reproduced without reference workload, I can reproduce it with thread with two MMS if quickly press Back button). Navigation.slide code looks fine to me except of memory leak as we've never unsusbscribed from "transitionend" (tried to unsubscribed on the wrong element), so number of listeners is growing proportionally to number of navigation between panels (in progress).
Other:
** We have two new 2.0 blockers: {{Bug|1030160}} - [Messages][MMS] Subject is considered empty (placeholder is displayed) even if it has several empty lines (awating decision from UX) and {{Bug|1022575}} - Received SMS store (without text)  on check balance.
Today: will handle review comments for patches in review + investigate {{Bug|1022755}}
** (Julien) you need a gecko patch before {{Bug|1022755}}
** (Oleg) What Gecko patch?
** (Julien) sorry, mixed with {{Bug|1022575}} (same digits, different positions ;p)
===Day 6: 1st July===
===Day 6: 1st July===
===Day 7: 2nd July===
===Day 7: 2nd July===

Revision as of 08:13, 30 June 2014

List of bugs

SMS issues handled by the SMS subteam (blocks the sprint bug 1028276)

Bugzilla link

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Resolution
990537 Julien Wajsberg [:julienw] [DSDS] Messaging. Apply Visual Refresh to DSDS scenarios. --- No cf_feature-b2g [p=2] FIXED
1021513 Steve Chung [:steveck] [Messages] Recipients list container scroll up automatically when dragging down the container for multiline recipients list mode 2.0+ No cf_feature-b2g [p=1] FIXED
1022644 Steve Chung [:steveck] [Messages] Can't open the recipient panel if there are only 2 lines of recipients 1.3T+ No cf_feature-b2g [p=2] FIXED
1025552 Oleg Zasypkin [:azasypkin] [Messages][Refactoring] Refactor attachment.js and specifically move rendering part to a separate module --- No cf_feature-b2g [p=1] FIXED
1026575 Oleg Zasypkin [:azasypkin] [B2G][SMS] Message preview in Messages app thread view disappears after opening app 2.0+ No cf_feature-b2g [2.0-daily-testing][p=2] FIXED
1033260 Julien Wajsberg [:julienw] [Messages] Contact suggestion list didn't dismiss when focus on subject(for all branches) and message input field(1.3t only) --- No cf_feature-b2g [p=1] FIXED
1033403 Julien Wajsberg [:julienw] [Messages] We don't stop rendering if we tap "back" too soon --- No cf_feature-b2g [p=1] FIXED

7 Total; 7 Open (100%); 0 Resolved (0%); 0 Verified (0%);


Remaining points and burndown chart

google chart api url for Sprint 4

Burndown chart
Remaining points
Start 7
Day 2 7
Day 3 6
Day 4 6
Day 5
Day 6
Day 7
Day 8
Day 9
Day 10
End


SMS issues handled by the SMS subteam outside of the sprint (blocks the sprint bug 1028276 with whiteboard "not-part-of-initial-sprint")

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Resolution
1008127 Pavel Ivanov [:ivanovpavel][:pivanov] UX [Messages][Refresh] Subject handling in the Composer --- No cf_feature-b2g [sprint2 p=3][sprint3 p=2][not-part-of-initial-sprint] FIXED
1008912 Oleg Zasypkin [:azasypkin] 'MMS' in sms app doesn't translate into other language --- No cf_feature-b2g [sprd309681][not-part-of-initial-sprint] FIXED
1013296 Arnau March [:arnau] ( not working in Firefox OS anymore :( ) Compose. Change send button to an paper plane icon --- No cf_feature-b2g [p=1][not-part-of-initial-sprint] FIXED
1022755 Julien Wajsberg [:julienw] Possible race in the SMS navigation code 2.0+ No cf_feature-b2g [p=3][not-part-of-initial-sprint] FIXED
1030160 Steve Chung [:steveck] [Messages][MMS] Subject is considered empty (placeholder is displayed) even if it has several empty lines 2.0+ No cf_feature-b2g [not-part-of-initial-sprint] FIXED
1034637 Oleg Zasypkin [:azasypkin] [Messages] Utils.js unit tests are failing when run locally --- No cf_feature-b2g [not-part-of-initial-sprint] FIXED

6 Total; 6 Open (100%); 0 Resolved (0%); 0 Verified (0%);


All SMS issues tracked for this sprint (target milestone)

Bugzilla link

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Resolution
990537 Julien Wajsberg [:julienw] [DSDS] Messaging. Apply Visual Refresh to DSDS scenarios. --- 2.0 FIXED
1008127 Pavel Ivanov [:ivanovpavel][:pivanov] UX [Messages][Refresh] Subject handling in the Composer --- --- FIXED
1008912 Oleg Zasypkin [:azasypkin] 'MMS' in sms app doesn't translate into other language --- --- FIXED
1013296 Arnau March [:arnau] ( not working in Firefox OS anymore :( ) Compose. Change send button to an paper plane icon --- --- FIXED
1021513 Steve Chung [:steveck] [Messages] Recipients list container scroll up automatically when dragging down the container for multiline recipients list mode 2.0+ --- FIXED
1022644 Steve Chung [:steveck] [Messages] Can't open the recipient panel if there are only 2 lines of recipients 1.3T+ --- FIXED
1022755 Julien Wajsberg [:julienw] Possible race in the SMS navigation code 2.0+ --- FIXED
1025552 Oleg Zasypkin [:azasypkin] [Messages][Refactoring] Refactor attachment.js and specifically move rendering part to a separate module --- --- FIXED
1026575 Oleg Zasypkin [:azasypkin] [B2G][SMS] Message preview in Messages app thread view disappears after opening app 2.0+ --- FIXED
1030160 Steve Chung [:steveck] [Messages][MMS] Subject is considered empty (placeholder is displayed) even if it has several empty lines 2.0+ --- FIXED

10 Total; 10 Open (100%); 0 Resolved (0%); 0 Verified (0%);


Sprint planning

Minutes are on a separate page.

Daily meetings

Day 2: 25th June

Steve

  • bug 1010690 - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground
    • Partner reported that the issue still exist, but I could not reproduce it...
  • bug 1022644 - [Messages] Can't open the recipient panel if there are only 2 lines of recipients
    • Feedback+, still working on the test
  • bug reviewing:
    • bug 925404 - [B2G] [SMS] Always include the phone number in the SMS Thread UI, even if the carrier is known: r=me
    • bug 1025552 - Refactoring for attachment rendering: No serious issue discovered right now, maybe we can land for this sprint.
    • bug 974867 - [MMS]Auto suggestion for email address: Some suggestion gave, the test still failed.
    • bug 959201 - [Messages][Drafts] Wrong Cursor position in the message compose of a Draft: Some feedback given and r+

Today:

  • Try to clean(or reduce) the review queue
  • Update patch in bug 1022644

Oleg

  • bug 008127 - [Messages][Refresh] Subject handling in the Composer
    • We finally have patch that works, and don't see any issues! It requires JS changes, but it's much less risky now. So I prefer to go with it instead of changing layout and fixing regressions later on. Tightly collaborated with Pavel yesterday, it speeds up the process a lot. Some cleanup is left from both CSS and JS sides, once we finish, Pavel will ask for review from Steve (in progress, almost done).
  • bug 1025552 - [Messages][Refactoring] Refactor attachment.js and specifically move rendering part to a separate module
    • Rebased on the latest master (in review).
  • bug 1026575 - [B2G][SMS] Message preview in Messages app thread view disappears after opening app
    • Tried to reproduce it many times, with Buri and Flame, using git revisions mentioned in the bug and master, but without luck. Noticed that in video attached to the bug, timestamps for the thread and the single message in it are different that made me think that thread was manipulated somehow, but QA didn't confirm that. The only a bit similar case that I found is when we have "empty" draft for the thread (just a space or new line in message input an save it as a draft), but it's still not the same issue.

-> Steve, do you have any ideas? I'm using PVT builds, but QA mentioned some tinderbox builds, I don't really know much about it, found only something similar (https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/tinderbox-builds/). Can "tinderbox vs nightly pvt" builds be the reason why I can't repro this? -> Based on QA's description, tinderbox build will produce more frequently (4 times a day or more) for finding the regression window with less effort. But basically the code base is the same. The only possibility might be the some changes that need patches from both gaia and gecko, but tinderbox build created with one side is not ready yet. But if it's still reproducible on the latest build, maybe we could ask them to try in on PVT build? -> Yeah, probably it's the only thing I can do :) Thanks! Will ask Jayme to check that with PVT. And will try to manually flash with tinderbox build they mentioned.

  • bug 1013296 - Compose. Change send button to an paper plane icon
    • Went through the bug and haven't noticed why it can depend on subject handling patch, we may touch the same stuff in CSS, but it isn't really a dependency. Asked Arnau to proceed with this patch.

Other:

    • Added demos to the Sprint 3 Demo page for the carrier header patch + closed related "bug 883911 - [SMS][MMS] Update all occurrences of "Type ? Carrier ? Number" strings to same format" as it's covered by the carrier header patch.

Today: handle review comments for attachment refactoring patch, will polish JS part for the subject handling patch.

Day 3: 26th June

Steve

-> Phew :) I thought I the only one with this strange issue and STR :) I can not reproduce it if music is always on. -> Yep, initially I thought that it caused by RemoteControls.play (when I press Play\Pause in the notification panel) which calls getSelf and due to the bug in it, onsuccess isn't fired for the rest of calls (that made from our App). But wasn't able to confirm that :( Seems I'm wrong. -> Also I can't reproduce it when I resume the song, but it ends soon and always reproduce when I have song playing at the beginning :) Mess :( -> Have you tried that only make the music app from background to foreground and not playing the song? -> Not yet, maybe I could try this one myself to clarify. -> I also will try simpler and more stable STR, but I'm "glad" that it doesn't work for SMS as it simpler and faster to test. Do you have any tips on how to use logcat more efficiently? I only use it as "adb logcat | grep Gecko"I also use grep for filter... :p Maybe you could try DDMS -> Oh, never heard about that (but just googled :) ), will check it out, thanks!It's Android Developers tool kit that have graphic UI and you could treat the logcat more convenient. -> Nice! Also forgot to mention (that happened to me only once though) that after a long testing with lots of missed notifications, even after rebooting and without Music I stopped to receive any notifications for the messages coming to "target" thread.

  • bug 1022644 - [Messages] Can't open the recipient panel if there are only 2 lines of recipients
    • Test added and request review
  • bug reviewing:
    • bug 1025552 - Refactoring for attachment rendering: Landed
    • bug 974867 - [MMS]Auto suggestion for email address: Partner request another review.
    • bug 1013296 - Compose. Change send button to an paper plane icon: Arnau update the patch again that might has less side effect on DSDS device. Reviewing and testing.
    • bug 959201 - [Messages][Drafts] Wrong Cursor position in the message compose of a Draft: Landed
    • bug 963043 - [MADAI][Dialer] Select phone number from Call log as Recipients from SMS App. Feedback given but they have to fix conflicts first.

Today:

  • Try to clean(or reduce) the review queue
  • Update patch in bug 1022644

Oleg

  • bug 1008127 - [Messages][Refresh] Subject handling in the Composer
    • Polished my JS part, so it's ready. Today will merge it with the latest patch from Pavel to test merged patch on device (in progress, almost done).
  • bug 1025552 - [Messages][Refactoring] Refactor attachment.js and specifically move rendering part to a separate module
    • Fixed last review comments and landed (landed).
  • bug 1026575 - [B2G][SMS] Message preview in Messages app thread view disappears after opening app
    • After discussion with Jayme on IRC we found out correct STR for the issue, so that I can now reproduce it: user just need to open composer, send message to create new thread, once user is automatically navigated to the newly created thread, SMS app should be closed with the card view (app manager? not sure what is the common name for it). In this case onVisibilityChange is triggered and empty draft is saved (due to bug in onVisibilityChange). Then when user opens app he sees how message preview is quickly replaced with the empty draft :) I have PR for this, attaching it to the bug at the moment.
  • bug 1030160 - [Messages][MMS] Subject is considered empty (placeholder is displayed) even if it has several empty lines
    • While working on subject handling patch we've noticed that issue. I don't see easy and safe solution for it, so we have small workaround in the subject handling patch for this case.
  • bug 1010690 - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground
    • Spend some time trying to reproduce this issue. Finally was able to reproduce with SMS (MMS's are quickly eating mozilla's prepaid plan :))lol. Yeah, real life :) I've described what I saw in my comment to the bug, but didn't have time to systematize it to understand the reason

Other: Today: will review patch from Steve related to recipient panel with 2 lines, send patch for bug 1026575 for review and handle review comments + send subject handling patch for review if don't notice any serious issues while testing on device. Will try to find the root cause for Tarako issue with missed notification.

Day 4: 27th June

Steve

  • bug 1010690 - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground
    • Will verify with latest build with gecko patch bug 1026737 landed
  • bug 1022644 - [Messages] Can't open the recipient panel if there are only 2 lines of recipients
    • r+, will land to master and v1.3t
  • bug 1021513 - [Messages] Recipients list container scroll up automatically when dragging down the container for multiline recipients list mode
    • Will create patch today. Just set the transitionend event listener on the correct element will fix this issue.
  • bug reviewing:
    • bug 974867 - [MMS]Auto suggestion for email address: Still have a small issue for the multi-resolution icon.
    • bug 1013296 - Compose. Change send button to an paper plane icon: Arnau update the patch again that might has less side effect on DSDS device. no update today.
    • bug 959011- [MADAI][Dialer] Sending pre-defined message during call reject - Explain the idea from julien and Anthony to partner about the quickReply module and separate html entry.

Today:

Oleg

  • bug 1008127 - [Messages][Refresh] Subject handling in the Composer
    • Tested on device, looks good to me (in review).
  • bug 1026575 - [B2G][SMS] Message preview in Messages app thread view disappears after opening app
    • Prepared simple patch that doesn't respect Thread.recipients.length when auto-saving draft in the Thread panel and sent for review (in review).
  • bug 1010690 - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground

-> Did you try to apply it? You mean the gecko patch? No, I mean call getSelf before our own getSelf (without gecko patch)?No I haven't, and it looks weird to do so :p Yes! :) I know it won't work without gecko patch, I saw it while testing previously, when dispatchNotification is called several times in a row (all previously missed notifications)

  • bug 1022644 - [Messages] Can't open the recipient panel if there are only 2 lines of recipients
    • Reviewed, looks good, r+'d.

Today: will handle review comments for patches in review + going to look into next blocker we have "bug 1022755 - Possible race in the SMS navigation code"

Day 5: 30th June

Steve

  • bug 1010690 - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground
    • Will verify with latest build with gecko patch bug 1026737 landed(didn't have time to do it last week...)
  • bug 1022644 - [Messages] Can't open the recipient panel if there are only 2 lines of recipients
    • r+, but v1.3t need another implementation. So I'll commit another patch for 1.3t.
  • bug 1021513 - [Messages] Recipients list container scroll up automatically when dragging down the container for multiline recipients list mode
    • Landed on master
  • bug reviewing:
    • bug 974867 - [MMS]Auto suggestion for email address: Conflicts fixed and need another review.
    • bug 1013296 - Compose. Change send button to an paper plane icon: Landed.
    • bug 1026575 - [B2G][SMS] Message preview in Messages app thread view disappears after opening app: Some suggestion given, but the patch looks fine
    • bug 1008127 - [Messages][Refresh] Subject handling in the Composer: Some feedback given, patch works great but it need to fix the conflicts.

Today:

  • Try to clean(or reduce) the review queue. Hope I could have some time for partner's patch...
  • Create v1.3t patch for bug 1022644

Julien

Today: Reading up all my mails, and trying to keep up with what happened during my break :)

Oleg

  • bug 1008127 - [Messages][Refresh] Subject handling in the Composer
    • Updated JS part according to review comments (retrieving subject input line height with "getComputedStyle"). Asked Pavel to update his PR with my latest changes (in review).
  • bug 1026575 - [B2G][SMS] Message preview in Messages app thread view disappears after opening app
    • Updated patch according to review comments (cleaning up ThreadUI.recipients in "afterLeave" if next view isn't Composer + unit test) (in review).
  • bug 1010690 - [Tarako][MMS][Notification] The notification of new MMS does not appear while playing music/video in foreground
    • Cleaned up ni?=me as it's waiting for verification from Spreadtrum QAs. Will look once again if they still have this issue (awaiting QA verification).
  • bug 1021513 - [Messages] Recipients list container scroll up automatically when dragging down the container for multiline recipients list mode
    • Reviewed, looks good, r+'d (landed).
  • bug 1022755 - Possible race in the SMS navigation code
    • Still looking into this (can be reproduced without reference workload, I can reproduce it with thread with two MMS if quickly press Back button). Navigation.slide code looks fine to me except of memory leak as we've never unsusbscribed from "transitionend" (tried to unsubscribed on the wrong element), so number of listeners is growing proportionally to number of navigation between panels (in progress).

Other:

    • We have two new 2.0 blockers: bug 1030160 - [Messages][MMS] Subject is considered empty (placeholder is displayed) even if it has several empty lines (awating decision from UX) and bug 1022575 - Received SMS store (without text) on check balance.

Today: will handle review comments for patches in review + investigate bug 1022755

    • (Julien) you need a gecko patch before bug 1022755
    • (Oleg) What Gecko patch?
    • (Julien) sorry, mixed with bug 1022575 (same digits, different positions ;p)

Day 6: 1st July

Day 7: 2nd July

Day 8: 3rd July

Day 9: 4th July

Day 10: 7th July

Demos

Retrospective

Retrieved from "https://wiki.allizom.org/index.php?title=Gaia/SMS/Scrum/4&oldid=993245"