Confirmed users
709
edits
No edit summary |
(We updated the template, update the documentation accordingly) |
||
Line 12: | Line 12: | ||
= Guidelines on approval comments = | = Guidelines on approval comments = | ||
* [ | * [Feature/regressing bug #]: If you this is a fallout from a feature/bug, or a backout please state the reason along with the bug number | ||
* [User impact | * [User impact if declined]: In addition to the STR (steps to reproduce) reported in the bug if you can explain on a deeper level aspect of how an end user would be impacted with/without your change | ||
* [ | * [Describe test coverage new/current, TBPL]: What kind of testing was completed here. Manual and/or automated ? Any details about what scenarios the tests cover? If the patch landed on a master/central branch or any other branch did we get verification from reporter or QA. | ||
* [ | * [Risks and why]: No risk/Zero risk are unacceptable here. Even a single line of code change could be damaging!, yes we've seen that | ||
** When saying something is "low","medium", "risky" please justify | ** When saying something is "low","medium", "risky" please justify | ||
** Eg : Low risk because its a one line CSS change impacting only settings page | ** Eg : Low risk because its a one line CSS change impacting only settings page | ||
** Eg : Medium, given the code complexity and integration with other areas of code that might be impacted. Expect regressions in areas like.. | ** Eg : Medium, given the code complexity and integration with other areas of code that might be impacted. Expect regressions in areas like.. | ||
** Eg : risky, given the complex nature the bake time we have have on master/central or other branches. High rate of fallouts/regression. Could be mitigated by more manual testing in areas or running some targeted test cases.. | ** Eg : risky, given the complex nature the bake time we have have on master/central or other branches. High rate of fallouts/regression. Could be mitigated by more manual testing in areas or running some targeted test cases.. | ||
* [String | * [String/UUID change made/needed]: Please answer this as "none" if no string changes were made | ||
= Firefox (Desktop and Mobile) = | = Firefox (Desktop and Mobile) = |