EngineeringProductivity/Projects/MozReview: Difference between revisions

m
formatting
m (formatting)
Line 34: Line 34:
This is just the basics of the model, with details (including a how-to) to come.
This is just the basics of the model, with details (including a how-to) to come.


[http://www.reviewboard.org/ Review Board] is an open-source review
[http://www.reviewboard.org/ Review Board] is an open-source review tool which supports just about every VCS out there. Unfortunately, it is also fundamentally a patch-based system, although it does know about repositories' canonical location so it can grab context that isn't in the diff itself--at least, if the patch still applies. This makes it still a fancy version of Splinter, fundamentally.
tool which supports just about every VCS out there. Unfortunately, it
is also fundamentally a patch-based system, although it does know
about repositories' canonical location so it can grab context
that isn't in the diff itself--at least, if the patch still applies.
This makes it still a fancy version of Splinter, fundamentally.


Luckily, we have all kinds of clever people here with intimate
Luckily, we have all kinds of clever people here with intimate knowledge of VCSes, including Mercurial, so in late winter they banged together a prototype showing that it is possible to convert Review Board to a branch-based system after all!
knowledge of VCSes, including mercurial, so in late winter they
banged together a prototype showing that it is possible to convert
Review Board to a branch-based system after all!


As an aside, we we say "branches", we mean the git concept of
As an aside, we we say "branches", we mean the git concept of them--lightweight. Branches in mercurial are not the same at all; however, there are two alternatives that provide similar functionality: [https://developer.mozilla.org/en-US/docs/Mercurial_Queues Mercurial Queues], now considered obsolete by many, and [http://gregoryszorc.com/blog/2014/06/23/please-stop-using-mq/ hg bookmarks]. Both are supported by our system, though the latter is preferred
them--lightweight. Branches in mercurial are not the same at all;
however, there are two alternatives that provide similar
functionality: [https://developer.mozilla.org/en-US/docs/Mercurial_Queues Mercurial Queues], now considered obsolete by many, and [http://gregoryszorc.com/blog/2014/06/23/please-stop-using-mq/ hg bookmarks]. Both are supported by our system, though the latter is preferred


Since then, we've settled on a concrete design that makes submitting
Since then, we've settled on a concrete design that makes submitting patches as painless as possible, as well as providing integration to Bugzilla.  The main components are
patches as painless as possible, as well as providing integration to
Bugzilla.  The main components are


* Review repos.  Similar to the [https://wiki.mozilla.org/ReleaseEngineering/TryServer Try server], review repos are clones of existing repos, such as mozilla-central.
* Review repos.  Similar to the [https://wiki.mozilla.org/ReleaseEngineering/TryServer Try server], review repos are clones of existing repos, such as mozilla-central.
canmove, Confirmed users
409

edits