Gaia/SMS/Scrum/FxOS-S9

List of bugs

SMS issues handled by the SMS subteam (blocks the sprint bug 1212336)

Bugzilla link

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature-b2g	Whiteboard	Resolution
1192263	Steve Chung [:steveck]	[Messages] We load Inbox before going to the notification conversation when app is run via notification click.	2.5+	No cf_feature-b2g	[p=2]	FIXED
1197231		Increase in SMS app memory consumption	---	No cf_feature-b2g	[p=2]	WONTFIX
1206727	Julien Wajsberg [:julienw]	[Messages][Inbox] Don't reload the conversation node after saving draft	---	No cf_feature-b2g	[sms-papercuts][p=1]	FIXED
1211395	Steve Chung [:steveck]	Performance regression in Message	2.5+	No cf_feature-b2g	[p=2]	FIXED

4 Total; 4 Open (100%); 0 Resolved (0%); 0 Verified (0%);

Remaining points and burndown chart

google chart api url for Sprint FxOS-S9

Burndown chart

	Remaining points
Start	7
Day 2	7
Day 3	7
Day 4
Day 5
Day 6
Day 7
Day 8
Day 9
Day 10
End

SMS issues handled by the SMS subteam outside of the sprint (contains whiteboard "sms-sprint-FxOS-S9")

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature-b2g	Whiteboard	Resolution
1213199	Oleg Zasypkin [:azasypkin]	[Messages] 'Message saved as draft' notification is displayed even if draft has been removed afterwards before going to Inbox	2.5+	No cf_feature-b2g	[2.5-aries-test-run-3][sms-sprint-FxOS-S9]	FIXED
1216617	Oleg Zasypkin [:azasypkin]	[Messages] Disable timeout for ActivityClient	2.5+	No cf_feature-b2g	[sms-sprint-FxOS-S9]	FIXED
1218091	Oleg Zasypkin [:azasypkin]	[Messages][Performance] Use optimized Bridge libraries	---	No cf_feature-b2g	[sms-sprint-FxOS-S9]	FIXED

3 Total; 3 Open (100%); 0 Resolved (0%); 0 Verified (0%);

All SMS issues tracked for this sprint (target milestone)

Bugzilla link

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature b2g	Resolution
1037620	Stéphane Roucheray	[v2.1] Feature Proposal: Late Arrival Notice in Messages App	---	---	FIXED
1181936		(Gaia RTL 2.5) Support RTL for Messages/SMS App	---	2.5+	WONTFIX
1192263	Steve Chung [:steveck]	[Messages] We load Inbox before going to the notification conversation when app is run via notification click.	2.5+	---	FIXED
1212336		SMS sprint FxOS-S9	---	---	WONTFIX

4 Total; 4 Open (100%); 0 Resolved (0%); 0 Verified (0%);

Sprint planning

Minutes are on a separate page.

Daily meetings

Day 2: 8th October

Steve

• National holiday on Friday
• bug 1211395 - Performance regression in Message
  • Profiling the number for coldlaunch time, will compare the result in each stage to see which stage is the bottoleneck

    (Oleg) I'll post my numbers into the bug, will be nice to compare with yours later then :)

• bug 1192263 - [Messages] We load Inbox before going to the notification conversation when app is run via notification click
  • Cearte a small patch for early feeback
• Reviewing the systemMessage handler(Still in unit test part)

Today:

• Coldlaunch profiling.
• Give some feedback for Oleg's patch about the system message.
• Working on some blockers if they have any progress.

Julien

Nothing really exciting. I reviewed patches that are out of the SMS codebase:

• bug 1209041 is a patch for gaia-header but that affected our RTL support
• bug 1196268 is a patch to action_menu.js that will fix the "cancel" button in all our menus

I also had a look to the NI in bug 1206844 about emojis support. And I also looked at bug 1190980 as discussed yesterday, to see if I could reproduce (copy/paste issue in To recipient panel). I also started my experiment with async scripts, but will stop now and will resume later tonight or tomorrow. Today: I want to:

• handle review/feedback/NI queue that's still huge
• handle my bugmail that's still huge too
• land some r+ bugs I have somewhere

Oleg

• I'll be on PTO on Friday.
• bug 1198266 - [Messages] Use ConversationService in the application
  • No progress (awaiting feedback).
• bug 1208532 - [Messages][Refactoring] Extract SystemMessageHandler from ActivityHandler
  • No progress (in review).
• bug 1197231 - Increase in SMS app memory consumption
  • Started to dig into it from re-measuring v2.2, but figured out that raptor doesn't work with v2.2 anymore, talked with Eli and bisect that it has been broken between 1.4.4 and 1.4.5 (current is 2.0.3), filed "bug 1212454 - [Raptor] Raptor fails to run coldlaunch tests for v2.2 branch".
  • So if you need v2.2 numbers use @mozilla/raptor@1.4.4 for now.
  • Also tried to test v2.5 gaia on v2.2 gecko - no luck, it doesn't work for Messages app - Intl api is not available, and other not-really-clear exceptions are thrown in shims. So I measure gaia v2.2/gecko v2.2, gaia master/gecko master and will try gaia v2.2 (well entire gaia doesn't work, so will try only v2.2 Messages app in v2.5 gaia)/gecko master. (in progress)

    (Steve) I saw the empty homscreen after make raptor on 2.2, is that the issue you said here? So using raptor v1.4 should be working on 2.2?

    (Oleg) gaia v2.2 on gecko v2.5 - yes, empty home screen, gaia v2.5 on gecko v2.2 - sms doesn't work, but homescreen works :) Yep v1.4.4 for v2.2 branch (1.4.3 doesn't work, 1.4.5 doesn't work as well but with different error). I've just was able to run gaia v2.5 + sms v2.2 on gecko v2.5 - aaaaaand I'm confused :) _Memory_ numbers are very close to sms v2.5 - digging.

    (Steve) ok :/ We want to reduce the variable as less as possible but it seems not gonna happen

Other:

• bug 1207094 - [Messages] Disable appropriate controls when in low storage condition
  • Left feedback.
• bug 1133711 - Remove dev_apps folder (in background)
  • Discussing with Eli and Kevin where and how we can put performance benchmarking apps into gaia, things are going very slow, maybe I've involved not the right people into discussion - so no decision yet :/
  • Tried to preload outoftree apps with preload script like Spark does, looks like a viable solution.
  • Ideally I'd include various benchmarking app to have _pure_ performance numbers for the API we use, ServiceWorker, maybe mozMobileMessage - to easier and earlier spot Gecko (or System app at least) regressions.
• Guided contributor on "bug 1209419 - [Messages][Tests] Add basic integration tests for the Conversation view Edit mode";
• Finished with bugmail.

Today:

• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Day 3: 9th October

Julien

• Reviewed bug 1192263 about the bug that clicking the notification is loading the inbox
• Answered the question in bug 1190613 about automatically canceling current inline activities when the user displays an app's existing instance from the homescreen
• Looked at bug 864790 about warning about deleting unread messages
• Had a deep look at the issue in bug 1210201 in Calendar, about a change in event fluffing that benefitted the SMS app
• Had a look at bug 1212875 about RTL issues in empty contenteditable elements
• Reviewed bug 1196268 about the cancel button in action menus
• Looked at bug 1180470 about the send report configuration

Today: I want to:

• handle review/feedback/NI queue that's still huge
• handle my bugmail that's still huge too
• land some r+ bugs I have somewhere

Steve

National Holiday

Oleg

PTO

Day 4: 12th October

Steve

• bug 1211395 - Performance regression in Message
  • Profiling with profiler for both versions and will insert more marks for profling. Sorry about the inconvenience that we have to aware of the limited default entry number :/ Tingyu will file a bug for that.

    (Julien) thanks ! I totally knew about it but it was not obvious from the profile I got. It's weird I got different periods for the different threads...

• bug 1192263 - [Messages] We load Inbox before going to the notification conversation when app is run via notification click
  • Updated the patch for another early feeback
• Reviewing the systemMessage handler(Still in unit test part, I promise I will finish it October 12)

  (Oleg) No hurry, it's out of sprint anyway, thanks! :)

Today:

• Coldlaunch profiling.
• Give some feedback for Oleg's patch about the system message.
• Working on some blockers if they have any progress.

Julien

• spent some time on bug 1209961 about reversing icons in RTL mode. I had a look at opentype fonts and found that opentype has a mechanism to handle this. So it's likely better to do this inside the font than adding more CSS.
• gave a feedback for 2.5+ System bug 1190613 that's affecting the Messages app as well. We'll cancel any inline activities if app.launch() is called for the initiating app (eg: when tapping a notification; but also when starting the app from the homescreen).

  (Steve) I think messages team don't have to do anything if platform decided to close the inline instance when app launched?

  (Julien) agreed :) When I say "we" I mean "Firefox OS" ;) Got it :)

• reviewed bug 1064144 about the focus handling when entering new message/conversation panel. Instead of "focusComposer: true" we'll have an enum "focus: 'composer'/'recipients'/undefined". Undefined will yield a specified algorithm.
• reviewed bug 1203108 about porting SMS to l20n
• reviewed bug 1037620 about displaying a late arrival notice when the message is received a long time after being sent.

Apart from this I continued reading some of my bugmail but still not finished. Today: I want to:

• I still want to finish handling my review/feedback/NI queue.
• handle my bugmail that's still huge too
• land some r+ bugs I have somewhere

Oleg

• bug 1198266 - [Messages] Use ConversationService in the application
  • No progress (awaiting feedback).
• bug 1208532 - [Messages][Refactoring] Extract SystemMessageHandler from ActivityHandler
  • Got some feedback from Steve, will reply today(in review).
• bug 1197231 - Increase in SMS app memory consumption
  • Eli fixed raptor (bug 1212454 - [Raptor] Raptor fails to run coldlaunch tests for v2.2 branch) so we can use the latest improved version for both master and v2.2 now (raptor@3.0.2);
  • Tried to figure out/bisect the gecko build where our memory usage increased - but it seems it slowly adds up since April. Raptor dashboards look the same with several spikes, I've tried to look closer to one of biggest (middle of June, but builds from that period don't show this spike anymore, maybe something has been uplifted/backed out after measurements has been made). Investigating (in progress).

Other:

• bug 1133711 - Remove dev_apps folder (in background)
  • Will give a try to Eli suggestion to hardcode origin inside manifest and test with "distros/raptor" approach (in background).

    (Julien) I don't properly understand what you're trying to do in this bug ?

    (Oleg) We want to have the list of benchmarking-only-apps _somewhere_, that are located out of gaia tree and these apps should be dowloaded and flashed to device with "make raptor" command.

    (Julien) and you have such apps somewhere, right ? I agree it would be nice to have a list of such apps so that it's easy to find :)

    (Oleg) I have only one for now :) To test SW performance

    (Julien) OK !

• Guided contributor on "bug 1209419 - [Messages][Tests] Add basic integration tests for the Conversation view Edit mode";

  (Julien) I also added a NI to you on another mentored bug :)

  (Oleg) Yep, thanks! Replied with small guidance already :)

Today:

• (if I have time) Will prepare quick PR for feedback for "bug 1213199 - [Message] Wrong suggestions 'Message saved as draft' pop up after you select delete the MMS.";
• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.