Webtools:Mozparty
Code
Issues Found/Fixed
- /config/database.php shouldn't be in the repository. IT prefers a .default or -dist file. (Same goes for config/bootstrap.php if you expect IT to change values in it)
- There needs to be a README with
- description of project
- any special server requirements
- steps to install
- steps to test (verify that things are working)
- Line 288 of controllers/user_controller.php has a hardcoded link in it that isn't going to work.
- Going to /user/activate/<random characters> inserts new rows in the database
- When updating a profile, if the passwords don't match the error just says "There was an error in your submission..." but doesn't say what it was
- When updating a profile, if input is "<'name" it is saved/returned as "<'name". Each time the profile is updated, the entities are re-encoded again.
- When I created the party I did not choose "Invite only," however, when I go to the "Invite a guest" option it says "Since your party is invite only..."
- /register/ is a 404, but is linked to in the code (line 333 in controllers/party_controller.php - might be elsewhere too)
- After updating a profile, the user is logged out
- When updating a profile, if a password is entered into the first box but not the second (or the second doesn't match), the password overwrites the saved password in the database in plain text.
- When updating a profile, if a password is entered into the second box but not the first, the form continues submission, no updates are made, no errors are shown
- going to /party/view/<number> and clicking "Count me in!" will create rows in the database for parties that don't exist
- When viewing a party that is invitation only, there is no way for someone to tell that they have to be invited.