Firefox/QX Meeting Notes
Tracker: https://bugzilla.mozilla.org/showdependencytree.cgi?id=1244854&hide_resolved=1
Oct 4
- GIF du jour:
- :o - no gif! (sorry)
- MFBT! http://i.imgur.com/sjQ2C2c.gifv
- Status updates
- Dao
- Bug 658467 - Fade out tab label on overflow instead of ellipsis
- blocked by mask-image getting ready to ship
- Bug 1022553 - Audio/video controls unusable in High Contrast mode
- reading style system code to figure out how I could add another sheet type so that high contrast mode doesn't affect XBL sheets like videocontrols.css
- in review:
- Bug 1306584 - Lightweight theme button icon and Restore Defaults button disabled state don't update when selecting a theme in customize mode
- landed:
- Bug 1306264 - Move chrome://browser/skin/theme-switcher-icon.png reference from CustomizeMode.jsm to theme code
- uplifted:
- Bug 1303291 - Clean up identity block and control center icons
- Bug 1304341 - Icons in the main menu, identity block and control center need more opacity in high-contrast mode and on Linux
- Bug 658467 - Fade out tab label on overflow instead of ellipsis
- Gijs
- Looking at data from automigration experiment. It has issues:
- Sync data is 0, because of https://bugzilla.mozilla.org/show_bug.cgi?id=1307382
- Patch on autoland repo, will request uplift once it sticks.
- This case is currently hitting the 'password change/addition' path because sync stores credentials
- From this we can still infer current number of people who sign up to sync as <= password hits
- which is significantly less than people who modify bookmarks, it seems
- Bookmarks data is very high
- Looked at this a bit, seems our preconceived notions about how many users use bookmarks might be wrong! (cf. https://docs.google.com/document/d/1qhOBk3cGosCk5olTLmyT4lNDeLv2zgGKLIabksmxXiE/edit# )
- The number of people who see the notification bar 3 separate days and then get undo disabled there because they don't interact with the notification bar seems very low (<5%)
- Number of different ideas as to why that might be.
- something's broken! (like the sync case)
- not sure what. One way of figuring this out would be to add telemetry for how often we show the notification bar, which would at least give data as to whether we're showing it.
- session restore
- at least a 1/3 of a random 100,000 count beta sample from the longitudinal set on sql.tmo used automatic session restore at least once
- could be restore after crashes or add-on install or beta updates (which are released every 3.5 days!)
- we don't seem to have better telemetry on this. Ugh.
- at least a 1/3 of a random 100,000 count beta sample from the longitudinal set on sql.tmo used automatic session restore at least once
- different homepages
- afaict, no telemetry on this, only on fennec. Ugh.
- people stop using firefox and never get 'round to seeing that bar 3 times in a row
- not helped by it racing the first time: if unlucky, no bar on your initial about:home because the migration finishes after about:home loads
- also not helped by data lag from telemetry.
- something's broken! (like the sync case)
- Number of different ideas as to why that might be.
- Tentative data suggests people from IE more likely to ditch auto-imported data (undo migration) whereas people from Chrome are more likely to keep (not enough data to tell for Safari and Edge)
- Which seems plausible.
- Yet Another Reason why telemetry "doesn't work" for the funnelcake experiment on release
- tmo only has opt-in data. By the first startup the user obviously hasn't opted in, and so there's no telemetry. Also there'll be sample bias in any other telemetry.
- This doesn't affect beta/aurora/nightly as much because opt-in is the default on pre-release channels.
- Looks like we'll need to use a spark job to deal with telemetry from the funnelcake
- Why bother? Well, we don't disable the firstrun pages on release. So it'll be interesting to see if the number of users that use sync there is much higher or not, which will help us evaluate what we need to address before going to release.
- tmo only has opt-in data. By the first startup the user obviously hasn't opted in, and so there's no telemetry. Also there'll be sample bias in any other telemetry.
- Sync data is 0, because of https://bugzilla.mozilla.org/show_bug.cgi?id=1307382
- Going to have to try to work out how to deal with sync. It's Complicated.
- Continuing work to improve (auto)migration:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1279240 - default browser backup from the installer on xp/vista/7 has landed
- https://bugzilla.mozilla.org/show_bug.cgi?id=1305770 - patch to be able to import cookies & passwords from Chrome while it's running is up
- https://bugzilla.mozilla.org/show_bug.cgi?id=1307382 - aforementioned fix to automigration's sync telemetry
- Other bugs:
- Patches up:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1274633 - remove add'l first-run pages (windows 10 + private browsing tracking protection)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1305339 - fixes to OS X download quarantining ("you downloaded this file from http://mozilla.org/, are you sure you want to open it")
- https://bugzilla.mozilla.org/show_bug.cgi?id=1302086 - theme regression with devedition theme
- https://bugzilla.mozilla.org/show_bug.cgi?id=1307132 - brokenness in about:preferences cookie dialog
- Fixed:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1290668 - regression related to links in view-source pages
- https://bugzilla.mozilla.org/show_bug.cgi?id=1191778 - killed a dead stylesheet reference in the prefs
- https://bugzilla.mozilla.org/show_bug.cgi?id=1000458 - fixed location bar behaviour when you switch tabs immediately after typing + hitting enter
- https://bugzilla.mozilla.org/show_bug.cgi?id=1295002 - silly crash bug for broken view-source links (my old friend nsDefaultURIFixup!)
- some sec bug stuff
- Patches up:
- Looking at data from automigration experiment. It has issues:
- Jared
- Location bar autocomplete and search autocomplete shadow work
- Worked on patches to fix this through binding changes as well as a different patch to change the widget code
- Jim Mathies requested that this not get changed through widget and Dao doesn't want this changed through binding changes
- Theme work started on Cedar twig
- Landed baseline support for defining a theme in the webextension manifest
- Working on supporting background images for in-content pages
- Location bar autocomplete and search autocomplete shadow work
- Mike
- Many dimmed highlighting bugs
- Triage
- About five bugs in-flight
- Awaiting platform support for
- Much theme work
- Meetings
- Setup cedar twig to be our project branch
- Reviews and n-i's
- Did this during the weekend: https://www.evernote.com/l/APsMxJ9ea2BJa72dFhHEx5VGztMGJRTTa9k
- [jaws] Sweet! That photo is awesome amazing
- [dolske] +1! wow!
- Learned:
- Running android on (recent?) OSX is b0rked
- Running mozilla-beta on recent OSX is b0rked
- Running or building? running
- Many dimmed highlighting bugs
- Stephen
- Verdi
- Stephen and I talked about these:
- We decided to wontfix this (bookmarks panel autoclose when using keyboard shortcut) https://bugzilla.mozilla.org/show_bug.cgi?id=1290011#c18
- Do this - We should make the bookmarks toolbar hide if you change your mind while filing a bookmark https://bugzilla.mozilla.org/show_bug.cgi?id=1293349
- Do this - And we should default all new bookmarks to the other bookmarks folder no matter how they are created https://bugzilla.mozilla.org/show_bug.cgi?id=1120110
- I've been watching usertesting videos and seeing people not having problems finding bookmarks!
- Stephen and I talked about these:
- pdol
- WinXP/Vista users will be moved to ESR52
- On branch, XP/Vista specific code can be dropped from central
- Dev-platform mailing list
- John Gruen to help with themes effort
- Waiting on UR resource for session restore testing
- WinXP/Vista users will be moved to ESR52
- philipp
- Dao
- Roundtable
Sep 27
- GIF du jour: *tickle* https://i.imgur.com/JW9iMOu.gifv
- Status updates
- Dao
- High Contrast
- landed
- Bug 1304341 - Icons in the main menu, identity block and control center need more opacity in high-contrast mode and on Linux
- Bug 1304363 - 2.23 - 4.78% tabpaint / tpaint (osx-10-10, windows7-32, windows8-64, windowsxp) regression
- Bug 1304708 - Use icon-colors.inc.svg in notification-icons.svg
- Bug 1304973 - Identity popup expander button shouldn't have a white gradient in the background unless hovered
- Bug 1022553 - Audio/video controls unusable in High Contrast mode
- will give this a shot before wrapping up the high contrast work
- landed
- misc
- Bug 658467 - Fade out tab label on overflow instead of ellipsis \o/ \o/
- has ui-review+, thanks Stephen
- landed
- Bug 1302307 - blocked-permission-icon margin should only apply within the identity block
- Bug 1302759 - missing customize-titleBar-toggle.png referenced from browser.css on Linux
- Bug 658467 - Fade out tab label on overflow instead of ellipsis \o/ \o/
- High Contrast
- Gijs
- Telemetry from beta (specifically: re: automigration) is slow coming in. Trying to find out why. The little data we have is encouraging - but too little. :-)
- Patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1279240 - dealing with default browser being overwritten on xp/vista/7
- Reviews
- ... moar security bug backlog
- Jared
- find-in-page markers on the scrollbar
- shadows on the location bar and search autocomplete dropdowns
- select dropdown: styles are being applied and the students are working on porting the e10s implementation to run in non-e10s
- Could you flag someone (me or Stephen) for ui-review there? Thanks!
- reviews...
- Mike
- We just had a Firefox theming meeting with add-ons team!
- Find toolbar in good shape!
- Blocking bugs are winding down quickly
- Only really platform-dependent issues left
- Proper triage tomorrow
- Reviewed first patch in reader mode
- Caught up with my n-i queue
- https://www.servethehome.com/firefox-is-eating-your-ssd-here-is-how-to-fix-it/ happened on HN :-P
- non-technical comment from me at https://www.yammer.com/mozilla.com/#/Threads/show?threadId=771208914
- Stephen
- Verdi
- pdol
- philipp
- Nothing to report
- Dao
- Roundtable
Sep 20
- GIF du jour: clean power https://i.imgur.com/VpSD7Gd.gifv
- Status updates
- Dao
- High Contrast issues
- landed
- regression from bug 1022573: Bug 1297806 - 15% linux cart regression
- looks like the improvement is slightly bigger than the original regression
- also reduces Windows installer size slightly
- --> we should replace more PNGs with SVGs. What's the status of bug 1054016? (blocked on https://bugzilla.mozilla.org/show_bug.cgi?id=1058040)
- Bug 1022604 - Customize Mode's exit button should be more legible in High Contrast mode
- Bug 1302405 - Remove special styling for non-default Windows themes from panelUI.css
- Bug 1008730 - Customization palette doesn't obey High Contrast settings
- Bug 1303291 - Clean up identity block and control center icons
- regression from bug 1022573: Bug 1297806 - 15% linux cart regression
- landed
- misc
- landed
- Bug 1302952 - Simplify gear.svg by using the fill filter
- Bug 1302984 - Implement active and open state styling for the customize mode footer buttons
- Bug 1303259 - Awesomebar results popup's search settings button should have a tooltip
- landed
- High Contrast issues
- Gijs
- Measurements of usage of manual migration builds as a test-run for how to do measurements: https://sql.telemetry.mozilla.org/queries/1252
- Kind of interesting... safari users use us lots? Maybe because macs, and so sleep, and so end-to-end session times are inflated?
- Automigration turned on on beta to see how that goes \o/
- Automigration experiment for 49 also proceeding despite slight Gijs-caused hiccups.
- Landed:
- Chrome migration while it's running: https://bugzilla.mozilla.org/show_bug.cgi?id=1285041
- Some sec bug stuff
- Working on:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1279240 - saving default browser info in the installer on xp/vista/7 so we can use it to make migration decisions
- Measurements of usage of manual migration builds as a test-run for how to do measurements: https://sql.telemetry.mozilla.org/queries/1252
- Jared
- Landed
- Bug 1184790 - Force the notification text to show on hover if the notification is transitioning
- Bug 1296070 - RotatedBuffer::DrawBufferWithRotation takes 10% of the time when opening the Firefox menu
- Went from on average 25.38ms to 8.49ms (almost 1/3 of the time), riding the 51 train
- In review
- Bug 1111145 - Change the drop shadow of panels to match the native Windows popup shadow
- In progress
- Bug 1293242 - Wrong height calculation with multi-line description, "display: -moz-box", and "overflow: hidden"
- I can reproduce one of the test failures locally and am seeing what is causing it right now. It needs a previous test to run for it to fail.
- Firefox theming work
- Coordinating with Product and UX
- <select> dropdown work
- students have a pretty good understanding of the project
- gave a presentation to their class on monday about the project and what work is necessary
- Bug 1293242 - Wrong height calculation with multi-line description, "display: -moz-box", and "overflow: hidden"
- Reviewed for others
- Bug 1271765 - Visual refresh of media controls
- Landed
- Mike
- Findbar dimmed highlighting mode will be Nightly only, no uplift to Fx 51
- Many, many bugfixes went in
- Main bugs right now:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1282752 to get the nodes belonging to each ranges' ClientRect
- Deal better with hidden ranges (also platform)
- Get highlighting working for scrollable containers (overflow: scroll elements)
- Use :mstange's newly implemented hyper-performant rectangle-cutting API
- Firefox Theming
- More feedback coming in
- Stephen & Philipp in the loop :)
- Reaching out to more org areas soon
- Doing investigation on technical difficulties we might encounter, for example:
- Exploring WebExtensions
- Exploring DevEdition theme hard parts - will reach out for this too
- More feedback coming in
- Findbar dimmed highlighting mode will be Nightly only, no uplift to Fx 51
- Stephen
- Did some reviews. Made some SVG icons. Working on more reviews and UX triage.
- Met with Jared, Mike and Philipp about Theme API
- Verdi
- pdol
- Decision to do user research (UR) on Session Restore before follow-on Shield/equivalent testing
- Full post-UR test plan: https://docs.google.com/document/d/1KLVhbeovQAc-B-M95jx5UdTXRzte3WvGsK6Le0UqrF0/edit#heading=h.23kbtdsiyvwa
- Bill Selman to plan for UR
- Decision to do user research (UR) on Session Restore before follow-on Shield/equivalent testing
- philipp
- Once again not here because of hiring stuff
- timdream (read only): talked to Gijs and will have :evanxd dive into the Reading Mode cluster.
- Dao
- Roundtable
Sep 13
- GIF du jour: life pro tip:
- Status updates
- Dao
- High Contrast issues
- all P2s are fixed \o/
- in review:
- regression from bug 1022573: Bug 1297806 - 15% linux cart regression
- Bug 1022604 - Customize Mode's exit button should be more legible in High Contrast mode
- needs shorlander review
- Bug 1302405 - Remove special styling for non-default Windows themes from panelUI.css
- landed:
- [P1] Bug 1022568 - Default and hover style of buttons is illegible when using black-on-white or white-on-black High Contrast mode
- Bug 1022588 - The search button in the search box in about:home is not recognizable (no image/content visible) when using High Contrast mode
- Bug 1051861 - about:newtab Gear icon is invisible in High Contrast themes
- Bug 1301086 - about:home and about:newtab search submit label needs to be a left pointing triangle for RTL locales
- Bug 1301758 - Use CSS variables for dimmed elements in arrow panels
- Bug 1302355 - Make --arrowpanel-dimmed* colors work with dark OS themes
- uplifted:
- [P1] Bug 1022547 - Menu bar unreadable in High Contrast mode
- misc
- landed:
- Bug 1162441 - [HiDPI] Separator between toolbars and content is sometimes too thick at 125% scale
- Bug 1300870 - [HiDPI] Ctrl+Tab previews sometimes move when cycling through them at 125% scale
- regression from bug 1224732: Bug 1300410 - Pinned tab separators shouldn't touch the toolbar
- regression from bug 1224732: Bug 1300734 - [HiDPI] tabs sometimes move on hover at 125% scale
- Bug 1300876 - Share Ctrl+Tab panel styling across platforms
- landed:
- High Contrast issues
- Gijs
- reviews
- trying to deal with telemetry feedback and getting a better understanding of how to analyze it for retention/usage on sql.tmo
- CROSS JOIN UNNEST... is painful. Almost there now. https://sql.telemetry.mozilla.org/queries/1144 for an earlier version of what I was up to (note esp. custom charts of the tabular data for an easy-ish view of what's up)
- final stages of getting automigration experiment up on fx50beta
- Patch up on https://bugzilla.mozilla.org/show_bug.cgi?id=1289172
- waiting for r?dolske, approval from cmore & co to disable "welcome" landing pages, and uplift approval for aurora
- Patch up on https://bugzilla.mozilla.org/show_bug.cgi?id=1289172
- Misc other patches
- Some security bugs
- Another regression with IP-address-as-search detection (sigh)
- Chrome migration while Chrome is running
- Hopefully final patch on https://bugzilla.mozilla.org/show_bug.cgi?id=1285041 , waiting for review
- Fixes to Talos issues that were misleading L20N people into thinking we had some kind of progressive regression in tpaint
- Jared
- Mainly doing a lot of code reviews for new video controls and find-in-page work
- Spent a lot of time fighting with the Snappy Symbolication Server rewrite, may revert to an older revision
- Mike and I wrote up our summary of the Theme survey and emailed it out, will be meeting some time Thursday to discuss UX ideas for proposals
- Work is underway on the new <select> dropdown. Will meet with the students tomorrow during our weekly check-in
- Mike
- Gettin' dimmed highlighting mode ready to ship!
- https://bugzilla.mozilla.org/show_bug.cgi?id=1291278
- Just been re-enabled on Nightly past Friday
- Again, poor Jared reviewing all the things
- :mstange is looking at gfx perf whilst scrolling - \o/
- Many things have been fixed, please check it out!
- Firefox Theming survey summary worked out together with Jared
- Interesting outcomes:
- In-browser theme editor
- Accessibility (bigger text, icons, etc)
- Be able to customize all the things, but keep it super-duper-easy please.
- Next step:
- Conclusions from survey outcomes and other data sources
- Meetup with UX
- Interesting outcomes:
- Reviews done wrt Session Store
- About half of my queue, usually.
- Gettin' dimmed highlighting mode ready to ship!
- Stephen
- Verdi I'd like to propose a few more followups to the bookmarks work. Do people have other opinions? Should we talk about it? Do we need a new meta bug or can this block https://bugzilla.mozilla.org/show_bug.cgi?id=1219810 "Make bookmarks easier to understand"?
- I think we should limit the panel auto-closing to the “click the star” case as suggested here https://bugzilla.mozilla.org/show_bug.cgi?id=1290011#c18
- We should make the bookmarks toolbar hide if you change your mind while filing a bookmark https://bugzilla.mozilla.org/show_bug.cgi?id=1293349
- And we should default all new bookmarks to the other bookmarks folder no matter how they are created https://bugzilla.mozilla.org/show_bug.cgi?id=1120110
- pdol
- Philipp
- Dao
- Roundtable
Sep 6
- GIF du jour: *poke* don't forget the GIF!
- Status updates
- Dao
- High Contrast issues
- regression from bug 1022573: Bug 1297806 - 15% linux cart regression
- UX help needed to replace menuPanel.png with an SVG
- in review:
- Bug 1022588 - The search button in the search box in about:home is not recognizable (no image/content visible) when using High Contrast mode
- Bug 1022604 - Customize Mode's exit button should be more legible in High Contrast mode
- needs shorlander review
- landed:
- regression from bug 1022601: Bug 1299211 - Identity block icon becomes black when animating with camera/mic
- Bug 1298659 - Remove hardcoded colors from searchbar.css and make it more consistent across platforms
- Bug 1263171 - Identity box text for internal pages is unreadable on dark themes in Nightly/Aurora
- regression from bug 1022573: Bug 1297806 - 15% linux cart regression
- misc
- in review: Bug 1162441 - [HiDPI] Separator between toolbars and content is sometimes too thick at 125% scale
- landed: Bug 1224732 - [HiDPI] tab separators are sometimes too thick
- regression: Bug 1300410 - Pinned tab separators shouldn't touch the toolbar
- reviewed, landing soon
- regression: Bug 1300734 - [HiDPI] tabs sometimes move on hover at 125% scale
- has patch
- regression: Bug 1300410 - Pinned tab separators shouldn't touch the toolbar
- High Contrast issues
- Gijs
- Automigration stuff...
- Moving to get an experiment running on beta 50
- Final work for funnelcakes for automigration:
- Related: making chrome migration work when Chrome is running (!)
- Misc:
- Nightly regression with IP-as-search detection
- Search suggestions don't work if you turn off interpreting single words as searches:
- Slowly migrating stuff from one Windows machine to another. :-\
- Automigration stuff...
- Jared
- Fixed bug 1218937 - Opening preferences from the app menu no longer switches to the General tab while switching to an existing about:preferences
- Ramped up student team that will be tackling bug 1091592 to improve the styling of the <select> menu dropdown
- 👍
- Sent out a survey regarding new theme API.
- https://goo.gl/forms/qUqQ4cAJ3oJueD5c2
- Sent to add-on and theme developers, as well as posted to newsgroups
- Currently have 236 replies: 21% lightweight theme devs, 22% XUL theme devs
- https://www.reddit.com/r/firefox/comments/50twnh/what_if_you_could_reinvent_firefox_theming/ has good discussion too
- Mike de Boer and I will be meeting tomorrow to go through the survey responses and post our summary to https://github.com/mozilla/firefox-themes/tree/master/notes
- Mike
- Sailing Nationals happened, finished 7th :-(
- https://bugzilla.mozilla.org/show_bug.cgi?id=1290914
- Final part before re-enabling modal find-in-page
- Adding Element.animate to AnonymousContent API
- Required help from smaug, bz and peterv to get WebIDL stuff sorted :P
- Help from mstange: awesome perf improvements!
- No more dynamic stylesheet insertion --> inline styles FTW!
- Things are looking very bright for Fx 51 now.
- Survey for themes was sent out by Jaws, I helped.
- Prefs: findbar.highlightAll and findbar.modalHighlight
- Stephen
- Verdi
- pdol
- Almost finished test plan for Session Restore functionality. Feedback welcome.
- Philipp
- Hello again! \o/
- Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1300723 (touch interactions with text)
- Commented on https://bugzilla.mozilla.org/show_bug.cgi?id=1298449 (zoom indicator hover state)
- What's the status on panel animation jankyness? (related to https://bugzilla.mozilla.org/show_bug.cgi?id=1259803)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1009116 is tracking the work to fix some of the craziness of how we calculate the final height of the panel during the transition. This is the largest piece of front-end work to track the panel animation jankyness. A work-in-progress patch is on the bug but there remain questions for dholbert/dbaron about a bug in layout. Paolo is working on the bug and we hope to have more information once we get some more feedback from layout people. I will see if I can help Paolo by getting some more logs during panel opening.
- https://bugzilla.mozilla.org/show_bug.cgi?id=1296658 is tracking a Graphics bug that is causing a couple frames to get dropped during panel animation. The patch has r+ and looks ready to land (added needinfo to ask why it hasn't landed in the last week).
- https://bugzilla.mozilla.org/show_bug.cgi?id=1293242 has a patch that is supposed to fix a long-standing bug with height calculation of XUL flexbox and overflow:hidden. There are three tests that are failing due to the patch that need to be fixed. Neil, who wrote the patch, can't reproduce the failing tests locally. I (jared) will see if I can reproduce the test failures.
- Dao
- Roundtable
Aug 30
- GIF du jour: *yawn*
- Status updates
- Dao
- High Contrast issues
- Bug 1022601 - Site identity emblem and notification icons in urlbar are broken in High Contrast mode
- regression: Bug 1295502 - 2.1 - 4.09% tart / tresize / tsvgx (linux64, windows7-32, windows8-64) regressions
- landed
- regression: Bug 1295502 - 2.1 - 4.09% tart / tresize / tsvgx (linux64, windows7-32, windows8-64) regressions
- Bug 1022573 - Australis widget icons lack contrast when using High Contrast mode
- regression: Bug 1297806 - 15% linux cart regression
- UX help needed to replace menuPanel.png with an SVG
- regression: Bug 1297806 - 15% linux cart regression
- Bug 1022604 - Customize Mode's exit button should be more legible in High Contrast mode
- in review
- Bug 1298659 - Remove hardcoded colors from searchbar.css and make it more consistent across platforms
- in review
- Bug 1022601 - Site identity emblem and notification icons in urlbar are broken in High Contrast mode
- misc
- Bug 1296361 - Implement shadow behind arrow panels across platforms
- landed
- Bug 1297157 - Abstract away the visuallyselected attribute on anonymous tab nodes
- landed
- Bug 1292593 - Search bar and address bar autocomplete popups have no border
- landed, uplift approval pending
- Bug 1296361 - Implement shadow behind arrow panels across platforms
- High Contrast issues
- Gijs
- Alllll the automigrate
- PTO, catching up (again...)
- Jared
- Reviewed new video controls patch from raylin
- Reviewing and looking more at the panel performance issues
- Any updates from Katie's last week:
- Katie's presentation is up on airmozilla
- Some follow-up work from the zoom indicator and start menu tiles still
- I'm going to look in to the start menu tile not updating on some platforms, might need to make some more installer changes
- Mike
- Many find toolbar issues were fixed for the new modal highlighting feature
- Will be re-enabled this week, probably tomorrow.
- Four patches up - the ones from today are quite awesome ;-)
- Jared & Mike scheming and brewing plans for Firefox Themes
- Watch your inboxes this week!
- Many find toolbar issues were fixed for the new modal highlighting feature
- Stephen
- Verdi
- pdol
- [Read only due to conflict]
- Drafted test plan for Session Restore functionality. Feedback welcome.
- https://docs.google.com/document/d/1KLVhbeovQAc-B-M95jx5UdTXRzte3WvGsK6Le0UqrF0/edit
- Erica will pick it back up for doing a Shield study
- Dao
- Roundtable
Aug 23
- GIF du jour: mmm, cake! http://i.imgur.com/FUN0U5m.gifv
- Status updates
- Dao
- High Contrast issues
- Bug 1022601 - Site identity emblem and notification icons in urlbar are broken in High Contrast mode
- regressions:
- Bug 1294994 - EV cert makes all icons in the identity block green
- landed
- Bug 1295038 - Site identity circle and certificate owner are shifted to the left when hovering over the location bar with resolution at 125%
- landed
- Bug 1295502 - 2.1 - 15.83% cart / tart / tresize / tsvgx (linux64, windows7-32, windows8-64) regression
- investigating
- Bug 1294994 - EV cert makes all icons in the identity block green
- regressions:
- Bug 1293967 - Use --panel-separator-color instead of hsla(210,4%,10%,...) more consistently
- landed
- regressions:
- Bug 1295929 - Don't use --panel-separator-color for .panel-subviews' border
- landed
- Bug 1297091 - Application Menu Panel Footer Looks Wrong
- landed
- Bug 1295929 - Don't use --panel-separator-color for .panel-subviews' border
- Bug 1022604 - Customize Mode's exit button should be more legible in High Contrast mode
- in review
- Bug 1296861 - [control center] Don't hardcode colors for the permission status and permission removal button
- landed
- Bug 1022601 - Site identity emblem and notification icons in urlbar are broken in High Contrast mode
- misc
- Bug 1295947 - Use filter and fill properties instead of duplicating lots of SVG and CSS for the tab audio icon
- landed
- Bug 1296361 - Implement shadow behind arrow panels across platforms
- needs test_arrowpanel.xul fix
- Bug 528005 - Let accel-click and middle-click on the new tab button open a new tab next to the current one
- landed
- Bug 1296863 - Stop disabling the "New Tab" command in popups
- landed
- Bug 1297157 - Abstract away the visuallyselected attribute on anonymous tab nodes
- in review
- Bug 1295947 - Use filter and fill properties instead of duplicating lots of SVG and CSS for the tab audio icon
- High Contrast issues
- Gijs
- Automigration stuff
- https://bugzilla.mozilla.org/show_bug.cgi?id=1289231 - show undo notification bar
- https://bugzilla.mozilla.org/show_bug.cgi?id=1289906 - more telemetry + remove undo state when user signs into sync
- https://bugzilla.mozilla.org/show_bug.cgi?id=1289436 - more telemetry
- prepping uplifts
- Regressions I caused over the last few weeks:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1296907 - mac window control buttons 1px (1!) too low in private browsing mode...
- landed
- https://bugzilla.mozilla.org/show_bug.cgi?id=1279650 - error in console when some requests time out
- landed
- https://bugzilla.mozilla.org/show_bug.cgi?id=1296907 - mac window control buttons 1px (1!) too low in private browsing mode...
- Automigration stuff
- Jared
- Fixed bug 1294885 - The bookmarks toolbar doesn't have enough padding from the edge of the window
- Spending a lot of time digging in to panel animation jank
- Converted bug 1252224 to a meta bug
- Neil has a patch in bug 1293242 to deal multiline xul:descriptions
- Bas has a patch in bug 1296658 to speed up the expensive paint during panel opening
- I've been working on bug 1296442 to remove the style flush during panel opening
- Converted bug 1252224 to a meta bug
- Katie
- My last full day is today
- However, I'd like to finish the bugs I have/am working on
- I'll be doing a presentation on my internship this Friday at around 9am PST
- Bug 1283909 - Create logo images to support hidpi and high-contrast displays for Windows 10 start menu tile
- landed!
- Bug 1171746 - Some panels stay open when switching or closing tabs
- landed!
- Bug 1219725 - Add a button for session restore to the tab bar
- Still working on feedback from Gijs and Jared, I hope to submit another version this afternoon
- My last full day is today
- Mike
- Stephen
- Verdi
- pdol
- Form Autofill work breakdown progressing
- Planning a work week in Taipei
- Attempting to define UITelemetry needs across desktop
- If you have open questions that could be answered via UITelemetry instrumentation, please let me know
- Form Autofill work breakdown progressing
- Dao
- Roundtable
- Verdi - Is it possible to start moving on "auto-refresh" https://bugzilla.mozilla.org/show_bug.cgi?id=1268708 while still working on automigration? Nearly half of the onboarding user flows are dependent on this.
Aug 16
- GIF du jour:
- Status updates
- Dao
- Ctrl+Tab related
- Bug 445498 - Make background of tab preview transparent on Linux
- uplifted
- Bug 1292633 - Make Ctrl+Tab panel background more opaque
- uplifted
- Bug 445498 - Make background of tab preview transparent on Linux
- High Contrast issues
- Bug 1022573 - Australis widget icons lack contrast when using High Contrast mode
- landed
- Bug 1022601 - Site identity emblem and notification icons in urlbar are broken in High Contrast mode
- landed
- dealing with regressions
- Bug 1293967 - Use --panel-separator-color instead of hsla(210,4%,10%,...) more consistently
- landed
- Bug 1022604 - Customize Mode's exit button should be more legible in High Contrast mode
- in review
- Bug 1022547 - Menu bar unreadable in High Contrast mode
- landed
- Bug 1022573 - Australis widget icons lack contrast when using High Contrast mode
- misc
- Bug 1198234 - Badged toolbar buttons with a label have too little room between the icon and the label
- needs new patch
- Bug 1289659 - [OS X] Firefox Nightly 50.0a1 shows no "Bookmarks Menu" contents when no windows opened
- landed
- Bug 1294136 - Don't use !important for -moz-appearance on toolbarseparator and menuseparator
- landed
- Bug 1198234 - Badged toolbar buttons with a label have too little room between the icon and the label
- Ctrl+Tab related
- Gijs
- Back from PTO
- will be picking back up some of the automigration work, as well as some regressions I've (semi-)recently caused.
- Jared
- Fighting with the panel jank, bug 1252224 landed and then bounced
- A simplified patch to delay setting the height until after the transition has finished introduces a noticeable height change which seems like a worse regression
- I'll file a bug about the paint being slow during panel opening, regardless of the frontend changes
- Fighting with the panel jank, bug 1252224 landed and then bounced
- Katie
- Bug 565718 - Show zoom indicator in UI if not at default zoom level
- landed!
- Bug 1283909 - Create logo images to support hidpi and high-contrast displays for Windows 10 start menu tile
- Jared and I did a lot of investigating and have a solution for creating start tiles with better resolution on HiDPI screens
- Bug 1291331 - Windows 10 start menu tile doesn't always use updated settings in firefox.VisualElementsManifest.xml. Fix is likely in comment #0
- Jared and I dug into this issue as well, it's not clear why some Win10 computers update the start tile and others don't
- I'm going to try to reach out to Microsoft to see if this a bug
- Bug 1171746 - Some panels stay open when switching or closing tabs
- Submitted a patch, but it was backed out for failing a test on Linux. Looking into why.
- Bug 1219725 - Add a button for session restore to the tab bar
- Will be wrapping this one up next since Erica's internship ended. Her patch was mostly finished.
- Bug 565718 - Show zoom indicator in UI if not at default zoom level
- Mike
- Findbar modal highlighting bugs going steady
- Thanks to :jaws for the reviews!
- Tooru-san filed regression, we fixed it together
- New look & feel
- One iterator to rule 'em all
- Huge page workaround (HTML-spec huge)
- Dynamic page support, first time ever
- Session store reviews for mconley to mitigate against crashing tabs and start browser elements remote by default
- Kick-off mtg for XUL theme replacement
- Findbar modal highlighting bugs going steady
- Stephen
- Verdi ask about data on automigration from the add-on test
- pdol
- Read only due to privsec planning meeting conflict
- Work started on Password Manager/Credentials Management Product Requirements Document
- Exec team approved a new team to be created to work on related areas (including scope beyond Firefox - ie. mobile apps)
- Dao
- Roundtable
Aug 9
- GIF du jour: http://i.imgur.com/B1mKucc.gifv
- Status updates
- Dao
- Ctrl+Tab related
- Bug 445498 - Make background of tab preview transparent on Linux
- landed
- Bug 1292049 - Ctrl+Tab gets stuck after reopening a closed tab
- landed, uplifted
- Bug 1292095 - ctrlTab._initRecentlyUsedTabs is called way too often
- landed
- Bug 1292633 - Make Ctrl+Tab panel background more opaque
- landed
- Bug 445498 - Make background of tab preview transparent on Linux
- High Contrast issues
- Bug 334598 - Buttons in print preview page are not visible in HighContrastInverse theme
- landed
- Bug 1198648 - Status bar doesn't obey Windows high-contrast theme
- landed
- Bug 1022573 - Australis widget icons lack contrast when using High Contrast mode
- in review
- Bug 1008225 - Remove fog / frost effect behind the menu bar on Windows 8
- landed
- Bug 1022601 - Site identity emblem and notification icons in urlbar are broken in High Contrast mode
- in review
- Bug 1293023 - Don't hardcode black as the text color in the downloads panel footer
- landed
- Bug 334598 - Buttons in print preview page are not visible in HighContrastInverse theme
- misc
- Bug 1292727 - Consolidate context menu navigation icon styling
- landed
- Bug 1198234 - Badged toolbar buttons with a label have too little room between the icon and the label
- has patch
- Bug 1293018 - Make arrow panels white (using -moz-field) on Linux
- landed
- Bug 1292727 - Consolidate context menu navigation icon styling
- Ctrl+Tab related
- Gijs
- (PTO until the 11th)
- Jared
- Added HiDPI images for video controls on Windows and Linux, bug 1291268
- Enabled a bunch of new eslint rules
- `mach eslint --fix`, bug 1291910
- no-else-return, bug 1291855
- no-empty, bug 1292008
- space-before-blocks, bug 1292035
- keyword-spacing, bug 1292042
- Background windows on Windows 10 now fade the tab title, bug 1172890
- [in progress, fixing a test] Removed some forced layout flushes while opening PanelUI popups, bug 1252224
- Up next
- Bug 1291457 - Use native arrow panel animations on macOS
- Bug 1036929 - Panel animations are slower on Mac than they are on Windows
- Will need to start breaking down work for Themes 2.0
- Katie
- Bug 565718 - Show zoom indicator in UI if not at default zoom level
- just submitted more css fixes for review
- Bug 1283909 - Create logo images to support hidpi and high-contrast displays for Windows 10 start menu tile
- Figured out how to get Windows tool to generate the file I need! but it breaks start menu tiles anyways :/
- Currently troubleshooting why the start menu tile only appears on some Win10 computers
- Bug 1171746 - Some panels stay open when switching or closing tabs
- patch submitted for review
- possibly next: Bug 492320 - Keyboard shortcut for "Undo close window" fails if no windows are open (and "recently closed windows" submenu hasn't been shown)
- Bug 565718 - Show zoom indicator in UI if not at default zoom level
- Mike
- Getting findbar modal highlighting ready for primetime
- Much work done on a design update and perf improvements.
- https://bugzilla.mozilla.org/show_bug.cgi?id=1291278 is meta bug that contains all blocking bugs 'till ship-ready
- Stole https://bugzilla.mozilla.org/show_bug.cgi?id=1257182 from Unfocused
- Session store reviews
- Getting findbar modal highlighting ready for primetime
- Stephen
- Verdi
- May be late/miss today's meeting.
- Meeting later today about the 64-bit installer options
- Continuing work this week more of the UX team on a larger onboarding plan. We'll start meeting with Chris More's team tomorrow to start combining ideas.
- pdol
- Just returned from PTO
- Working with Matt N on scoping for Form Autofill
- timdream
- Dao
- Roundtable
Aug 2
- GIF du jour: http://i.imgur.com/B1mKucc.gifv
- Status updates
- Dao
- Bug 1116787 - Expose preference for having Ctrl+Tab cycle through tabs in recently used order
- landed
- Bug 1290094 - Clean up Ctrl-Tab panel styling
- landed
- Bug 445498 - Make background of tab preview transparent on Linux
- in review
- Bug 1116787 - Expose preference for having Ctrl+Tab cycle through tabs in recently used order
- Gijs
- (PTO until the 10th)
- Jared
- Fixed bug 1285464 for find toolbar stealing window focus
- Bug 759252 - Use CSS animations for the loading and connecting throbbers
- Waiting on Stephen for new connecting graphic
- Fixed Bug 1289283 - The about dialog now shows "Restart to apply update" even if nag window is open
- Bug 1172890 - [UX][Windows 10] Can't tell when window is unfocused if titlebar is off
- Got feedback from dao, need to work on new patch still
- https://bugzilla.mozilla.org/show_bug.cgi?id=1252224
- Patch up for review, changes a good deal about how we size panels
- Katie
- Bug 565718 - Show zoom indicator in UI if not at default zoom level
- patch seems close to done, waiting for review
- Bug 1283909 - Create logo images to support hidpi and high-contrast displays for Windows 10 start menu tile
- Need to confirm workaround for Windows tools doesn't affect other language builds. I'm researching this now
- Bug 1171746 - Some panels stay open when switching or closing tabs
- I missed that Dao asked for more information, I'll upload that after this meeting
- Bug 565718 - Show zoom indicator in UI if not at default zoom level
- Mike
- (find in page and XUL theme stuff coming up)
- Stephen
- Verdi
- pdol
- timdream (no audio/video)
- Ray Lin is working on video control visual fresh and de-XUL, in-flight
- Fischer Liu has swept in-content perf bugs and picking on low-hanging fruits.
- Dao
- Roundtable
Jul 26
- GIF du jour: http://i.imgur.com/B1mKucc.gifv
- Status updates
- Dao
- Bug 1282267 - Window Frame Color detection routine can lead to incorrect results
- uplifted
- Bug 1287732 - Remove some event.target null checks
- fixed
- Bug 1287408 - Geolocation preferences not applied properly in Nightly
- fixed
- Bug 1282267 - Window Frame Color detection routine can lead to incorrect results
- Gijs
- PTO the next 2 weeks.
- Outreachy mentoring
- Fixed some misc. other bugs:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1286435 - automated test issue (landed)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1287980 - styling issue if you move the combined toolbar buttons (landed)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1288219 - issue with on-screen keyboard, still evaluating how to proceed there
- Still working on automigration, see deps of bug 1289172
- disabling automigration undo when people start modifying bookmarks/passwords is r+'d, needs to land (want to check fixing nits actually works... some interesting test-only issues with Preferences.jsm)
- have patches for the notification bar up as well
- working on telemetry patches, likely up today
- Jared
- Bug 1285464 - When find toolbar hides, it focuses the window
- Working on patch, will need to talk to mikedeboer
- Bug 759252 - Use CSS animations for the loading and connecting throbbers
- Waiting on Stephen for new connecting graphic
- Bug 1289283 - The About dialog shows a nonresponsive "Check for updates" button when an update has been applied and the Software Update window is open
- Patch uploaded, waiting on review from rstrong
- Bug 1172890 - [UX][Windows 10] Can't tell when window is unfocused if titlebar is off
- Review ping for dao?
- Other
- Bug 1091592 - Implement improved style for <select> dropdowns
- Discussing with mconley about mentoring the bug with students, need to meet with UX
- Bug 1251071 - "New bookmark" popup disappears if I reopen it after creating bookmark
- Will be uplifted to aurora
- Bug 1091592 - Implement improved style for <select> dropdowns
- Bug 1285464 - When find toolbar hides, it focuses the window
- Katie
- Bug 565718 - Show zoom indicator in UI if not at default zoom level
- Have solution for moving history icon, just need to fix styling issue on Linux
- Bug 1283909 - Create logo images to support hidpi and high-contrast displays for Windows 10 start menu tile
- Working on finding alternate way to create Resources.pri file, getting some unexpected behavior based on MSDN's instructions
- Any response from Microsoft? no :(
- http://stackoverflow.com/questions/38506783/why-is-makepri-exe-creating-more-than-one-resources-pri-file
- Working on finding alternate way to create Resources.pri file, getting some unexpected behavior based on MSDN's instructions
- Bug 1171746 - Some panels stay open when switching or closing tabs
- Got some feedback to work on (Thank Gijs and Dão)
- Bug 565718 - Show zoom indicator in UI if not at default zoom level
- Mike
- Back from vacation! (which was awesome, btw :-D)
- Working on getting dimmed find highlighting ready for Fx 51
- Thinking about themes...
- Stephen
- Verdi
- pdol
- https://bugzilla.mozilla.org/show_bug.cgi?id=1288219 - Virtual keyboard not displaying when touching address bar or text fields when detaching the tablet/screen from surfacebook
- Matt and I working on a Form Autofill MVP:
- Details: https://docs.google.com/spreadsheets/d/1dlY4GwyxlijhPg7tCxyqNOF-yCfO0OXVIiIhDWutgyw/edit#gid=2104927129
- Locale: en-US
- E-retailers:
- Amazon
- Walmart
- Staples
- Sears
- Macy’s
- Office Depot
- CDW Corp.
- Home Depot
- Best Buy
- Liberty Interactive (QVC.com)
- Newegg
- Costco
- E-commerce platform provider: WooCommerce, Shopify
- PTO tomorrow until Aug. 8th
- timdream
- Dao
- Roundtable
Jul 19
- GIF du jour:
- Status updates
- Dao
- Remove loading-inverted.png, use loading.png instead
- fixed
- Bug 1283812 - Stop dispatching the TabSwitched event
- landed
- Bug 1282267 - Window Frame Color detection routine can lead to incorrect results
- uplift approval request still pending
- Bug 334578 - Icons in 'Find' tool bar are not compliant with high contrast theme settings
- fixed
- Bug 1285642 - [Ubuntu] Search popup Add Engine area is too dark
- fixed, uplifted
- Bug 1287732 - Remove some event.target null checks
- landed
- Bug 1287408 - Geolocation preferences not applied properly in Nightly
- in progress
- Remove loading-inverted.png, use loading.png instead
- Gijs
- Freaking out about the weather with the rest of the UK. Seems summer is being compressed into this week and it's very warm. By British standards.
- categorized and prioritized all of Toolkit::Reader Mode, and created a cluster bug (might be split into more than one)
- Trying to come up with a plan for automigration to be released on nightly/aurora/beta
- Need to compromise on what we can reasonably achieve without spending weeks/months trying to make it perfect before we know if it has an impact.
- Explored fixing our main Chrome importing issue with history, where Chrome locks the DB:
- Fixed Panel focus bug:
- Investigating this reader mode bug:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1280888
- already went and wrote a patch for bug https://bugzilla.mozilla.org/show_bug.cgi?id=1280584 but seems that's not enough to fix.
- Diagnosed what else we need:
- XML:base is set in parser utils, which we use to sanitize the content.
- Want to talk to some sec folks before just removing that... think it should be fine but don't want to take risks.
- Also need to figure out why the <a id="foo">Text</a> anchors get stripped in reader mode
- XML:base is set in parser utils, which we use to sanitize the content.
- https://bugzilla.mozilla.org/show_bug.cgi?id=1280888
- Outreachy! Rakhi has:
- finished a patch for https://bugzilla.mozilla.org/show_bug.cgi?id=965322
- no more xp/vista/win7-style window controls in fullscreen on win8/win10
- hopefully the Windows/Linux side of https://bugzilla.mozilla.org/show_bug.cgi?id=734326
- better bookmarks toolbar styling on linux/windows (OSX hopefully coming soon, tempted to push that into a followup bug.)
- finished a patch for https://bugzilla.mozilla.org/show_bug.cgi?id=965322
- Had some external reader mode contribution! ( https://github.com/mozilla/readability/pull/300 - fixes issues on iOS, contributor patch from someone from Yandex)
- Some uplift/reviews/administrivia
- Need to file some mozreview bugs in response to https://groups.google.com/d/msg/firefox-dev/1pfVEZObQrs/fli52I0uBwAJ
- more sec bug cruft
- Jared
- Unavailable Wednesday and Thursday this week for TRIBE
- Fixed:
- Bug 1286930 - The About dialog doesn't show the Update Available or Checking for Updates if the standalone "Update Available" dialog is open
- Bug 622939 - Clicking anywhere on tab modal prompt should focus it
- Bug 1270395 - UITour info panels have incorrect top padding
- Currently:
- Spent some time yesterday investigating https://bugzilla.mozilla.org/show_bug.cgi?id=1285464
- Will resume work on https://bugzilla.mozilla.org/show_bug.cgi?id=1172890
- Katie
- Bug 1283909 - Create logo images to support hidpi and high-contrast displays for Windows 10 start menu tile
- Figuring out the documentation/computer set-up needed to generate resources.pri file, but hope to have that done this afternoon
- Bug 1171746 - Some panels stay open when switching or closing tabs
- Fixed the panels issue, but found that the edit bookmarks panel doesn't close for close window hotkey (cmd-W on Mac) and am fixing that now
- Got feedback to work on for most recent patch
- Bug 565718 - Show zoom indicator in UI if not at default zoom level
- Mostly done, but found that the zoom indicator's animation makes the history button dropdown button had to click in URL bar
- Waiting to hear more on how to avoid making history button hard to access
- [jaws] I recommend going forward with implementing the three different ideas of comment #37 and seeing which one feels best to you.
- Bug 1283909 - Create logo images to support hidpi and high-contrast displays for Windows 10 start menu tile
- Mike
- still on PTO this week
- Stephen
- Verdi
- pdol
- Form Autofill/Web Payments project scope/approval meeting tomorrow
- Form Autofill/Web Payments project scope/approval meeting tomorrow
- timdream
- Dao
- Roundtable
Jul 12
- GIF du jour: *sip* http://imgur.com/navpuPi
- Status updates
- Dao
- Bug 1278662 - Unify loading.png and loading-inverted.png design
- patch submitted
- Bug 1283812 - Find a better name for the TabSwitched event
- patches submitted
- Bug 1249818 - Top 5 pixels of tabs became completely useless: clicking them neither drag the window, nor select tab
- fixed, uplifted
- Bug 1255989 - Cannot drag window from empty space in bookmarks toolbar items when customized to the menubar
- fixed, uplifted
- Bug 1282267 - Window Frame Color detection routine can lead to incorrect results
- landed, would like to uplift
- support for Bug 906076 - Virtual tabs - lazily create linkedBrowser and other dependent elements for tabbrowser tabs to improve startup performance
- Bug 1284482 - Remove useless parameters and variable declarations from _linkBrowserToTab and _createBrowser
- Bug 1276514 - Refactor xul:browser.permanentKey implementation to accommodate lazy-browser tabs
- Bug 1278662 - Unify loading.png and loading-inverted.png design
- Gijs
- Triaging Toolkit::Reader Mode to create a qx cluster (closed over 30 bugs, categorizing others (120-ish to go) and will then mass-change for the category + prio where necessary, then do a qx cluster based on output)
- Filed followups for automigration
- Includes some work to make the chrome migrator work while chrome is open, which has interest from sqlite folks. Likely looking at this later this week. bug 1285041.
- Misc. sec bugs and others
- bug 1280472 - a11y + styling issues in prefs
- cleanup in bug 1284497 - now shipping a few kb fewer unused image cruft...
- inadvertently improved perf by fixing a sec bug (yay!)
- removed some reader mode telemetry, kept some (bug 1281536)
- Jared (might not make it, having car issues)
- Triaged Firefox:Preferences, Firefox:Tabbed Browser, and Toolkit:Video/Audio Controls
- Fixed:
- Preferences
- Bug 1278844 - Locking browser.download.folderList doesn't disable the Browse button
- Bug 1055403 - No effect of setting preference instantApply="false"
- Bug 1240439 - Edit email or password field inside Save Logins is larger then it should
- Start Menu tile followups
- Bug 1284829 - Win8/10: Globe in tile stretched
- Bug 1284827 - Win8/10: Icon not shown in start menu after bug 1232679
- Bug 1284517 - The installer needs to update the lastWriteTime of the Firefox startmenu shortcut after bug 1232679
- Video Controls
- Bug 1283415 - Empty poster attribute on video element throws an error
- Bookmarks
- Bug 1251071 - "New bookmark" popup disappears if I reopen it after creating bookmark
- On-Screen Keyboard
- Bug 1226522 - On-screen keyboard not displayed on machines without a rotation sensor (e.g. desktops with a touch screen)
- Preferences
- In Progress
- Bug 1270395 - UITour info panels have incorrect top padding
- Discussion
- Bug 1275386 - Determine impact of stub installer default browser checkbox
- Got r+ but not sure if we still are interested in determining the effect of this change?
- Bug 1275386 - Determine impact of stub installer default browser checkbox
- Katie
- Bug 565718 - Show zoom indicator in UI if not at default zoom level
- Seems close to being done, but need to fix style issue
- Bug 1283909 - Create logo images to support hidpi and high-contrast displays for Windows 10 start menu tile
- Need to do some research on on image sizes and what "high contrast" means for Windows start menu tiles
- Bug 1171746 - Some panels stay open when switching or closing tabs
- Pushed a patch for review this morning and have some feedback to work on
- Bug 565718 - Show zoom indicator in UI if not at default zoom level
- Mike
- Stephen
- Verdi I don't think a good UI for explaining automigration while you are creating an account is possible. It's a complex interaction and that complexity needs to go somewhere - the UI or the code. I think we have to solve the history undo problem to make this work.
- pdol
- Form Autofill / Web Payments PRD draft: https://docs.google.com/document/d/1Rk6SIH_O_wab1CsphHhuwmvT8gXCG-D0B0ki0R3dmC4/edit#heading=h.yvyjevnbnjwq
- Looking for engineering input on scope for Form Autofill: https://mozilla.invisionapp.com/share/GV77J3VRU#/screens/156413162
- Making Win64 default distribution
- Impact to this team?
- UI in stub installer/other areas?
- Impact to this team?
- timdream
- Ray Lin in Taipei will be looking at video control visual refresh cluster (bug 1271768). We have secured UX/VxD help in Taipei on it.
- I will be looking into improvements to in-content preferences cluster (bug 1271779). There are already Taipei UX/VxD scheduled -- will make sure they are addressing these issues (if applicable).
- Question: should I move them out of QX holding area?
- Dao
- Roundtable
Jul 5
- GIF du jour: http://i.imgur.com/MABfhTH.gifv
- Status updates
- Dao
- Gijs
- automigration add-on / funnelcake stuff
- Security bugs
- Outreachy
- Misc.
- Jared
- Just got back from vacation last week, going through emails and reviews
- tell us where you've been and what you've done! :)
- Picking up work on:
- Bug 1251071 - "New bookmark" popup disappears if I reopen it after creating bookmark
- Bug 1226522 - On-screen keyboard not displayed on machines without a rotation sensor (e.g. desktops with a touch screen)
- Bug 1270395 - UITour info panels have incorrect top padding
- Need to reply to an email from Katie about binding function arguments
- Just got back from vacation last week, going through emails and reviews
- Katie
- finished windows 8/10 start menu tile improvement
- wrapping up zoom indicator bug 565718
- starting bug 1171746 to make sure tab specific panels are cleared when tabs are switched
- Mike
- Session store knowledge accumulating, next: triage and new stuff.
- Bug 1264192 - Logged out of Twitter after restarting Nightly, narrowed down to cookie store/ Twitter bug.
- Find toolbar 'whole word' mode landed on Nightly
- Find toolbar modal highlighting pref-ed off
- We have enough feedback for now
- Sent email to Sevaan to look at design/ UX for me
- Working on bugs that were filed by many people - many thanks!!
- Few awesome colleagues from Taipei (I think) are helping out fixing bugs!
- Session store knowledge accumulating, next: triage and new stuff.
- Stephen
- Verdi
- Working on automigration. http://people.mozilla.org/~mverdi/projects/autoimport2.framer/ (refresh in the awesome bar resets the prototype)
- pdol
- Form Autofill / Web Payments PRD draft: https://docs.google.com/document/d/1Rk6SIH_O_wab1CsphHhuwmvT8gXCG-D0B0ki0R3dmC4/edit#heading=h.yvyjevnbnjwq
- Out of interest, why is this confidential?
- That was the desire of our legal team (likely because of competitor references), but we're trying to get that changed so the default is open. I agree, it's silly.
- Out of interest, why is this confidential?
- Form Autofill / Web Payments PRD draft: https://docs.google.com/document/d/1Rk6SIH_O_wab1CsphHhuwmvT8gXCG-D0B0ki0R3dmC4/edit#heading=h.yvyjevnbnjwq
- Roundtable
- When can we resume work on https://bugzilla.mozilla.org/show_bug.cgi?id=1017919 (migrating extensions with refresh) and providing a like-new experience for returning Firefox users? There are more of these people downloading Firefox every day than truly new users.
- sync issue with this: https://bugzilla.mozilla.org/show_bug.cgi?id=1276998 .
- When can we resume work on https://bugzilla.mozilla.org/show_bug.cgi?id=1017919 (migrating extensions with refresh) and providing a like-new experience for returning Firefox users? There are more of these people downloading Firefox every day than truly new users.
Jun 28
- Definitely having a meeting on the 28th!
- GIF du jour: http://imgur.com/a/slR7t
- Status updates
- Dao
- picked up bug 1255989 (Cannot drag window from empty space in bookmarks toolbar items when customized to the menubar)
- more focus on reviews
- Gijs
- Automigration stuff for a funnelcake build!
- Using the 'larch' project branch
- Landing on trunk first
- Both critical pieces (bypass dialog, https://bugzilla.mozilla.org/show_bug.cgi?id=1271775 , and undo API, https://bugzilla.mozilla.org/show_bug.cgi?id=1271799 ) have now landed on fx-team
- Behind a pref on trunk
- web team is doing some UI stuff for the 'undo' functionality
- we intend to eventually ship in Firefox proper but need more design work + polish + some more decisionmaking on how to make undo work well / interact with sync etc.
- Security bugs
- Mentoring outreachy intern Rakhi
- Miscellania, e.g.
- https://bugzilla.mozilla.org/show_bug.cgi?id=1235695 - test fixes for highly-frequent intermittents
- Automigration stuff for a funnelcake build!
- Jared
- on PTO this week!
- Katie
- Mike
- Enjoyed MozLondon lots!
- Findbar improved highlighting work continues (all blocking bug 384458). Main focus areas are:
- Design/ UX: Sevaan proposed to get involved and help out here
- QA: SoftVision is on it, already filing bugs, writing test plan, verifying fixes
- Performance: merging find count and highlighter iterators into one and more improvement underway.
- Feature currently disabled, until we polished it good.
- Bug 269442 - Add Find Whole Word/ Find Exact String Option to Find Toolbar
- Landed moments ago!
- Session store work:
- Landed some code review/ cleanup patches
- This week: Bug 1264192 - Logged out of Twitter after restarting Nightly (important, looks like regression in Fx48)
- Confidential thingy bug 1280294
- Philipp
- Stephen
- Verdi
- pdol (I may not be able to join, depending on how late my current meeting goes)
- Text Autofill / web payments
- Starting PRD draft
- Text Autofill / web payments
- Dao
- Roundtable
Jun 21
- No meeting, again because MozLondon :)
- GIF du jour anyway!
Jun 14
- No meeting, because MozLondon!
- GIF de la semaine: Tea time!
Jun 7
- GIF du jour: https://gfycat.com/TallAstonishingAustraliankestrel
- Status updates
- Dao
- Bug 1247824 - Persistent excess space in bookmark panel from folder/tag list
- it's a XUL bug
- Neil posted a patch, needs review from the other Neil
- Bug 658467 - Fade out tab label on overflow instead of ellipsis
- may need to remove text-shadow from tabs, waiting for UX opinion
- Bug 1247824 - Persistent excess space in bookmark panel from folder/tag list
- Gijs
- Had 1 day of PTO last week, will have another half-day this week
- Security bugs
- Reviews
- First draft of automatic migration patch is up (needs minor updates to add telemetry, but otherwise there)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1271775
- behind a pref
- waiting on UI design before writing undo code, which will in turn block enabling this "for real".
- Added telemetry for migration performance otherwise
- https://bugzilla.mozilla.org/show_bug.cgi?id=1275114 (fixed)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1276694 (waiting on review)
- ensure existing telemetry doesn't run out next version of nightly: https://bugzilla.mozilla.org/show_bug.cgi?id=1276699
- planning to add to MattN's dashboard on https://sql.telemetry.mozilla.org/dashboard/fx_migration to help guide more of these decisions
- Some more URL bar polish landed
- (moved house this weekend, generally somewhat wonky availability as a result)
- Jared
- Landed https://bugzilla.mozilla.org/show_bug.cgi?id=1276027 to track how often Firefox is opened via an external app handler
- Will look in to uplifting this to aurora + bet
- Working on https://bugzilla.mozilla.org/show_bug.cgi?id=1275386, patch is "done", but I plan on rewriting it to only have one histogram instead of three
- Will probably pick up https://bugzilla.mozilla.org/show_bug.cgi?id=1226522 again
- Am planning on investigating https://bugzilla.mozilla.org/show_bug.cgi?id=1278354 and https://bugzilla.mozilla.org/show_bug.cgi?id=1278350
- Landed https://bugzilla.mozilla.org/show_bug.cgi?id=1276027 to track how often Firefox is opened via an external app handler
- Katie
- Working on zoom indicator in location bar, patch should be up for review later today
- Got a question answered about Windows 10 tiles and will work on that once zoom indicator work has completed
- Mike
- Philipp
- Stephen
- Verdi
- pdol
- XP EOL data: https://drive.google.com/open?id=0B12g_7yjbdYJN1ZZTUdZbERaRWM
- Text Autofill / web payments
- UX early spec: https://mozilla.invisionapp.com/share/GV77J3VRU#/screens/156413164
- Currently running heartbeat survey
- Looking at web payments as 2nd phase, based on Web payments working group: https://www.w3.org/Payments/WG/
- Firefox attrition study
- Will be doing an attrition study in Q3 through Strategy&Insights team
- Dao
- Roundtable
May 31 -- NO MEETING DUE TO MONTHLY MOCO MEETING AT SAME TIME (but please still post your read-only updates!)
- GIF du jour: 😂👌
- Status updates
- Dao
- Bug 658467 - Fade out tab label on overflow instead of ellipsis
- may need to remove text-shadow from tabs, waiting for UX opinion
- Bug 1257087 - Middle mouse click on history item would not open
- landed, uplifted
- Bug 1247824 - Persistent excess space in bookmark panel from folder/tag list
- investigating
- Bug 658467 - Fade out tab label on overflow instead of ellipsis
- Gijs
- Jared
- Mike
- Philipp
- Stephen
- Verdi
- pdol
- Dao
May 24
- GIF du jour: *rawr* https://i.imgur.com/89SWV2w.gifv
- Status updates
- Dao
- Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder
- landed, backed out because of a leak, re-landed today
- Bug 658467 - Fade out tab label on overflow instead of ellipsis
- background-clip:text backend has been re-implemented
- perf regressions seem to be less random and less catastrophic but still not perfect
- summary: https://bugzilla.mozilla.org/show_bug.cgi?id=658467#c42
- Bug 1257087 - Middle mouse click on history item would not open
- picking this up
- Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder
- Gijs
- Startup automigration:
- met with verdi & dolske to make some decisions re: how to pick a browser / data to migrate.
- looking at telemetry to hit 48 so we can validate/revise said decisions based on data
- Still dealing with uplifting private browsing & other things that need uplifting
- url bar changes from last week looking good, going to do a bunch of uplift requests later today
- tabsintitlebar improvements have uplift requested
- reviews, hopefully last e10s test changes, some sec bug stuff, ...
- add-ons and fx-refresh: on hold until startup stuff is up.
- Startup automigration:
- Jared
- default browser investigations continuing
- no reply from metrics about the data we have been asking for
- dolske is going to escalate the request
- i'm going to spend today learning how to read the data myself
- default browser investigations continuing
- Mike
- patches up for review for find-in-page
- Philipp
- Stephen
- Verdi
- Removing current first run pages https://bugzilla.mozilla.org/show_bug.cgi?id=1274627 and https://bugzilla.mozilla.org/show_bug.cgi?id=1274633
- Removing default opt-out checkbox https://bugzilla.mozilla.org/show_bug.cgi?id=1272162
- Design for new first run page with pinning and default browser instructions
- pdol
- Decision on EOL'ing XP
- Compiling data relevant to making decision: https://docs.google.com/document/d/1EyO-F6A7Kkqe00usMglcAfJnw9yby-3DxiA8jzdgazQ/edit
- External sources
- Metrics/telemetry
- Compiling data relevant to making decision: https://docs.google.com/document/d/1EyO-F6A7Kkqe00usMglcAfJnw9yby-3DxiA8jzdgazQ/edit
- Text Autofill
- Early definition of scope/goals: https://docs.google.com/document/d/1QtyaF0rGqTtqxl1hcIhD-X_i1vNCPJO9Xo10CosdLCg/edit
- Investigations to understand why users defect to other browsers
- Using user recruiting, surveys, interviews
- MAU/DAU survey: https://docs.google.com/document/d/1k7wVCzsiBXbTvASf2A22jR6xxTOJ4atDcOJQgyD3K0I/edit
- Noteworthy correlations between heartbeat rating and use of alternate browsers (in addition to Firefox)
- AI: Peter to reach out to Patrick Finch, Kadir
- Decision on EOL'ing XP
- Roundtable
- Dao
May 17
- GIF du jour: the care and feeding of gecko http://i.imgur.com/cd2ZdZ6.gifv
- Status updates
- Dao
- Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder
- has patch
- Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder
- Gijs
- URL bar changes produced 1 regression so far: https://bugzilla.mozilla.org/show_bug.cgi?id=1272317
- finished a patch today, r?mconley
- 1 regression is less than I was expecting... will do a sweep through new Fx bugs filed in the last week after this change lands and then request aurora uplift per requests from e10s team.
- add-ons and fx refresh:
- popped another yak! We now have automated test coverage for fx refresh in the marionette framework
- Have the beginnings of a patch for add-ons being included in refresh
- slowly pivoting to...
- initial migration stuff
- https://bugzilla.mozilla.org/show_bug.cgi?id=1248077 and its deps
- still need to sort out some details with Verdi but likely going to start implementing late this week / beginning of next week, behind a pref
- needs design work! https://bugzilla.mozilla.org/show_bug.cgi?id=1271778
- specifically: how to tell the user "we just imported your data from browser X / browsers X and Y"
- how to offer the user the possibility to undo the import
- Was also contacted by Schalk Neethling for help with their add-on work to also look at some of this.
- Slightly confused because it seems their aim is to do more prompting of the user about this... can someone clarify?
- https://bugzilla.mozilla.org/show_bug.cgi?id=1248077 and its deps
- Misc stuff:
- Issues with tabs-in-titlebar in e10s mode where we race browser startup on OS X:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1269462
- fixed, but that then regressed windows 10:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1273094
- waiting on clarification from platform-folks. Don't want to keep hacking around weirdness (cross-ref: https://bugzilla.mozilla.org/show_bug.cgi?id=1005098 ).
- https://bugzilla.mozilla.org/show_bug.cgi?id=1273094
- fixed, but that then regressed windows 10:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1269462
- Improved mochitest output when it times out and kills the process to clarify what's going on:
- e10s test fix waiting for r?mikedeboer - https://bugzilla.mozilla.org/show_bug.cgi?id=1246664
- followup items about fx refresh that were uncovered as part of the add-on stuff
- still in progress
- we're overzealous getting search engine telemetry - https://bugzilla.mozilla.org/show_bug.cgi?id=1272294
- need to update patch based on data folk feedback + failing tests on try
- Issues with tabs-in-titlebar in e10s mode where we race browser startup on OS X:
- URL bar changes produced 1 regression so far: https://bugzilla.mozilla.org/show_bug.cgi?id=1272317
- Jared
- Fixed:
- Bug 962560 - Audio volume UI resets to full volume after toggling the screen size of a video
- Bug 1271626 - gUIStateBeforeReset has an erroneous property of gUIStateBeforeReset
- Bug 1271742 - Rename currentLineHeight to currentContentWidth in AboutReader.jsm
- Bug 862399 - Add UI to loop playback of audio files
- Bug 1271976 - Audio controls disappears after a delay once volume slider changed
- Bug 449358 - Add test to confirm that video/audio UI controls function when JavaScript is disabled
- Bug 1268943 - Middle mouse click on links in settings does nothing (should open in new tab)
- Outreachy:
- Bug 1061747 - Restore Defaults does not reset current theme
- In progress, Katie took a couple days off last week, should have something ready this week.
- Next bug will be bug 1232679 - Improve Start Menu tile on Windows 8/10
- Bug 1061747 - Restore Defaults does not reset current theme
- Poking:
- Bug 1143116 - Don't show Default Browser prompt on first run
- Working half-time this week, Wednesday thru Friday
- Fixed:
- Mike
- Two days of PTO; one last week and yesterday!
- Recently Bookmarked list: https://bugzilla.mozilla.org/show_bug.cgi?id=1248267 is failing a test
- I'll fix that tomorrow to get it ready to land
- Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1270174 and was fixed by jwatt
- Jonathan is my latest hero.
- We can now have complex SVGs inside the Canvas Frame (anonymous content)
- Got https://bugzilla.mozilla.org/show_bug.cgi?id=384458 working
- Highlighting of found ranges, Safari-style.
- Works using a complex SVG mask inserted as anonymous content
- Worked on Win & Lin HiDPI icons at https://bugzilla.mozilla.org/show_bug.cgi?id=1271680
- Will review Gijs' patch after the meeting ;-)
- I'll spending a considerable amount of time in session-(re)store land.
- Collaborated with :timdream on getting Emoji fonts shipped
- We need product-decision-maker to move it forward
- Philipp
- Stephen
- Verdi
- Tim (read-only)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1231701 Ship an Emoji font on Windows <8.1 (& Linux)
- Decision needed to make this depend on a Desktop DLC or bundling with the installer (the current patch).
- Also, ship Firefox Emoji v.s. Emoji One
- https://bugzilla.mozilla.org/show_bug.cgi?id=1231701 Ship an Emoji font on Windows <8.1 (& Linux)
- Dao
- Roundtable
- Upcoming QX work - qx-feedlot https://bugzilla.mozilla.org/show_bug.cgi?id=1270272
- Can I nominate some about:reader / reader mode work?
- Mike's awesome find-in-page demo :) That WAS awesome
- Upcoming QX work - qx-feedlot https://bugzilla.mozilla.org/show_bug.cgi?id=1270272
May 10
- GIF du jour: Jared fixing bugs: http://imgur.com/JhUiLu4 (+1)
- This has been all the hype lately: http://www.imdb.com/title/tt4060576/
- Status updates
- Dao
- Bug 1267939 - Back out bug 1219804 from Aurora 48
- landed
- Bug 1250203 - Re-populate recent bookmarks when a bookmark gets deleted while the menu is open
- landed with workaround for bookmarks observer leak
- Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder
- picking this up again
- Bug 658467 - Fade out tab label on overflow instead of ellipsis
- getting new perf numbers
- Bug 1267939 - Back out bug 1219804 from Aurora 48
- Gijs
- bug 1241085 - url bar changes landed and seem (fingers crossed) to have stuck. In tomorrow's nightly if all goes well
- add-ons and fx-refresh:
- We have popped a yak: changes to fx refresh have landed
- Waiting for review on the test. Marionette runner portion already has r+, just need the test itself r+'d
- We have popped a yak: changes to fx refresh have landed
- Misc things:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1270707 - formatting in LaterRun (second/nth run pages)
- requested uplift on this per discussion.
- https://bugzilla.mozilla.org/show_bug.cgi?id=1270886 and https://bugzilla.mozilla.org/show_bug.cgi?id=1270148 - issues with the border color of the search bar on Windows + Linux
- https://bugzilla.mozilla.org/show_bug.cgi?id=1269238 links in the about: dialog were unclickable after a security fix I wrote
- Some more private browsing refresh fallout
- Reviews, more reviews, more reviews...
- https://bugzilla.mozilla.org/show_bug.cgi?id=1270707 - formatting in LaterRun (second/nth run pages)
- Jared
- Patch up for review to make background windows on Windows 10 faded out (bug 1269120)
- Investigated start tile possibilities (bug 1232679)
- Triaging video controls bugs, started at 136 bugs now down to 109 bugs
- Will be triaging in-content prefs
- Will be spending time thinking about Windows 10 features that we are missing/lacking in
- Could use native notifications on Windows 10 as opposed to XUL
- Home/Lock Screen notifications
- Start tile improvements
- Matching Windows 10 animation styles
- increased padding in context menus
- tablet mode stuff - note that tablet mode usage seems comparably really low, so not sure to what degree that's useful
- global back button
- Mike
- https://bugzilla.mozilla.org/show_bug.cgi?id=896304
- HiDI icons for findbar on OSX (bug 1271680 will deal with Win & Lin)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1270943
- Social API tests weren't enabled in e10s mode - will be fixed soon
- https://bugzilla.mozilla.org/show_bug.cgi?id=1248267
- Fifth version patch up for review.
- https://bugzilla.mozilla.org/show_bug.cgi?id=384458
- Dim/ highlight find results better - work now blocked by https://bugzilla.mozilla.org/show_bug.cgi?id=1270174
- Looking into Linux QX backlog items
- goal: make it a cluster
- https://bugzilla.mozilla.org/show_bug.cgi?id=896304
- Stephen
- Verdi
- Onboarding outcomes https://docs.google.com/presentation/d/1MZastaUJSm7It3RKyAcNLa5eoo8zpV1xFYOu2g1hL6Q/edit#slide=id.g12c3258251_0_2
- Returning users https://bugzilla.mozilla.org/show_bug.cgi?id=1268708
- Auto-import data from other browsers https://bugzilla.mozilla.org/show_bug.cgi?id=1248077
- Tim (read-only)
- Team has moved on to Fennec, Fennec about: pages, and Control Center bugs. Will keep QX in backlog.
- Bug 1231701 - Ship Firefox Emoji on Windows < 8.0 and Linux
- Fixing broken MOZ_BUNDLE_FONTS on DWrite font rendering backend (see dependencies).
- pdol (Peter Dolanjski)
- New Product Manager on team
- Officially joining June 6th
- Fly on wall for now
- Initial focus: Decision on XP support, Form Autofill, Onboarding, more TBD
- Dao
- Roundtable
May 3
- GIF du jour:
- Status updates
- Dao
- Bug 1265173 - Increase toolbarHighlight opacity again to a more reasonable level
- landed, uplifted
- Bug 1267939 - Back out bug 1219804 from Aurora 48
- still waiting for approval
- Bug 1248268 - Unable to disable "Recently bookmarked"
- landed
- Bug 1250203 - Re-populate recent bookmarks when a bookmark gets deleted while the menu is open
- patch updated after bug 1248268, needs fresh try run, probably still suffers from the leak
- Bug 1119455 - Favicon gets discarded, re-decoded and repainted when moving the mouse pointer over a tab
- wrote a patch that avoids the bug but breaks the tabs' onerror handler
- needs Gecko fix or WONTFIX until we implement the tab strip without XUL
- Bug 658467 - Fade out tab label on overflow instead of ellipsis
- getting new perf numbers
- Bug 1265173 - Increase toolbarHighlight opacity again to a more reasonable level
- Gijs
- Fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1241085 (URL bar clearing when opening new (private) window/tab and typing immediately) has review
- ... but has failing tests that I can't reproduce on Windows.
- Reproduced on mac 10 minutes before this meeting. Need to diagnose why it's broken. Could be easy to fix, could mean I need to rethink approach... :-\
- ... but has failing tests that I can't reproduce on Windows.
- Still talking with Matt about approach in https://bugzilla.mozilla.org/show_bug.cgi?id=1265368 (default profiles vs. fx reset)
- Investigating/reviewing in bug 1119455 (see Dão's update)
- dolske just made an interesting suggestion there.
- Dealing with fallout from bugs I fixed or reviewed
- Some PTO (some more incoming.)
- Fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1241085 (URL bar clearing when opening new (private) window/tab and typing immediately) has review
- Jared
- Bug 1095739 - fixed, Allow a "new user" experience to happen subsequent to Firefox being uninstalled
- Bug 1268159 - fixed, All of the strings in Firefox now use curly quotes
- Patches in progress for:
- in progress [Katie Broida] Bug 1061747 - Restore Defaults does not reset the current theme
- checkin-needed [Katie Broida] Bug 1093750 - Toolbar items should have tooltips in Customize Mode
- tracking down a gtk3 crash [Katie Broida] Bug 1260595 - All items in Themes panel are duplicated if I exit customize with the panel opened (should close/empty panel when leaving customize mode)
- in progress [Dan Huang] Bug 1126967 - [reader mode] [UX] improve the loading transition
- Mike
- Bug 1248267 - Right click on bookmark item of "Recently Bookmarked" should be regular placescontext instead open it
- found a way to show a context menu after all
- waiting for review
- Planning to work on 'Bug 1248616 - 5 most recently added bookmarks should be draggable' after the aforementioned bug
- Bug 269442 - Add Find Whole Word/ Find Exact String Option to Find Toolbar
- Finally got around to write a unit test for it
- Code complete, final round of review
- Ehsan might be too busy - hopefully not!
- Bug 1269677 - mousethrough=always doesn't work on the APZ-enabled browser stack
- Filed this, got immediate reply that `pointer-events: none;` does the same thing!
- Awesome! XUL--
- Bug 266338 - Better (more visible) indication of when Find has wrapped or will wrap
- https://vimeo.com/162972088 proposed UX, inspiration from iTerm OSX app
- Not taking the bug per sé, pitching an idea
- Bug 384458 - find toolbar should highlight better/dim rest of page
- Unbitrotted previous patch
- Converted highlight code to use an inverted SVG mask
- Cuts out rectangles out of a full-width and full-height colored rectangle
- Up next:
- Move all code to the content process, using https://wiki.mozilla.org/DevTools/Highlighter#Creating_new_highlighters (kudos, Gijs!)
- Create a separate module for the highlight iterator and move the code from Finder.jsm to it
- Bug 1248267 - Right click on bookmark item of "Recently Bookmarked" should be regular placescontext instead open it
- Philipp
- Stephen
- Verdi
- Tim
- Dao
- Roundtable
- [jared] Reopen/Undo Close Tab as a button in context?
- GTK3 regressions?
- ++ (from Gijs) -- there's a lot of stuff in there (radio and checkboxes are invisible, scrollbars are (half-)busted, ... it's not very nice)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1262136
- Seems to depend on a very big patch to add support for GTK3.20 "Node" things. Not sure if we have lower-impact ways of fixing for 47 (see dep).
- https://bugzilla.mozilla.org/show_bug.cgi?id=1269523
- https://bugzilla.mozilla.org/show_bug.cgi?id=1268462
- And some more stuff explicitly in Widget::gtk3
- https://bugzilla.mozilla.org/show_bug.cgi?id=1244305 <-- crash when dealing with downloaded files
- https://bugzilla.mozilla.org/show_bug.cgi?id=1262136
- ++ (from Gijs) -- there's a lot of stuff in there (radio and checkboxes are invisible, scrollbars are (half-)busted, ... it's not very nice)
Apr 26
- GIF du jour: *monkeyhug*
- Status updates
- Dao
- gonna backout "Recently bookmarked" UI from Aurora to finish followups and bundle it with other bookmark related changes
- Bug 1265017 - Make Bookmarks > "Other Bookmarks" open a sub menu and move it after "Bookmarks Toolbar"
- landed
- Bug 1248268 - Unable to disable "Recently bookmarked"
- waiting for review
- Bug 1250203 - Re-populate recent bookmarks when a bookmark has been deleted
- leak might be another bug in the bookmarks observer backend
- code changes overlap with bug 1248268, now trying to get that done first
- Bug 658467 - Fade out tab label on overflow instead of ellipsis
- no progress
- Gijs
- Can't make the mtg today
- Still slogging away on url bar things
- Tests have now moved. \o/
- Left a note in fx-desktop meeting - there are other groups of tests that would benefit from moving into their own directories
- Latest in https://bugzilla.mozilla.org/show_bug.cgi?id=1267289
- Fixed https://bugzilla.mozilla.org/show_bug.cgi?id=1266475
- Slowly getting to actually fixing https://bugzilla.mozilla.org/show_bug.cgi?id=1241085
- Tests have now moved. \o/
- Work on addon refresh/migration stalled on reviews 2 yaks deep. Matt r-'d current patch to allow refreshing non-default profiles, need to talk with him about that. Either tonight or tomorrow.
- Met with Verdi to discuss Firefox refresh work
- Fixed one of the top intermittents related to some e10s work: https://bugzilla.mozilla.org/show_bug.cgi?id=1257750
- Reviews, reviews, more reviews.
- Jared
- Decoder doctor work landed (bug 1160424)
- We now have accessibility (keyboard) support in Customization mode (bug 1116578)
- Katie has a fix for toolbar items not having tooltips in customize mode (bug 1093750)
- Katie has a fix for duplicate items in the Themes menu but it crashes on Linux (bug 1260595)
- I tried to set up a new Linux VM to use with rr but VirtualBox fails to start up on latest Windows 10 Insider builds
- https://www.virtualbox.org/ticket/15337
- Fixed in build from 6 hours ago, need to download it and try with that
- https://www.virtualbox.org/ticket/15337
- I tried to set up a new Linux VM to use with rr but VirtualBox fails to start up on latest Windows 10 Insider builds
- I picked up bug 1095739 again, which is to advertise Refresh Firefox to users who uninstalled and reinstalled Firefox
- Mike
- Reviewed a few things :-)
- Made a list for a fresh QX cluster: findbar
- Working on Recent Bookmarks feature follow-ups
- Landed Windows layout issue fix ( https://bugzilla.mozilla.org/show_bug.cgi?id=1250828 )
- I think I've got a good plan for context menus ( https://bugzilla.mozilla.org/show_bug.cgi?id=1248267 )
- Could be beneficial for 'disable feature' and 'support drag-n-drop' bugs
- Philipp
- Stephen
- Verdi
- Tim
- The team is moving on to different clusters QX bugs; mostly still working on mentor bugs
- bug 1266372 bug 1184950 bug 1264805 (reader mode)
- bug 1229727 (full screen notification)
- bug 995758 (address bar focus)
- Feel free to ni me on bugs and I will get them distributed
- The team is moving on to different clusters QX bugs; mostly still working on mentor bugs
- Dao
- Roundtable
Apr 19
- GIF du jour: A) forest fire B) disco C) psyfox D) all of the above. http://imgur.com/CWKNtbj
- Status updates
- Dao
- won't make it (conflicting meeting)
- bug 1248617 (Stop adding the "Recently bookmarked" smart folder in new profiles)
- landed
- bug 1250203 (Re-populate recent bookmarks when a bookmark has been deleted)
- tried to land and bounced again, need to investigate a leak
- bug 1265017 (Make Bookmarks > "Other Bookmarks" open a sub menu and move it after "Bookmarks Toolbar")
- has patch, waiting for review
- bug 658467 (Fade out tab label on overflow instead of ellipsis)
- wrote a patch, has significant perf issues with unclear way forward
- Gijs
- Finished e10s test stuff \o/
- Shaving all the yaks for add-on migration in Fx Refresh ( https://bugzilla.mozilla.org/show_bug.cgi?id=1017919 )
- Wanted tests first ( https://bugzilla.mozilla.org/show_bug.cgi?id=888624 )
- Wanted to let you do reset on non-default profiles so writing tests isn't so much of a pain ( https://bugzilla.mozilla.org/show_bug.cgi?id=1265368 )
- waiting for review
- Wanted to let you do reset on non-default profiles so writing tests isn't so much of a pain ( https://bugzilla.mozilla.org/show_bug.cgi?id=1265368 )
- Wanted tests first ( https://bugzilla.mozilla.org/show_bug.cgi?id=888624 )
- url bar work (cluster 1247816)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1199934 - repeated hash changes breaking the location bar (landed yesterday)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1265055 - moving tests into their own dir to make testing situation better
- some semi-related security work (url bar spoofing)
- Investigating https://bugzilla.mozilla.org/show_bug.cgi?id=1241085 and https://bugzilla.mozilla.org/show_bug.cgi?id=1249362
- tab browser tab closing / beforeunload madness fix: https://bugzilla.mozilla.org/show_bug.cgi?id=1238032
- Jared
- Finished e10s test stuff too \o/
- Working on decoder doctor
- lots of reviews
- Mike
- Philipp
- Stephen
- Verdi
- Dao
- Roundtable
Apr 12
- No QX meeting due to conflict with Firefox PLR review.
Apr 5
- GIF du jour: "The meeting expi…THE MEETING EXPIRED?!" http://imgur.com/6BCKFkh
- Status updates
- Dao
- Gijs (this is like 4 weeks of updates because of PTO and e10s stuff and meeting cancellations)
- e10s tests
- dealing with outreachy admin and a few of the bugs that people fixed (and are continuing to fix) as part of their application process, including:
- RTL identity box issues: https://bugzilla.mozilla.org/show_bug.cgi?id=891897
- search dropdown styling on Linux: https://bugzilla.mozilla.org/show_bug.cgi?id=1238866
- missing UI on devedition on Linux: https://bugzilla.mozilla.org/show_bug.cgi?id=1212355
- regressions:
- waiting on review for https://bugzilla.mozilla.org/show_bug.cgi?id=1238032 ( closing pages that close a page they've opened when they themselves get closed can break the Firefox window)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1255526 - IE8 history import
- https://bugzilla.mozilla.org/show_bug.cgi?id=1257804 - about:reader URL copying
- https://bugzilla.mozilla.org/show_bug.cgi?id=1258344 - customize mode re-entering issues
- https://bugzilla.mozilla.org/show_bug.cgi?id=1254503 - in some cases the location bar could break completely
- https://bugzilla.mozilla.org/show_bug.cgi?id=1130411 was a top intermittent, seems to now be fixed (woo)
- https://bugzilla.mozilla.org/show_bug.cgi?id=735251 - ugly focus rings on OS X now gone!
- https://bugzilla.mozilla.org/show_bug.cgi?id=1256165 - issue with our determination of the width/scrollability of about:home on launch
- https://bugzilla.mozilla.org/show_bug.cgi?id=1256085 - hamburger button pressed state could get messed up
- I wrote a thing for writing (access-control-listed!) prefs from the content process: https://bugzilla.mozilla.org/show_bug.cgi?id=1252855
- Jared
- Katie, my Outreachy intern has been working on https://bugzilla.mozilla.org/show_bug.cgi?id=1247214 (context menus in preferences have wonky fonts)
- Katie also landed a patch to convert strings to use curly quotes instead of straight quotes https://bugzilla.mozilla.org/show_bug.cgi?id=1151449
- Katie also renamed "Unsorted bookmarks" to "Other bookmarks". https://bugzilla.mozilla.org/show_bug.cgi?id=1257599
- I landed a test and fixed a bunch of strings to now use curly quotes. The test will prevent regressions. https://bugzilla.mozilla.org/show_bug.cgi?id=1259859
- Working on investigating bug 1252224 (Doorhanger transitions are janky). Looks like we're doing some extra work after the "popupshowing" event
- Jared++
- Mike
- e10s tests
- Some final follow-up work re. Loop/ Hello
- Philipp
- Need to do a round of bug prioritization now that the team is back from e10s hiatus
- Working on getting final mocks for all platforms for the session restore button in the tab bar
- Stephen
- Verdi
- Unable to disable "recently bookmarked" https://bugzilla.mozilla.org/show_bug.cgi?id=1248268#c38
- Roundtable
- request for Dao: once your post-PTO-email-stack has been sufficiently reduced, can you check https://bugzilla.mozilla.org/show_bug.cgi?id=1208760 and help out in terms of what you thought we needed to do there? I couldn't figure it out from the original bug and such.
Mar 29
- GIF du jour: MEETING IS ON, good to see you all again
- Status updates
- Dao
- Gijs
- Jared
- https://bugzilla.mozilla.org/show_bug.cgi?id=1259859 and two other related bugs are changing straight quotes to curly quotes, and three-dots to ellipsis.
- Mike
- Working on investigating intermittents on OSX 10.6 and converting chrome tests to cover e10s too.
- Philipp
- Stephen
- Fixed five year old OS X sidebar styling bug: https://bugzilla.mozilla.org/show_bug.cgi?id=680256
- SVG Graphic Perf: https://bugzilla.mozilla.org/show_bug.cgi?id=1054016
- Verdi
- Roundtable
Mar 22
NO MEETING TODAY due to E10S test fixing and a conflict with the monthly MoCo meeting. NO penguins allowed: http://i.imgur.com/Ox3Ascf.gifv (I expect we'll meet next week though, as E10S work starts to wind down!)
Mar 15
NO MEETING TODAY, please keep working on E10S tests and vacuuming your cats! https://i.imgur.com/4N1KuNx.gifv
Mar 08
NO MEETING TODAY, enjoy this gif of a cat in a monkey suit instead. http://i.imgur.com/Vp9Q38k.gifv
- GIF du jour:
- Status updates
- Dao
- would like to back out bug 1219804 from aurora because of some of the open regressions, most notably those with pending needinfo requests
- Gijs
- Jared
- no update, just been working on e10s tests
- Mike
- Philipp
- Stephen
- Verdi
- Dao
- Roundtable
Mar 01
- GIF du jour: urban foraging http://i.imgur.com/QIJSKWn.gifv
- This one cracked me up last week:
- This one cracked me up last week:
- Status updates
- Dao
- Gijs (request from jared: can we please remove the e10s test update and keep this meeting focused on qx work?)
- e10s tests, more e10s tests, more e10s tests
- some actually broken stuff in e10s, need to get some uplifts sorted for 46, namely:
- character encoding widget
- still WIP: offline storage quota warnings
- Slowly going through e10s perf bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1195386
- Some fairly low-hanging perf fruit in there if people are interested
- some actually broken stuff in e10s, need to get some uplifts sorted for 46, namely:
- Disabled osk on 45 release for windows 8, uplifted remaining fix to 46. Should be pretty good for 46 now.
- Fixed some consistency issues with the context menu in the middle of navigations (bug 1220160)
- Still need to get back to:
- https://bugzilla.mozilla.org/show_bug.cgi?id=798249 (url bar resetting)
- https://bugzilla.mozilla.org/show_bug.cgi?id=789945 (core prefs quality stuff)
- addon migration in fx refresh
- outreachy application for qx-type frontend style stuff accepted, need to tweak proposal the next few days
- e10s tests, more e10s tests, more e10s tests
- Jared
- Patch is up on bug 1095739 to ask user if they want to refresh Firefox after uninstalling/re-installing
- Got feedback from jimm and gijs, will put together a new patch after e10s work is finished
- Outreachy project is live
- Focus is on windows 10 bugs, reader mode entrance/exit, context menus in prefs, polishing tour panel margins/padding
- Review ping for shorlander for Bug 1246276 - Notification/Push Permission might be interpreted as a warning logo ?
- Patch is up on bug 1095739 to ask user if they want to refresh Firefox after uninstalling/re-installing
- Mike
- Well, hum, I've been working on e10s stuffs.
- Philipp
- Stephen
- Verdi
- Roundtable
Feb 23
- GIF du jour: rererefrigerator http://i.imgur.com/6Wtqp2A.gifv
- Status updates
- Dao
- (PTO for the rest of the week)
- Gijs
- Still ongoing sec stuff, though less than last week
- Got a review for https://bugzilla.mozilla.org/show_bug.cgi?id=798249 (url bar resetting)
- need to write a new iteration, also need to address leaks and failing tests from try push
- Did an onboarding talk
- outreachy taking time as well
- installer pin-to-taskbar stuff landed \o/
- Windows 10 bug that we wontfixed https://bugzilla.mozilla.org/show_bug.cgi?id=1190351
- getting some initial feedback on core preferences quality work in https://bugzilla.mozilla.org/show_bug.cgi?id=789945
- Haven't looked at this in detail yet; will likely need to take some time to address feedback, scary "threads in C++" stuff!
- Landing fixes for e10s for the customizableui tests
- most already on fx-team, 2 more to go
- likely going to be picking up other e10s test stuff once that lands + sticks
- Jared
- Landed installer changes to not offer Firefox as default browser if opted-out in installer (bug 1041514)
- Landed bookmark button changes to show bookmark panel on first click (bug 1219794)
- Patch r+'d for removing noautohide from reader view uitour panel but some back and forth on if we want this (bug 1162750)
- I will pick up bug 1219725 (restore session button in tabbar) and bug 1111145 (update shadows for location and search bar on windows)
- Mike (facemuted due to baaad connection)
- Starting for real this week, after wrapping up last Hello tasks
- I think I'll start with writing test coverage for the '5 recent bookmarks' feature, before we extend its functionality.
- Philipp
- Out last week
- Welcome Mike!
- thank you sir ;-) There can't be enough Mike's
- Will find that bug about uneven paddings on tour bubbles
- bug 1180186
- Stephen
- Verdi
- Dao
- Roundtable
- Closure on bug 1162750?
- [philipp] wontfix
- cluster bugs
- Closure on bug 1162750?
Feb 16
- GIF du jour: 3 day weekend:
- Status updates
- Dao
- on vacation!
- Gijs
- Distracted by several security bugs
- Wrote a patch for https://bugzilla.mozilla.org/show_bug.cgi?id=798249 (url bar being reset)
- There are a /lot/ of dupes and "see also"/blockers/deps. It's unlikely that the patch will fix all the issues with our URL bar ever. Might make sense to file a separate tracker.
- Someone else did: https://bugzilla.mozilla.org/show_bug.cgi?id=1247816
- There are a /lot/ of dupes and "see also"/blockers/deps. It's unlikely that the patch will fix all the issues with our URL bar ever. Might make sense to file a separate tracker.
- Poked at https://bugzilla.mozilla.org/show_bug.cgi?id=1017919 but no patch; need to talk with Mossop some more.
- Still waiting for review on https://bugzilla.mozilla.org/show_bug.cgi?id=1229626 (pinning to taskbar from the (stub) installer)
- rstrong is on leave, asked bsmedberg who to redirect to
- On-screen keyboard:
- Fixed https://bugzilla.mozilla.org/show_bug.cgi?id=1239744
- Got everything uplifted to 45
- except that ^^ and the addition to the preferences (in 46) where people can turn it off.
- Edge bookmarks + reading list migration fixes
- All uplifted to 45
- Spent quite some time finally writing some testing for this, also made it all lintable:
- Misc fixes:
- https://bugzilla.mozilla.org/show_bug.cgi?id=408415 - favicon used to break when the hash ("#whatever") on the page changed during the load of the page
- https://bugzilla.mozilla.org/show_bug.cgi?id=1244259 - talos IO numbers now more stable (they'd become bimodal), and lower, for e10s.
- https://bugzilla.mozilla.org/show_bug.cgi?id=1134126 - a11y issue on about:home
- https://bugzilla.mozilla.org/show_bug.cgi?id=1246123 - draggability of empty space on the bookmarks toolbar
- (regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1219215 from 2 weeks ago)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1216478 - a11y followup from https://bugzilla.mozilla.org/show_bug.cgi?id=1123760 which I fixed a while ago
- In progress: https://bugzilla.mozilla.org/show_bug.cgi?id=1220160 - minor fixes to how we determine what happens when you use the context menu on a page that is loading or being replaced by another loading page.
- Jared
- Landed patch to lock the always ask pref when setting Firefox as default browser
- More progress on bookmark star and context menu tests
- Still need to work on installer patch
- Mike
- Not present in person - not feeling well - but can tell that I'll be picking up follow-ups from https://bugzilla.mozilla.org/show_bug.cgi?id=1219804 (bookmarks)
- Philipp
- Stephen
- Verdi
- Remove recent bookmarks folder from existing users?
- discussed, decided to: (1) don't create it in new profiles, (2) leave it in existing profiles, at least for now (3) check with marco to see if dropping support for smart folders is interesting for Places, and if so look at adding telemetry to understand usage
- Will work on answering questions and filing bugs this week
- Remove recent bookmarks folder from existing users?
- Dao
- Roundtable
- [dolske] bug list triaged, qx clusters
Feb 9
- GIF du jour: omnomnom http://i.imgur.com/h3Zmudk.gifv
- Status updates
- Dao
- patch up for recent-bookmarks in menu
- Gijs
- patch up for installer pin-to-taskbar stuff (https://bugzilla.mozilla.org/show_bug.cgi?id=1229626 )
- uplift all the osk things
- except https://bugzilla.mozilla.org/show_bug.cgi?id=1239744 . That still needs work, I expect it will be too scary for 45, tbh.
- uplift all the Edge migration things!
- still need to write a test, which involves more jsctypes. :-\ ( https://bugzilla.mozilla.org/show_bug.cgi?id=1236154 if people want to follow along)
- Looking at the following bugs for this week:
- https://bugzilla.mozilla.org/show_bug.cgi?id=798249
- https://bugzilla.mozilla.org/show_bug.cgi?id=1017919
- and the two/three mentioned above.
- Annnnd https://bugzilla.mozilla.org/show_bug.cgi?id=1244259 because perf regression
- looks to be figured out now, now just need to write a fix for talos code. \o/
- "just", famous last words, etc. etc.
- looks to be figured out now, now just need to write a fix for talos code. \o/
- Likely to look at some of the Outreachy stuff this week as well.
- Jared
- patch up for stopping users from unchecking "always ask" for default browsers if firefox is set as default
- came up with a way to mock the shellservice, which can be used in bug 1180714
- as the person who reviewed this, I will +1 that this is very useful!
- came up with a way to mock the shellservice, which can be used in bug 1180714
- patch up for review for showing the bookmarks panel on first click of the star
- got review feedback from rstrong on the installer patch, need to make another revision
- (non-QX), but close to landing rewrite of test_contextmenu.html for e10s
- patch up for stopping users from unchecking "always ask" for default browsers if firefox is set as default
- Philipp
- Stephen
- Verdi
- I'm way behind on answering questions and filing bugs. :( It may continue to be that way for the rest of the week.
- Mike
- Spectating mode this week, next week I'll be picking up bugs & taking names!
- ...and the gif-du-jour is just too awesome :')
- Dao
- Roundtable
- [jared] feedback on mentored projects
- fwiw, ISTR that the failure rate for the Outreachy projects is actually really good (ie low). Don't quote me. Don't over-plan it. But yeah.
- dolske proposed a meeting!
- (OK, I did too, in the email - it seems like a sensible idea...)
- [jared] feedback on mentored projects
Feb 2
- GIF du jour: http://imgur.com/NdGMA83 (you asked for one!)
- Status updates
- Dao
- Gijs
- most of https://bugzilla.mozilla.org/show_bug.cgi?id=1219215 now landed \o/
- Also a number of security thingies including https://bugzilla.mozilla.org/show_bug.cgi?id=1172165 . Quality including hardening us so we don't spin point releases for 0-days? Maybe? ;-)
- (more seriously, this took time, so I'm listing it)
- Edge migration
- Need to land https://bugzilla.mozilla.org/show_bug.cgi?id=1237679
- Need to update + re-request review for bookmarks stuff: https://bugzilla.mozilla.org/show_bug.cgi?id=1226556
- on-screen keyboard stuff
- filed https://bugzilla.mozilla.org/show_bug.cgi?id=1243345 for 45 stuff
- mostly all fixed and/or reviewed now
- still need to work on https://bugzilla.mozilla.org/show_bug.cgi?id=1239744
- filed https://bugzilla.mozilla.org/show_bug.cgi?id=1243345 for 45 stuff
- just getting going on https://bugzilla.mozilla.org/show_bug.cgi?id=1229626
- seems like it's going to be a loooooong slog - can't even build the thing
- Jared
- waiting on reviews for bug 1219794 (bookmark popup) and bug 1041514 (installer changes)
- might want to find a new reviewer for bug 1041514, but will leave the bookmark popup with marco since he already gave one review pass
- need to follow-up with the 'disable default-app hash handling' bug (bug 1240892) and make sure that it is uplifted where necessary
- waiting on reviews for bug 1219794 (bookmark popup) and bug 1041514 (installer changes)
- Philipp
- ¯\_(ツ)_/¯
- Stephen
- Verdi
- https://bugzilla.mozilla.org/show_bug.cgi?id=1244649 Show bookmarks toolbar when viewing a new tab? (I'm thinking no)
- Gijs: for whatever little it's worth, I agree with 'no'.
- Default browser prompt for first run - should I set a meeting? Should I just work it out with Philipp and comment in the bug?
- Verdi will look at dolskes email again
- Marketing's durable team focused on retention
- Onboarding and about:addons
- https://wiki.mozilla.org/Firefox/Onboarding
- https://bugzilla.mozilla.org/show_bug.cgi?id=1244649 Show bookmarks toolbar when viewing a new tab? (I'm thinking no)
- Roundtable
- Cory: discuss how best to combine these lists
- Onboarding Tracker: https://bugzilla.mozilla.org/show_bug.cgi?id=1229599
- Firefox QX Tracker: https://bugzilla.mozilla.org/show_bug.cgi?id=1244854
- Stephen: Looking for an estimate of work involved to add the System Share menu from Windows 10 and OS X: https://mozilla.invisionapp.com/share/5A5RW88TW#/screens
- Filing bugs!
- Cory: discuss how best to combine these lists
Jan 26
- GIF du jour:
- woo, there's a gif again!
- Status updates
- Dao
- patch for showing 5 most-recent bookmarks in menu
- reviews
- Gijs
- Linux notification bars, fixing unreadable text due to GTK3 switch
- Location bar stuff, talking with mak
- OSK / Edge bookmark importing broken
- 1200639 landed (later run pages)
- bug 1210366 (no more reader mode on youtube + pinterest, and so no more reader mode tour) landed
- \o/
- Fixed two other reader mode issues in time for 46
- UI pref for the OSK (for fx 46 onwards because l10n): bug 1239748 landed
- bluetooth keyboards now get ignored better for OSK (bug 1236058 fixed for 46) - needs uplift for 45
- Jared
- fixed 1240892 (disable default-app hash) for 44
- showing bookmark overlay on 1st click / autoclose up for review
- patch to not show default browser prompt if user opted-out in installer
- discussion on impact of default browser prompt -- early thread looking like it's not significant
- Philipp
- In an activity stream work week all week working on activity stream
- Stephen
- Also in an activity stream work week
- Mostly working on Styleguide stuff
- Verdi
- has plan in head for 1095739 :)
- will be expanding onboarding bug list and unifying into QX list
- https://docs.google.com/document/d/1kTstat7lQCM2QU0BbZ0EtXJeyk15jV3JFwkkR4_UE0E/edit
- Dao
- Roundtable
- Welcome Cory!
- Bug lists and process and stuff
Jan 19
- GIF du jour: The cup is half ful…wat
- Status updates
- Dao
- landed bug 1098468
- not sure how to proceed in bug 1219804
- Places arch. makes this difficult (assumes views folders/popups)
- worth investigating / prototyping to see how complicated this may be
- Gijs
- some osk work
- linux beta regression in notification bars making them unreadable (bug 1240528)
- almost have a patch for bug 1200639
- mach artifact stuff
- now works on all desktop things and for tests. See last week's update for 'howto'
- about:home issue with snippets fixed on 45+ ( https://bugzilla.mozilla.org/show_bug.cgi?id=1237350 )
- bug 789945 - async pref writes for better pref persistence and less IO churn on the main thread
- bug 1219215 for window dragging and tab hover/drag fixes
- bug 1005098 for titlebars influencing window opening on windows
- Jared
- landed bug 1238712 to remove duplication between shell services
- poked at bug 1219804 (showing last 5 recent bookmarks in menu) but stopped momentarily when seeing different usability issues (will let Dao take that over)
- picked up bug 1219794 to show the bookmark overlay on first click of bookmark star
- Philipp
- Steven
- Verdi
- Dao
- Roundtable
Jan 12 (our meeting overlaps with the MoCo meeting, so notes-only unless that one ends early)
- GIF du jour: "Where'd the QX meeting go?"
- Status updates
- Dao
- figured out the leak from bug 1219788, relanded
- bug 1207422, bug 1207423, bug 1207424 fixed and uplifted to 45 and 44
- Gijs
- Windows artifact things landed, woo!
- Note that work is still ongoing to make this work with mochitest and xpcshell-test, so you can't run tests with these builds yet. Coming soon!
- Also available on OSX and Linux. TL;DR: Put:
- ac_add_options --enable-artifact-builds
- ac_add_options --disable-compile-environment
- in your .mozconfig file.
- Clobber (or use a different objdir)
- ./mach configure
- ./mach build
- Tab groups stuff now all wound up (through wontfix/invalid, it has to be said - no more patches landed since last week)
- As Jared noted, going to turn off OSK on win8 on 44 in bug 1238892.
- Still investigating how to fix "properly" on 45+, but getting sidetracked by other things...
- specifically, there are:
- issues with bluetooth keyboards
- generic question of how assertive we should be about opening keyboard on win8 (this + previous is why we're disabling on win8(.1))
- issues with how we hide/reopen the keyboard when switching between input fields (totally broken for soft-keyboard "Tab" presses, visually not compelling for all other cases (flicker))
- specifically, there are:
- Still investigating how to fix "properly" on 45+, but getting sidetracked by other things...
- No progress on Edge stuff, also due to getting sidetracked...
- Still trying to get to the URL bar things as well...
- Will be looking at https://bugzilla.mozilla.org/show_bug.cgi?id=1210366 .
- Sidetracked by:
- Had to spend some time on a talos regression caused by Pocket-related work
- Helped diagnose https://bugzilla.mozilla.org/show_bug.cgi?id=1235821
- connected to perf gains on windows by :chutten, woo!
- Reviews and discussions of webextensions panels - https://bugzilla.mozilla.org/show_bug.cgi?id=1217129
- about:home snippets issues (regression of bug I reviewed): https://bugzilla.mozilla.org/show_bug.cgi?id=1237350
- triage-related bug churn and fixes
- other reviews
- generally suffering from cold/being flu-y and slow and the like
- Windows artifact things landed, woo!
- Jared
- landed bug 1229636, which removed the "new tab updated!" message
- working on bug 1238712 to remove duplication between the shell services across platforms
- this work may simplify the work needed for bugs 1041514, 1143116, 1189038
- looked in to some on-screen keyboard issues with Gijs and we decided to disable OSK for Win8 users until we fix an issue with bluetooth keyboards (bug 1238892)
- non-QX work
- landed bug 1087114 to get an in-content pref test running on e10s
- Philipp
- Steven
- Verdi
- Dao
- Roundtable
Jan 5 (2016)
- GIF du jour: Happy New Year!
- Status updates
- Dao
- window resize bug finally landed, with some tests disabled
- working on 1219788
- Gijs
- Regressions from https://bugzilla.mozilla.org/show_bug.cgi?id=332195 (tab modal dialogs no longer focusing their tabs)
- Had to revert that specifically for beforeunload dialogs
- Now all fixed on 44+, but that was most of last week gone
- Edge Migration:
- Landed reading list things on Nightly
- Kind of want to write some kind of test for the generic module I wrote. Need to think/experiment with how to do that because just dumping in an ESE db in the main mozilla-central repo won't work
- Also need to update bookmarks to use this generic code
- Need to investigate exactly how parent/child relations work in that table so we import folders correctly...
- Also suspect we'll need to tell the user to quit Edge before migrating
- Still need to file a bug about that
- Landed reading list things on Nightly
- Tab Groups
- Landed fix for safe mode use of the migration path, already requested aurora uplift
- QA linked up an issue that wasn't previously in the bug tree that I'd therefore missed: https://bugzilla.mozilla.org/show_bug.cgi?id=1231135
- Need to ensure the migration page keeps focus. Not trivial because of how the "you've upgraded" or "welcome to windows 10" pages get added (dynamically after session restore finishes, I'm fairly sure). Need to look into this more.
- Might be lower prio if we don't have a "what's new" page for 45
- Need to ensure the migration page keeps focus. Not trivial because of how the "you've upgraded" or "welcome to windows 10" pages get added (dynamically after session restore finishes, I'm fairly sure). Need to look into this more.
- Windows artifact builds! - https://bugzilla.mozilla.org/show_bug.cgi?id=1236111
- http://www.ncalexander.net/blog/2015/12/31/firefox-artifact-builds-for-mac/
- Waiting for reviews (not done yet! :-( )
- Already working on OSX though, see blogpost.
- This will make building on Windows very very very fast because you won't need to compile anything anymore
- This will make development on my Surface Pro a lot better
- Likely good for UX and other not-primarily-engineering folks, too.
- [philipp] That sounds amazing! How does it work?
- Nick's blogpost is probably the best intro. The Windows portion hasn't been reviewed yet, but it should work today on OS X.
- [philipp] That sounds amazing! How does it work?
- Other small fry:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1232800 - tab hover styling issue when using keyboard shortcuts to move them
- https://bugzilla.mozilla.org/show_bug.cgi?id=1182072 e10s intermittent orange fix
- https://bugzilla.mozilla.org/show_bug.cgi?id=1235845 pocket styling issue now that that's moved to an add-on
- This fix (not the moving to an add-on) seems to have caused a talos regression. Not entirely sure why. Waiting for confirmation that it's me from jmaher.
- https://bugzilla.mozilla.org/show_bug.cgi?id=1222792 reader mode infinite reload issue. Uplifted to 44/45.
- Been trying to poke at https://bugzilla.mozilla.org/show_bug.cgi?id=798249 (url bar reverting / not showing the right thing / concurrent loads being confused) for a while
- not gotten really anywhere with that yet
- Regressions from https://bugzilla.mozilla.org/show_bug.cgi?id=332195 (tab modal dialogs no longer focusing their tabs)
- Jared
- Philipp
- Finished going through the QX list (finally!)
- 14 straight-up bugs
- 7 high value enhancements
- The rest are low-mid value enhancements (though still valuable in combination!)
- The (full) list: https://bwinton.github.io/d3Experiments/qx.html
- Finished going through the QX list (finally!)
- Steven
- Verdi
- Dao
- Roundtable
- Lots of company-confidential bugs associated with win10 landing page - can those just be marked non-confidential now that that's all over & done with?
- I have heard rumours Blair is coming back! Is he going to join "us"?
Dec 15
- GIF du jour:
- Status updates
- Dao
- Gijs
- Can't be here because of other commitments, sorry!
- Done:
- more work on tab groups migration
- Various other small bugfixes (reader mode, Windows theme)
- Edge migration work (password issues finished and landed today; reading list under review; bookmarks are next once the reading list database API work gets r+)
- Landed OSK improvement for already-focused inputs
- needs uplift
- Wrote blog entry about panorama removal reasoning, getting dolske to review via google docs before I publish
- Tried to write up the css-image-only approval hook; test env is broken so no idea if it works or not - needs refinement!
- Todo:
- Finish up Edge migration improvements
- Finish or wontfix tab groups migration warning (on beta later this week...)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1224635
- Do people have ideas/feedback about how important fixing that particular bug is?
- https://bugzilla.mozilla.org/show_bug.cgi?id=1224635
- Go through OSK bugs filed and prioritize fixes
- Several emails I need to write post-mozlando, related to
- removing XBL from content process
- contribution workshop stuff
- diversity/inclusion
- Make more code eslint-able
- This has already turned up correctness issues in toolkit/ where other people took the lead; I fully expect to find more in browser/.
- PTO from 18th (Friday) inclusive until the 28th of December (also inclusive)
- Means bookmarks stuff will likely be January if it's me.
- Jared
- Philipp
- Having connection problems today -- written update only (I can't join anymore for some reason)
- Reviewing the QX list (started in Mozlando together with dolske) -- we got about 1/3 through, needs to be finished
- Filed a bunch of bugs around Emoji on Windows (which we should fix and then marked the hell out of in SE Asia -- incidentially, the area of the world where emoji are most widely used is the same area where desktop OS support for emoji is the worst)
- Ship the Firefox OS emoji font on Windows: https://bugzilla.mozilla.org/show_bug.cgi?id=1231701
- Add an emoji picker (all platforms): https://bugzilla.mozilla.org/show_bug.cgi?id=1232371
- Some quality issues around push remain
- Will be on vacation all of next week
- Can't reconnect...
- Steven
- Verdi
- Windows 10 start menu tile https://bugzilla.mozilla.org/show_bug.cgi?id=1232679
- Roundtable
Dec 1
- GIF du jour: http://imgur.com/CmI0P1E.gifv
- Status updates
- Dao
- Gijs
- landed tab groups - hoping it sticks
- 25k LOC removed! (We need a removed code leaderboard)
- still working on JET / ESE migration things
- landed tab groups - hoping it sticks
- Jared
- Philipp
- Steven
- Verdi
- Roundtable
Nov 23
- GIF du jour:
- Status updates
- Dao
- Gijs
- tab groups
- waiting on Philipp/Verdi/someone to confirm UX/UI;
- have code review, need to update patches for that;
- edge data migration
- yay more JET / ESE horribleness is breaking reading list import
- favourites are now in this DB too so it seems worth investigating it in more detail. Super annoying that the docs are minimal and there is no debug information
- on-screen keyboard
- tab groups
- Jared
- Philipp
- Steven
- Verdi
- Reader Mode
- Refresh
- Roundtable
Nov 17
- GIF du jour:
- Status updates
- Dao
- Gijs
- All the panorama (so that we can have none of the panorama...)
- Removing panorama (90% r+)
- Panorama data migration (100% r? + ui-r?)
- Need to update styling of infobar inside panorama
- Need to tweak when to show infobar outside of panorama
- Windows on-screen keyboard showing when there are no physical keyboards
- Landed on nightly, uplift to 43+44 pending
- https://bugzilla.mozilla.org/show_bug.cgi?id=1221947
- Clearing up backlog of other bugs that I was looking at / asked to look at
- https://bugzilla.mozilla.org/show_bug.cgi?id=1191468
- number of devedition styling bugs
- number of reader mode issues
- https://bugzilla.mozilla.org/show_bug.cgi?id=1040005
- Edge migration totally broken in newer versions of windows 10. Going to look at this, but need to download said multi-gb updates to win10 first. :-\
- Yosemite changes broke stuff
- https://bugzilla.mozilla.org/show_bug.cgi?id=1223550
- Unclear how to fix - ideas?
- Once there's time left, might start looking at bookmarks stuff ( https://bugzilla.mozilla.org/show_bug.cgi?id=1219810 )
- All the panorama (so that we can have none of the panorama...)
- Jared
- Philipp
- bwinton asking for help on this: https://bugzilla.mozilla.org/show_bug.cgi?id=1217129
- --> webextension team should own
- bwinton asking for help on this: https://bugzilla.mozilla.org/show_bug.cgi?id=1217129
- Steven
- Verdi
- Tab groups
- Bookmarks
- Window size
- Roundtable
- FX_MIGRATION_ERRORS: https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2015-11-12&keys=ie!chrome!edge!__none__&max_channel_version=beta%252F43&measure=FX_MIGRATION_ERRORS&min_channel_version=aurora%252F42&product=Firefox&sanitize=1&sort_keys=submissions&start_date=2015-11-02&table=0&trim=1&use_submission_date=0
- FX_MIGRATION_ERRORS: Evolution -> http://mzl.la/1NZQJ5o
Nov 10
- GIF du jour:
- Status updates
- Dao
- Gijs
- Jared
- Philipp
- Form work:
- META BUG: https://bugzilla.mozilla.org/show_bug.cgi?id=1219673
- Dropdown styling https://bugzilla.mozilla.org/show_bug.cgi?id=1091592 (includes spec)
- Buttons and text fields: https://bugzilla.mozilla.org/show_bug.cgi?id=997190 (has a WIP patch from ntim, needs to be finished)
- META BUG: https://bugzilla.mozilla.org/show_bug.cgi?id=1219673
- Bookmarks work:
- Form work:
- Steven
- Verdi
- Additional onboarding work:
- Bookmarking: https://bugzilla.mozilla.org/show_bug.cgi?id=1219810
- Open a page on a second or later run and/or after some amount of time https://bugzilla.mozilla.org/show_bug.cgi?id=1200639
- Reset Firefox: Preserve extensions but disable all of them https://bugzilla.mozilla.org/show_bug.cgi?id=1017919
- New user experience after uninstall https://bugzilla.mozilla.org/show_bug.cgi?id=1095739
- Fix Firefox window size on first run https://bugzilla.mozilla.org/show_bug.cgi?id=384336 (dao working on this)
- Fix pinning Firefox to the taskbar in Windows 7 and 8 when installing with the stub installer
- Remove the new tab FTU (first time use tour)
- Bug to make Reader View FTU show on actual articles https://bugzilla.mozilla.org/show_bug.cgi?id=1210366
- Defer data choices infobar https://bugzilla.mozilla.org/show_bug.cgi?id=1199706
- Account sign-in in the migrator https://bugzilla.mozilla.org/show_bug.cgi?id=670989
- Tab groups
- Additional onboarding work:
- Roundtable
- [philipp] Mentoring for QX bugs
(No meeting Nov 3rd)
Oct 27
- GIF du jour:
- Status updates
- Dao
- Gijs
- at OSCON Amsterdam today and yesterday
- tab selection on alert/prompt/confirm landed yesterday
- still planning to look at Jared's suggested location bar thing (from last week)
- actually working on some other location bar issues (security-related) right now
- Windows on-screen keyboard things all uplifted to 43, now just need to flip the pref
- approval request in https://bugzilla.mozilla.org/show_bug.cgi?id=1217806
- Jared
- Philipp
- Will make sure that UX work for web forms is done and bugs are ready
- Steven
- Verdi
- Roundtable
Oct 20
- Status updates
- Dao
- landed bug 1215093 for better styling for toolbar buttons on lightweight themes. intend to uplift to aurora
- landed bug 1215567 to help with bug 1214707 (decreased contrast between the selected tab and background tabs)
- pending uiwanted / needinfo in bug 1214707 to see if we need to do more
- Gijs
- 332195 has ux-review, need to address implementation issues identified by mconley
- on-screen keyboard stuffs! Now enabled on win8+ on nightly, aurora uplift requested
- per discussion with jared, going to try to get this to ride the 43 train
- improved telemetry for tablet mode
- as a bonus, removed minimize/maximize buttons in tablet mode (waiting for review from Jared; telemetry is r?MattN -- but both of these are from today)
- improved some styling things like notification bars
- Jared
- noted Bug 798249 - Changing URL locations while a page is loading temporarily reverts the URL
- Philipp
- pulled together some proposals on updating form controls
- Steven
- Verdi
- Dao
- Roundtable
Oct 13
- GIF du jour:
- Status updates
- Dao
- Gijs
- telemetry for tab view wrapped up 1210773
- migrator telemetry in privacy review
- bug 332195 - alerts stealing focus
- Jared
- Philipp
- Steven
- Verdi
- Roundtable
Previous meeting etherpads: https://etherpad-mozilla.org/fx-windows-10 and https://old.etherpad-mozilla.org/fx-windows-qx