Places/AsyncAPIsForSync: Difference between revisions

m
no edit summary
mNo edit summary
Line 380: Line 380:
                               in unsigned long aPlaces,
                               in unsigned long aPlaces,
                               [optional] in nsIVisitInfoCallback aCallback);
                               [optional] in nsIVisitInfoCallback aCallback);
== Notes and feedback on Proposal ==
I suggest using WithVisits rather than AndVisits... But as we did for bookmarks, there is not much gain in specifying WithVisits or WithInfo if all the APIs use them, maybe just updatePlace(), I can pass an empty array of visits after all. --mak
nsIVisitInfo is missing from_visit and session. While it's possible Sync does not sync them, I think they should since we use them to discard useless redirects. Or they should discard redirects. Btw we want them in the interface. --mak
Sync does not sync ALL visits, do they need visit_count though? --mak
Confirmed users
595

edits