Thunderbird:CodeCleanup: Difference between revisions

m
→‎IDL Changes: grammar fix
No edit summary
m (→‎IDL Changes: grammar fix)
Line 16: Line 16:


== IDL Changes ==
== IDL Changes ==
Many of the mailnews interfaces using string and wstring for string arguments. In many cases, we can convert these to AString and ACString. This change allows C++ callers to more efficiently manage the strings using nsString/nsCStrings. However it doesn't always make sense to do so. For instance in nsIMsgIdentity.idl, I found some string arguments that were passed directly to the pref service (which requires a char *), and all the call sites were passing in string literals. Changing that argument to ACString wouldn't have made sense. But in general, most things can be converted.  
Many of the mailnews interfaces use string and wstring for string arguments. In many cases, we can convert these to AString and ACString. This change allows C++ callers to more efficiently manage the strings using nsString/nsCStrings. However it doesn't always make sense to do so. For instance in nsIMsgIdentity.idl, I found some string arguments that were passed directly to the pref service (which requires a char *), and all the call sites were passing in string literals. Changing that argument to ACString wouldn't have made sense. But in general, most things can be converted.  


  <span class="highlightred">- attribute wstring key;</span>
  <span class="highlightred">- attribute wstring key;</span>
99

edits